From: "Kévin Le Gouguec" <kevin.legouguec@gmail.com>
To: Drew Adams <drew.adams@oracle.com>
Cc: Alan Mackenzie <acm@muc.de>,
Augusto Stoffel <arstoffel@gmail.com>,
Stefan Monnier <monnier@iro.umontreal.ca>,
"emacs-devel@gnu.org" <emacs-devel@gnu.org>
Subject: Re: [External] : Re: [WIP PATCH] Controlling Isearch from the minibuffer
Date: Thu, 13 May 2021 17:12:50 +0200 [thread overview]
Message-ID: <87eeeazmz1.fsf@gmail.com> (raw)
In-Reply-To: SA2PR10MB4474FD4D6B268832D4DCCFBCF3529@SA2PR10MB4474.namprd10.prod.outlook.com
Drew Adams <drew.adams@oracle.com> writes:
>> While isearching, I regularly find myself reaching for regular
>> navigation/editing commands (C-a, C-b, M-b, M-DEL… even C-x o, on
>> occasion),
>
> You "regularly" want to move within the search-pattern,
> to do some editing of it besides at the end. Is that it?
>
> But in that case, what about `C-x o'?
I'll admit that I struggle to see why I would have needed C-x o; I only
have the faintest impression that once in a blue moon I've wanted to use
it during a search. Moving to a piece of text I was too lazy to retype
in order to kill it? Do some light editing to the buffer before
resuming the search? Surely nothing that I couldn't do by interrupting
the search, doing the thing, then C-s M-p (which… brings up a
minibuffer, AFAICT? Which means all the usual navigation/editing
commands are available).
>> This thread made me discover M-e,
>
> Really? In that case, I suggest you first try using
> that to do your editing, before asking that Isearch
> be rewritten to be minibuffer-based. It's really not
> a big deal to use `M-e', IMO.
Sure; again, I didn't read the thread thoroughly, but my takeaway is
that the overarching tone of the proposal is indeed "it's not a big deal
to get used to isearch's idiosyncrasies, /but/ bolting an incremental
search on top of the minibuffer would [insert motivation]".
> How would you feel about what I described as existing
> in isearch+.el:
>
> Customize `isearchp-initiate-edit-commands' to include
> `beginning-of-line' (`C-a'), `backward-kill-word'
> (`M-DEL'),...?
>
> It already includes `C-b', `M-b', `C-M-b', `<left>',
> C-<left>', and `M-<left>'. Your wish is half granted,
> even by default.
I described the proposal under discussion as "bolting an incremental
search on top of the minibuffer"; my reading of your description of
isearch+.el is "bolting regular editing/navigation keys on top of
isearch".
I don't think the distinction would matter much to me as a user, so I'd
probably be satisfied with isearch+.el (barring the manual curating of
isearchp-initiate-edit-commands).
As a theoretical greenfield implementer though, I'd probably start from
the existing minibuffer UI, since I'd get all the editing/navigation
commands "for free".
> Yes, to tell Emacs you're done editing the pattern in
> a non-trivial way you need to hit `C-s'. Worth it, IMO.
I assume you have made this case elsewhere and I regret not taking the
time to dig it up, so apologies for making you repeat yourself: what
inherent qualities does the current, non-minibuffer-based,
implementation of isearch possess, that would be lost by using a
minibuffer?
Off the top of my head, I'd say "being able to exit a search and proceed
with my business using any key that is not bound in isearch-mode-map";
e.g. I regularly C-s a heading in org-mode and enjoy being able to C-c
C-x C-i (org-clock-in) without having to exit isearch first.
I suspect that would be implementable as a user option whose semantics
would be "if a key is neither self-inserting nor part of
isearch-mode-map, exit the minibuffer and run that key's binding".
I'm sure there are other reasons why the current implementation is
preferable though, hence my question.
next prev parent reply other threads:[~2021-05-13 15:12 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-08 10:13 [WIP PATCH] Controlling Isearch from the minibuffer Augusto Stoffel
2021-05-09 13:36 ` Alan Mackenzie
2021-05-09 17:58 ` Augusto Stoffel
2021-05-10 19:51 ` Alan Mackenzie
2021-05-11 9:00 ` Augusto Stoffel
2021-05-11 15:34 ` [External] : " Drew Adams
2021-05-11 18:31 ` Juri Linkov
2021-05-11 19:38 ` Drew Adams
2021-05-12 6:45 ` Augusto Stoffel
2021-05-12 12:44 ` Stefan Monnier
2021-05-12 15:31 ` Drew Adams
2021-05-12 22:17 ` Kévin Le Gouguec
2021-05-12 23:07 ` Drew Adams
2021-05-13 15:12 ` Kévin Le Gouguec [this message]
2021-05-12 21:09 ` Augusto Stoffel
2021-05-12 15:30 ` Drew Adams
2021-05-09 19:09 ` Juri Linkov
2021-05-09 19:05 ` Juri Linkov
2021-05-10 20:24 ` Augusto Stoffel
2021-05-10 21:17 ` Juri Linkov
2021-05-12 6:40 ` Augusto Stoffel
2021-05-12 17:13 ` Juri Linkov
2021-05-12 20:52 ` Augusto Stoffel
2021-05-13 16:31 ` Juri Linkov
2021-05-13 20:12 ` [ELPA?] " Augusto Stoffel
2021-05-14 1:17 ` Jean Louis
2021-05-14 8:36 ` Augusto Stoffel
2021-05-14 17:30 ` Augusto Stoffel
2021-05-14 18:20 ` Juri Linkov
2021-05-16 11:00 ` Augusto Stoffel
2021-05-16 18:19 ` Juri Linkov
2021-05-25 20:50 ` Juri Linkov
2021-05-29 11:48 ` Augusto Stoffel
2021-05-14 18:18 ` Juri Linkov
2021-05-16 18:12 ` Juri Linkov
2021-05-16 18:49 ` Augusto Stoffel
2021-05-21 9:09 ` Augusto Stoffel
2021-05-21 10:25 ` Eli Zaretskii
2021-05-21 11:56 ` Augusto Stoffel
2021-05-21 12:31 ` Eli Zaretskii
2021-05-21 12:49 ` Augusto Stoffel
2021-05-21 15:05 ` Stefan Monnier
2021-05-21 15:09 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eeeazmz1.fsf@gmail.com \
--to=kevin.legouguec@gmail.com \
--cc=acm@muc.de \
--cc=arstoffel@gmail.com \
--cc=drew.adams@oracle.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).