Re: [ELPA?] Controlling Isearch from the minibuffer

[Juri Linkov <juri@linkov.net>]

>> Do you see the correct lazy-count values in the minibuffer and comint
>> after removing `(null isearch-message-function)'?
>>
>>> -          (funcall (or isearch-message-function #'isearch-message)))
>>> +          (isearch-message))
>
> I would see the number of matches in the current line, which is only
> logical.  But the relevant information here would be number of
> candidates in the minibuffer/comint history that match the string, as
> opposed to the total number of matches among those candidates.  So I
> believe these modes should implement their own lazy count.  I just
> disabled the count in the new patch below.

Thanks, binding isearch-lazy-count buffer-locally to nil
is the right way to disable lazy-count until it's implemented
in these modes.

> Now, I took a closer look at the history of changes around lazy
> highlight and the interactions with other features seems very tricky.
> I'm not super confident about the patch I'm attaching, but if you are
> willing to review it and test a bit, I hope it helps.

Everything looks right, but this needs more testing before pushing.

> +(defun isearch-standard-message (&optional c-q-hack ellipsis)
> +  "Generate and print the standard Isearch message string."

A more naming-standard complying name would be isearch-default-message,
or even better isearch-message-default like isearch-search-fun-default
(no need to send a new patch only with renamings).