From: Augusto Stoffel <arstoffel@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Alan Mackenzie <acm@muc.de>, Drew Adams <drew.adams@oracle.com>,
"emacs-devel@gnu.org" <emacs-devel@gnu.org>
Subject: Re: [External] : Re: [WIP PATCH] Controlling Isearch from the minibuffer
Date: Wed, 12 May 2021 23:09:26 +0200 [thread overview]
Message-ID: <877dk3r75l.fsf@gmail.com> (raw)
In-Reply-To: <jwvmtt0ktyf.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Wed, 12 May 2021 08:44:19 -0400")
On Wed, 12 May 2021 at 08:44, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>> You can think of my patch as (1) adding lazy highlight/count and an M-s
>> prefix to the good old M-e, which is indeed a bit of work,
>
> [ Sorry I haven't followed this thread very closely, so just a comment
> from the sidelines: ]
>
> I don't know what this `M-s` thingy refers to, but I for one would very
> much welcome lazy highlighting during the `M-e` minibuffer editing.
The `M-s' thingy would be a prefix keymap including `isearch-occur'
`isearch-highlight-regexp' and what not.
>
>> and (2) adding the entirely optional minibuffer-controlled UI which
>> only takes a dozen of extra lines to implement.
>
> I don't know what impacts it might have on the UI, but I've often wished
> (from an implementation point of view) that Isearch used an actual plain
> old minibuffer rather than mimicking one (which doesn't necessary mean
> it'd be a good idea either, just that it would have some benefits and
> that the downsides were not as immediately apparent ;-).
So far, the biggest hurdle I can see concerns the handling of commands
that end the search and read from the minibuffer afterwards, such as
`isearch-query-replace'. This is tricky because one has to somehow
unwind the `isearch-edit-string' minibuffer without relinquishing
control to its caller.
The first patch I sent in this thread used throw/catch of a continuation
function for this. The second does the following in a pre-command hook,
which seems to work:
(when (member this-command isearch-edit--quitting-commands)
(run-with-timer 0 nil 'command-execute this-command)
(exit-minibuffer))
I can't think of any simpler alternatives (and I still prefer the
throw/catch solution).
>
>
> Stefan
next prev parent reply other threads:[~2021-05-12 21:09 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-08 10:13 [WIP PATCH] Controlling Isearch from the minibuffer Augusto Stoffel
2021-05-09 13:36 ` Alan Mackenzie
2021-05-09 17:58 ` Augusto Stoffel
2021-05-10 19:51 ` Alan Mackenzie
2021-05-11 9:00 ` Augusto Stoffel
2021-05-11 15:34 ` [External] : " Drew Adams
2021-05-11 18:31 ` Juri Linkov
2021-05-11 19:38 ` Drew Adams
2021-05-12 6:45 ` Augusto Stoffel
2021-05-12 12:44 ` Stefan Monnier
2021-05-12 15:31 ` Drew Adams
2021-05-12 22:17 ` Kévin Le Gouguec
2021-05-12 23:07 ` Drew Adams
2021-05-13 15:12 ` Kévin Le Gouguec
2021-05-12 21:09 ` Augusto Stoffel [this message]
2021-05-12 15:30 ` Drew Adams
2021-05-09 19:09 ` Juri Linkov
2021-05-09 19:05 ` Juri Linkov
2021-05-10 20:24 ` Augusto Stoffel
2021-05-10 21:17 ` Juri Linkov
2021-05-12 6:40 ` Augusto Stoffel
2021-05-12 17:13 ` Juri Linkov
2021-05-12 20:52 ` Augusto Stoffel
2021-05-13 16:31 ` Juri Linkov
2021-05-13 20:12 ` [ELPA?] " Augusto Stoffel
2021-05-14 1:17 ` Jean Louis
2021-05-14 8:36 ` Augusto Stoffel
2021-05-14 17:30 ` Augusto Stoffel
2021-05-14 18:20 ` Juri Linkov
2021-05-16 11:00 ` Augusto Stoffel
2021-05-16 18:19 ` Juri Linkov
2021-05-25 20:50 ` Juri Linkov
2021-05-29 11:48 ` Augusto Stoffel
2021-05-14 18:18 ` Juri Linkov
2021-05-16 18:12 ` Juri Linkov
2021-05-16 18:49 ` Augusto Stoffel
2021-05-21 9:09 ` Augusto Stoffel
2021-05-21 10:25 ` Eli Zaretskii
2021-05-21 11:56 ` Augusto Stoffel
2021-05-21 12:31 ` Eli Zaretskii
2021-05-21 12:49 ` Augusto Stoffel
2021-05-21 15:05 ` Stefan Monnier
2021-05-21 15:09 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dk3r75l.fsf@gmail.com \
--to=arstoffel@gmail.com \
--cc=acm@muc.de \
--cc=drew.adams@oracle.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).