From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: [ELPA?] Controlling Isearch from the minibuffer Date: Tue, 25 May 2021 23:50:27 +0300 Organization: LINKOV.NET Message-ID: <87wnrm35d8.fsf@mail.linkov.net> References: <87zgx5cz33.fsf@gmail.com> <87o8djohqf.fsf@mail.linkov.net> <87eeeenxqq.fsf@gmail.com> <87h7jath3m.fsf@mail.linkov.net> <87mtt0wj37.fsf@gmail.com> <87cztvx4dc.fsf@mail.linkov.net> <87bl9fr7xh.fsf@gmail.com> <87tun6n12v.fsf@mail.linkov.net> <87lf8i8kba.fsf_-_@gmail.com> <878s4hxly0.fsf@gmail.com> <87im3l5g9y.fsf@mail.linkov.net> <877djzymcf.fsf@gmail.com> <87eee65yor.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18251"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org To: Augusto Stoffel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue May 25 22:53:54 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lle3k-0004dx-UQ for ged-emacs-devel@m.gmane-mx.org; Tue, 25 May 2021 22:53:52 +0200 Original-Received: from localhost ([::1]:56806 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lle3k-0000zi-10 for ged-emacs-devel@m.gmane-mx.org; Tue, 25 May 2021 16:53:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54868) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lle20-000847-Bx for emacs-devel@gnu.org; Tue, 25 May 2021 16:52:04 -0400 Original-Received: from relay1-d.mail.gandi.net ([217.70.183.193]:21785) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lle1y-0004Au-1W for emacs-devel@gnu.org; Tue, 25 May 2021 16:52:04 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 4F02C240003; Tue, 25 May 2021 20:51:56 +0000 (UTC) In-Reply-To: <87eee65yor.fsf@mail.linkov.net> (Juri Linkov's message of "Sun, 16 May 2021 21:19:16 +0300") Received-SPF: pass client-ip=217.70.183.193; envelope-from=juri@linkov.net; helo=relay1-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269897 Archived-At: >> Now, I took a closer look at the history of changes around lazy >> highlight and the interactions with other features seems very tricky. >> I'm not super confident about the patch I'm attaching, but if you are >> willing to review it and test a bit, I hope it helps. > > Everything looks right, but this needs more testing before pushing. Testing revealed some problems: 1. After enabling isearch-lazy-count, modes that use lazy-highligh, such as e.g. query-replace displays the isearch message overwriting query-replace prompt. Maybe this is because of the removed check for 'isearch-mode' in isearch-lazy-highlight-* functions? 2. Using 'C-q' (isearch-quote-char) in the minibuffer or comint displays a truncated string, e.g. on 'M-! C-r C-q C-a'. Maybe the default message function should be called directly in isearch-quote-char? 3. Maybe the same default message function should be called directly also in some other functions like isearch-lazy-highlight-new-loop and isearch-lazy-highlight-buffer-update?