From: Juri Linkov <juri@linkov.net>
To: Augusto Stoffel <arstoffel@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: [ELPA?] Controlling Isearch from the minibuffer
Date: Fri, 14 May 2021 21:20:09 +0300 [thread overview]
Message-ID: <87im3l5g9y.fsf@mail.linkov.net> (raw)
In-Reply-To: <878s4hxly0.fsf@gmail.com> (Augusto Stoffel's message of "Fri, 14 May 2021 19:30:15 +0200")
>>>> Setting `isearch-message-function' is of no help, because there are some
>>>> tests for `(null isearch-message-function)' as well as some explicit
>>>> calls to `(isearch-message)' in isearch.el. As far as I can see, there
>>>> is no alternative to modifying the function `isearch-message' itself.
>>>
>>> Tests for `(null isearch-message-function)' were added as a temporary
>>> workaround until lazy count will be implemented in the minibuffer.
>>> We need to remove these workarounds anyway. So using isearch-message-function
>>> should be the right thing to do.
>>
>> Okay, that' a low hanging fruit then.
>
> I've attached a patch. I can't see any deleterious effect for the
> minibuffer and comint, which are the two places that set
> `isearch-message-function' in Emacs.
Do you see the correct lazy-count values in the minibuffer and comint
after removing `(null isearch-message-function)'?
> - (funcall (or isearch-message-function #'isearch-message)))
> + (isearch-message))
What do you think about adding `isearch-message' as the default value
of isearch-message-function? E.g.
#+begin_src diff
-(defvar isearch-message-function nil
+(defvar isearch-message-function #'isearch-message
#+end_src
next prev parent reply other threads:[~2021-05-14 18:20 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-08 10:13 [WIP PATCH] Controlling Isearch from the minibuffer Augusto Stoffel
2021-05-09 13:36 ` Alan Mackenzie
2021-05-09 17:58 ` Augusto Stoffel
2021-05-10 19:51 ` Alan Mackenzie
2021-05-11 9:00 ` Augusto Stoffel
2021-05-11 15:34 ` [External] : " Drew Adams
2021-05-11 18:31 ` Juri Linkov
2021-05-11 19:38 ` Drew Adams
2021-05-12 6:45 ` Augusto Stoffel
2021-05-12 12:44 ` Stefan Monnier
2021-05-12 15:31 ` Drew Adams
2021-05-12 22:17 ` Kévin Le Gouguec
2021-05-12 23:07 ` Drew Adams
2021-05-13 15:12 ` Kévin Le Gouguec
2021-05-12 21:09 ` Augusto Stoffel
2021-05-12 15:30 ` Drew Adams
2021-05-09 19:09 ` Juri Linkov
2021-05-09 19:05 ` Juri Linkov
2021-05-10 20:24 ` Augusto Stoffel
2021-05-10 21:17 ` Juri Linkov
2021-05-12 6:40 ` Augusto Stoffel
2021-05-12 17:13 ` Juri Linkov
2021-05-12 20:52 ` Augusto Stoffel
2021-05-13 16:31 ` Juri Linkov
2021-05-13 20:12 ` [ELPA?] " Augusto Stoffel
2021-05-14 1:17 ` Jean Louis
2021-05-14 8:36 ` Augusto Stoffel
2021-05-14 17:30 ` Augusto Stoffel
2021-05-14 18:20 ` Juri Linkov [this message]
2021-05-16 11:00 ` Augusto Stoffel
2021-05-16 18:19 ` Juri Linkov
2021-05-25 20:50 ` Juri Linkov
2021-05-29 11:48 ` Augusto Stoffel
2021-05-14 18:18 ` Juri Linkov
2021-05-16 18:12 ` Juri Linkov
2021-05-16 18:49 ` Augusto Stoffel
2021-05-21 9:09 ` Augusto Stoffel
2021-05-21 10:25 ` Eli Zaretskii
2021-05-21 11:56 ` Augusto Stoffel
2021-05-21 12:31 ` Eli Zaretskii
2021-05-21 12:49 ` Augusto Stoffel
2021-05-21 15:05 ` Stefan Monnier
2021-05-21 15:09 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87im3l5g9y.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=arstoffel@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).