From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Augusto Stoffel Newsgroups: gmane.emacs.devel Subject: Re: [ELPA?] Controlling Isearch from the minibuffer Date: Sun, 16 May 2021 20:49:13 +0200 Message-ID: <87pmxqbjkm.fsf@gmail.com> References: <87zgx5cz33.fsf@gmail.com> <87o8djohqf.fsf@mail.linkov.net> <87eeeenxqq.fsf@gmail.com> <87h7jath3m.fsf@mail.linkov.net> <87mtt0wj37.fsf@gmail.com> <87cztvx4dc.fsf@mail.linkov.net> <87bl9fr7xh.fsf@gmail.com> <87tun6n12v.fsf@mail.linkov.net> <87lf8i8kba.fsf_-_@gmail.com> <875yzl6v3x.fsf@mail.linkov.net> <87v97i4jy7.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31066"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) Cc: mail@daniel-mendler.de, emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun May 16 20:50:40 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1liLqZ-0007te-Nu for ged-emacs-devel@m.gmane-mx.org; Sun, 16 May 2021 20:50:39 +0200 Original-Received: from localhost ([::1]:48956 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1liLqY-0001oS-Pj for ged-emacs-devel@m.gmane-mx.org; Sun, 16 May 2021 14:50:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56204) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1liLpK-00011t-SE for emacs-devel@gnu.org; Sun, 16 May 2021 14:49:22 -0400 Original-Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]:38669) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1liLpE-0003Nh-FS for emacs-devel@gnu.org; Sun, 16 May 2021 14:49:22 -0400 Original-Received: by mail-ej1-x62a.google.com with SMTP id b25so5947204eju.5 for ; Sun, 16 May 2021 11:49:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=22XbMw/mCJ0vCwDYvtBWHCgok27QfC82mr7UAQUp/Os=; b=hfiDGCcmRqFr3qUWeOdpFKPRmbTn4p/Ou65L5rM+qPwy6dFlnnXGZR2RnzYXQbDY5D jkSevyHGXQQTby8/cDVyZECxd7mGuScCZPkKg+vq73qQrt+R32TRvyudCwyuI3vtpmaZ Zqz/hNMQ+IXVW4bRkgdwiw6etEh7SywGYRdQbdDXl20CVAFWJYs+qHyXhjdxnoVQv+oU wRZuv3pIGONsebaW/21jwge69Q/y34+D0zvxAQnzSt7LSu4Kc2ToYWAMX2dqRCkaPqN9 sipf9cKlYrUwFQwxpSIWy55VoVY8z8xwj1wQCNb0w7iYSJWBnNpjoxExHgNgaJm1a+EM dr9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=22XbMw/mCJ0vCwDYvtBWHCgok27QfC82mr7UAQUp/Os=; b=RhEKwgiiyeFc5qeaA2Yg2qNk3lNbz17fZeLoG/ouxYdTiXXDq4s5P7+jNkznPaK4sj GCvj+R7mGyjYj0ITcqRrMCBUSNFqm0DMP0hb6aCs+7sczH1P9jedw8YJ+090fi4LS6Uh fOLK2BP3++ixww38owOdu+qcvWvn1lik72gdrtrymBmXZbTsZ/GTjhEGXbe0WkOkaJfN sSjOSjQ6hV9Nzz7mbs5Z2yWyEP1Yipvi4yvHlCMnAf4ihbOJPnxSbm7Pj/7t2axqR9r3 xU1RFDFMeMWP3FshP+VRDTSbg+EwSHGkmnimZ2f6FdLSfTWv7/K1W/qGHTKYuqTiI4X0 wvlA== X-Gm-Message-State: AOAM530NmOwbCalQuOqnxcB+/nEzH24eV0lyNvhg/jyDAVhkMLusN3Hd UtzOB7koz38JEtRVHCc4xgw= X-Google-Smtp-Source: ABdhPJw/08j1Wa+2QI3E4jjKqVwXiQrgDhliqlcqcyUR943WyHEiPqHafBrVyyrtjEf7EjKh3eF7ow== X-Received: by 2002:a17:907:7747:: with SMTP id kx7mr41651191ejc.400.1621190954938; Sun, 16 May 2021 11:49:14 -0700 (PDT) Original-Received: from ars3 ([2a02:908:2211:8540::66]) by smtp.gmail.com with ESMTPSA id c22sm9381069edy.59.2021.05.16.11.49.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 May 2021 11:49:14 -0700 (PDT) In-Reply-To: <87v97i4jy7.fsf@mail.linkov.net> (Juri Linkov's message of "Sun, 16 May 2021 21:12:56 +0300") Received-SPF: pass client-ip=2a00:1450:4864:20::62a; envelope-from=arstoffel@gmail.com; helo=mail-ej1-x62a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269368 Archived-At: On Sun, 16 May 2021 at 21:12, Juri Linkov wrote: >> I'm pretty convinced that the approach of my first patch >> (`with-isearch-window' macro, etc.) is the right way to implement this >> and possibly other future features. On the other hand, I understand >> that it would be premature to just change isearch.el in this direction >> without a deeper reflection and further testing. > > Wrapping the bodies of all isearch commands in a macro `with-isearch-window' > is much more intrusive change than handling commands in hooks > after adding just one such line for every command: > > (put 'isearch-repeat-forward 'isearch-from-minibuffer t) I agree that the hook approach is less intrusive, but I after implementing it I felt it was too hacky, and probably more brittle. In the meanwhile Daniel Mendler made several helpful suggestions for the package version of the feature, now I feel there's not much technical reason to make the feature built into isearch.el (I would love the extra visibility/availability, but that's not an argument for inclusion). In particular, this use case is different from an improved `isearch-edit-string' in several small ways, which would hinder a lot of code reuse. How do I formalize the ELPA submission? (There's a Github link a few messages back.)