From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: [ELPA?] Controlling Isearch from the minibuffer Date: Fri, 14 May 2021 21:20:09 +0300 Organization: LINKOV.NET Message-ID: <87im3l5g9y.fsf@mail.linkov.net> References: <87zgx5cz33.fsf@gmail.com> <87o8djohqf.fsf@mail.linkov.net> <87eeeenxqq.fsf@gmail.com> <87h7jath3m.fsf@mail.linkov.net> <87mtt0wj37.fsf@gmail.com> <87cztvx4dc.fsf@mail.linkov.net> <87bl9fr7xh.fsf@gmail.com> <87tun6n12v.fsf@mail.linkov.net> <87lf8i8kba.fsf_-_@gmail.com> <878s4hxly0.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28569"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org To: Augusto Stoffel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri May 14 20:33:13 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lhccb-0007L7-FW for ged-emacs-devel@m.gmane-mx.org; Fri, 14 May 2021 20:33:13 +0200 Original-Received: from localhost ([::1]:37692 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lhcca-00059p-Ec for ged-emacs-devel@m.gmane-mx.org; Fri, 14 May 2021 14:33:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49476) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhcXn-00088Y-Nq for emacs-devel@gnu.org; Fri, 14 May 2021 14:28:15 -0400 Original-Received: from relay2-d.mail.gandi.net ([217.70.183.194]:35703) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhcXk-0001bc-RI for emacs-devel@gnu.org; Fri, 14 May 2021 14:28:15 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id CAB984000A; Fri, 14 May 2021 18:28:09 +0000 (UTC) In-Reply-To: <878s4hxly0.fsf@gmail.com> (Augusto Stoffel's message of "Fri, 14 May 2021 19:30:15 +0200") Received-SPF: pass client-ip=217.70.183.194; envelope-from=juri@linkov.net; helo=relay2-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269293 Archived-At: >>>> Setting `isearch-message-function' is of no help, because there are some >>>> tests for `(null isearch-message-function)' as well as some explicit >>>> calls to `(isearch-message)' in isearch.el. As far as I can see, there >>>> is no alternative to modifying the function `isearch-message' itself. >>> >>> Tests for `(null isearch-message-function)' were added as a temporary >>> workaround until lazy count will be implemented in the minibuffer. >>> We need to remove these workarounds anyway. So using isearch-message-function >>> should be the right thing to do. >> >> Okay, that' a low hanging fruit then. > > I've attached a patch. I can't see any deleterious effect for the > minibuffer and comint, which are the two places that set > `isearch-message-function' in Emacs. Do you see the correct lazy-count values in the minibuffer and comint after removing `(null isearch-message-function)'? > - (funcall (or isearch-message-function #'isearch-message))) > + (isearch-message)) What do you think about adding `isearch-message' as the default value of isearch-message-function? E.g. #+begin_src diff -(defvar isearch-message-function nil +(defvar isearch-message-function #'isearch-message #+end_src