From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: [ELPA?] Controlling Isearch from the minibuffer Date: Sun, 16 May 2021 21:19:16 +0300 Organization: LINKOV.NET Message-ID: <87eee65yor.fsf@mail.linkov.net> References: <87zgx5cz33.fsf@gmail.com> <87o8djohqf.fsf@mail.linkov.net> <87eeeenxqq.fsf@gmail.com> <87h7jath3m.fsf@mail.linkov.net> <87mtt0wj37.fsf@gmail.com> <87cztvx4dc.fsf@mail.linkov.net> <87bl9fr7xh.fsf@gmail.com> <87tun6n12v.fsf@mail.linkov.net> <87lf8i8kba.fsf_-_@gmail.com> <878s4hxly0.fsf@gmail.com> <87im3l5g9y.fsf@mail.linkov.net> <877djzymcf.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8842"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org To: Augusto Stoffel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun May 16 20:28:43 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1liLVK-0002DE-Fn for ged-emacs-devel@m.gmane-mx.org; Sun, 16 May 2021 20:28:42 +0200 Original-Received: from localhost ([::1]:41862 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1liLVJ-00047q-J5 for ged-emacs-devel@m.gmane-mx.org; Sun, 16 May 2021 14:28:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51540) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1liLUL-0002Vf-KU for emacs-devel@gnu.org; Sun, 16 May 2021 14:27:41 -0400 Original-Received: from relay3-d.mail.gandi.net ([217.70.183.195]:50433) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1liLUH-0005vp-Da for emacs-devel@gnu.org; Sun, 16 May 2021 14:27:41 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 6CAB960005; Sun, 16 May 2021 18:27:34 +0000 (UTC) In-Reply-To: <877djzymcf.fsf@gmail.com> (Augusto Stoffel's message of "Sun, 16 May 2021 13:00:48 +0200") Received-SPF: pass client-ip=217.70.183.195; envelope-from=juri@linkov.net; helo=relay3-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269365 Archived-At: >> Do you see the correct lazy-count values in the minibuffer and comint >> after removing `(null isearch-message-function)'? >> >>> - (funcall (or isearch-message-function #'isearch-message))) >>> + (isearch-message)) > > I would see the number of matches in the current line, which is only > logical. But the relevant information here would be number of > candidates in the minibuffer/comint history that match the string, as > opposed to the total number of matches among those candidates. So I > believe these modes should implement their own lazy count. I just > disabled the count in the new patch below. Thanks, binding isearch-lazy-count buffer-locally to nil is the right way to disable lazy-count until it's implemented in these modes. > Now, I took a closer look at the history of changes around lazy > highlight and the interactions with other features seems very tricky. > I'm not super confident about the patch I'm attaching, but if you are > willing to review it and test a bit, I hope it helps. Everything looks right, but this needs more testing before pushing. > +(defun isearch-standard-message (&optional c-q-hack ellipsis) > + "Generate and print the standard Isearch message string." A more naming-standard complying name would be isearch-default-message, or even better isearch-message-default like isearch-search-fun-default (no need to send a new patch only with renamings).