* Re: master 7ff88efc02: Fix coding style of recent change
[not found] ` <20220523103126.3CD7EC051FF@vcs2.savannah.gnu.org>
@ 2022-05-23 10:55 ` Lars Ingebrigtsen
2022-05-23 11:53 ` Po Lu
0 siblings, 1 reply; 5+ messages in thread
From: Lars Ingebrigtsen @ 2022-05-23 10:55 UTC (permalink / raw)
To: emacs-devel; +Cc: Po Lu
Po Lu via Mailing list for Emacs changes <emacs-diffs@gnu.org> writes:
> Fix coding style of recent change
>
> * src/emacs.c (main): Fix coding style by putting the = operator
> on the right row.
[...]
> + Lisp_Object rversion, rbranch, rtime;
Our coding style is not to put declarations of variables a long way away
from where they're used. Please revert.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: master 7ff88efc02: Fix coding style of recent change
2022-05-23 10:55 ` master 7ff88efc02: Fix coding style of recent change Lars Ingebrigtsen
@ 2022-05-23 11:53 ` Po Lu
2022-05-23 12:01 ` Lars Ingebrigtsen
0 siblings, 1 reply; 5+ messages in thread
From: Po Lu @ 2022-05-23 11:53 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: emacs-devel
Lars Ingebrigtsen <larsi@gnus.org> writes:
>> + Lisp_Object rversion, rbranch, rtime;
> Our coding style is not to put declarations of variables a long way away
> from where they're used. Please revert.
It is to put the "=" on column 1. It seemed cleaner to put it next to
`version' and `copyright' at the same time.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: master 7ff88efc02: Fix coding style of recent change
2022-05-23 11:53 ` Po Lu
@ 2022-05-23 12:01 ` Lars Ingebrigtsen
2022-05-23 12:06 ` Po Lu
0 siblings, 1 reply; 5+ messages in thread
From: Lars Ingebrigtsen @ 2022-05-23 12:01 UTC (permalink / raw)
To: Po Lu; +Cc: emacs-devel
Po Lu <luangruo@yahoo.com> writes:
> It is to put the "=" on column 1.
That bit was fine.
> It seemed cleaner to put it next to `version' and `copyright' at the
> same time.
It's a block that is longer than a screenful, so having those
definitions far away (and not used anywhere else in the block) doesn't
seem optimal to me.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: master 7ff88efc02: Fix coding style of recent change
2022-05-23 12:01 ` Lars Ingebrigtsen
@ 2022-05-23 12:06 ` Po Lu
2022-05-23 12:09 ` Lars Ingebrigtsen
0 siblings, 1 reply; 5+ messages in thread
From: Po Lu @ 2022-05-23 12:06 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: emacs-devel
Lars Ingebrigtsen <larsi@gnus.org> writes:
> It's a block that is longer than a screenful, so having those
> definitions far away (and not used anywhere else in the block) doesn't
> seem optimal to me.
Sure, if you insist. But while we're on the subject, why all the usage
of intern_c_string, instead of adding a couple of DEFSYMs in
syms_of_emacs?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: master 7ff88efc02: Fix coding style of recent change
2022-05-23 12:06 ` Po Lu
@ 2022-05-23 12:09 ` Lars Ingebrigtsen
0 siblings, 0 replies; 5+ messages in thread
From: Lars Ingebrigtsen @ 2022-05-23 12:09 UTC (permalink / raw)
To: Po Lu; +Cc: emacs-devel
Po Lu <luangruo@yahoo.com> writes:
> Sure, if you insist. But while we're on the subject, why all the usage
> of intern_c_string, instead of adding a couple of DEFSYMs in
> syms_of_emacs?
Yeah -- I was just following the coding style in the function, but using
DEFSYM is probably what we prefer these days? We've got about a 100
intern_c_string on constants, and should probably fix them. Or at least
not add to them.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-05-23 12:09 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <165330188594.32608.12929547700249403729@vcs2.savannah.gnu.org>
[not found] ` <20220523103126.3CD7EC051FF@vcs2.savannah.gnu.org>
2022-05-23 10:55 ` master 7ff88efc02: Fix coding style of recent change Lars Ingebrigtsen
2022-05-23 11:53 ` Po Lu
2022-05-23 12:01 ` Lars Ingebrigtsen
2022-05-23 12:06 ` Po Lu
2022-05-23 12:09 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).