From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master 7ff88efc02: Fix coding style of recent change Date: Mon, 23 May 2022 12:55:33 +0200 Message-ID: <87ee0ko6vu.fsf@gnus.org> References: <165330188594.32608.12929547700249403729@vcs2.savannah.gnu.org> <20220523103126.3CD7EC051FF@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32831"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Po Lu To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon May 23 12:59:05 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nt5mD-0008L7-8W for ged-emacs-devel@m.gmane-mx.org; Mon, 23 May 2022 12:59:05 +0200 Original-Received: from localhost ([::1]:47900 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nt5mB-00014w-29 for ged-emacs-devel@m.gmane-mx.org; Mon, 23 May 2022 06:59:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53772) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nt5iy-0006WY-1N for emacs-devel@gnu.org; Mon, 23 May 2022 06:55:44 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:40360) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nt5iw-0003zG-Dm for emacs-devel@gnu.org; Mon, 23 May 2022 06:55:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=wB5ZCSMR+q8Zo8+hbILTNIhdkdoRf0Vipp/tOJ8POFc=; b=Y7fHxRB0bqCoYzlEXH4s+Lvjzy xDsshJK5BsdhezMWGLxPlAD6SZu09EGFH7nXeTmlJbAFFrdw6OMZerPU6a8eUlokaPuH59QRf6js/ NSsY/gIYZbT92L+GK2LdS/ImmyhrcVz99gZW36UWDDvb6V7zAEkdJReO4kPI/OeNR/Pk=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nt5in-00016e-LY; Mon, 23 May 2022 12:55:35 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAALVBMVEUQDA1STUtJNTYk HB4tKC1nVlwmHSNKP0cbGiSUZFgyN05ldJHAu8Kqj4j///8kFz2zAAAAAWJLR0QOb70wTwAAAAd0 SU1FB+YFFwoVGVeueWsAAAGVSURBVDjLY2CgF2BUFBZyVRMXdlF3Ew1HlmApFRYUFXRWU1IUFBI0 QJYQFAkRdBR1FAkUFRRE0eHi7GxikWKS4AIEdPMABDTglnADkhwQTqoDspQ4hHICYs0ApgSERBoQ GzMwAP3Aoa5grgATTgYJMpgxMKQAKXUHM2WEBAi0QTgtBmxwo8DBtoA5GmQtszGay2ROl545ygCx Cjl8Ge6cOXPE1QDoowRUDSy7z5xxBnu1DFWCK3Tv6RZhkOolaBKrvJaYCIkwgP2CDLoaY84ylZlO w5Bg4LpzmtnB8xKyhFEJyHkssacZ2CJRJJjdhYGOYUs9bWDGepKBoQMoxAaRAQdB1+ozExQYTzIw CyUxMKTDg76Do3vXzJtqbFcZmCMjIUIeYNKrtWvV1YUzZ15kaGBxQ3EUBwfb6RUMSWKweITZD3QX 09UO7BHPLMSAAxgzDAUA9yqbAZqDG6A0k0BsMQNDCYSPGgqOKgYgbzZwdHTAJDrAAEw1cKSlZWS0 MZilgHKqi0dDRwuQ7IADBg4ojctJGBIABNhiYl5W9cwAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjIt MDUtMjNUMTA6MjE6MjUrMDA6MDDbDh2uAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIyLTA1LTIzVDEw OjIxOjI1KzAwOjAwqlOlEgAAAABJRU5ErkJggg== X-Now-Playing: The Durutti Column's _Love in the Time of Recession_: "My Poppy" In-Reply-To: <20220523103126.3CD7EC051FF@vcs2.savannah.gnu.org> (Po Lu via Mailing list for Emacs changes's message of "Mon, 23 May 2022 06:31:26 -0400 (EDT)") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:290142 Archived-At: Po Lu via Mailing list for Emacs changes writes: > Fix coding style of recent change > > * src/emacs.c (main): Fix coding style by putting the = operator > on the right row. [...] > + Lisp_Object rversion, rbranch, rtime; Our coding style is not to put declarations of variables a long way away from where they're used. Please revert. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no