From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: master 7ff88efc02: Fix coding style of recent change Date: Mon, 23 May 2022 19:53:59 +0800 Message-ID: <87v8two46g.fsf@yahoo.com> References: <165330188594.32608.12929547700249403729@vcs2.savannah.gnu.org> <20220523103126.3CD7EC051FF@vcs2.savannah.gnu.org> <87ee0ko6vu.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4222"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon May 23 13:57:08 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nt6gO-0000ui-GE for ged-emacs-devel@m.gmane-mx.org; Mon, 23 May 2022 13:57:08 +0200 Original-Received: from localhost ([::1]:56494 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nt6gN-0007Mn-C2 for ged-emacs-devel@m.gmane-mx.org; Mon, 23 May 2022 07:57:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36396) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nt6da-00051p-FR for emacs-devel@gnu.org; Mon, 23 May 2022 07:54:20 -0400 Original-Received: from sonic312-23.consmr.mail.ne1.yahoo.com ([66.163.191.204]:38836) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nt6dY-0006EB-JS for emacs-devel@gnu.org; Mon, 23 May 2022 07:54:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1653306847; bh=sbIXTUBtIP26ANZe0E4EBhTlnmhqV/B9d9ik2Kz8iM4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=Pcg2SbaHW9vbraRdRFLrXc5izmBBpvwgOaSxr+ksifdros3dWr57wYZc/ZC1/TqqJIWHnQJw66+NZmY/M00pOz3bJ/o9Rgfdp5hN5R0+IQnkrjn49LZK13KXAuVzs3GW1T31amx/oj40MV1OExSLfID4ZH9WF38B6aOwoj8sAHmpi6l/UGB0qBSnw6/zaLIz1z0gNrVMt4BI0jVEOIC0kuigxNlhEpNHb34WEW//Qsn004VYmoM002w3+AVSS+ISDt8sq9jU80gkXgqILYmt1/jukp9qSFZzq7enBZdDhsrZtcqRY+rTp0TCgIvf54G3NuOzpUOlWsm7hAytRqMmPg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1653306847; bh=HU38r28HNz2Gi++mLfcQ2GPz9k6Tva6exglO5K4OV/i=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=DIQbZOLlfxohSjuqhW+bcEqoB5I+yBouFG/Mwz++Fk6kkiCc1kY3eBKrnv/dN+MDI9zx71W1hgKTWfRtu229aEXU2gGoyl9sWv/I/tw3AxHS8iZYtNlo+u2nT0eipDEFJ47EoEAaGRgo/O0Vs2U0V/5FDeDNnkhyQWRrg6372/49CeD1+2na1VHfnwhYiFXKsOa7Sbebl5T0y34Y+BX9imgWPKWX0bJLUFdm6Ld0Ehk4PeEzmLqsVb69b9kloBI0Tws/gFqnwzvXRB8aK5T/Gj7OhLollwx+BZw9Kf11lCdBfzoV+Ko2w0ttDqBwGLOMipDIlvjdHb8uNzHJPV7tQQ== X-YMail-OSG: cUO1P.MVM1l3xuDmL0IqZJPnkNqSxyeT.j.V35MAOggIJlsvh44ujhQ58d.p4e3 VY.w_97zhjaFxhjs9nO.Zyy9L9OK67HWrLZUMoaMi0XUgUx.5OmAju_VwesMAj7AmGcMekfPoOZq jKcOL5P9F306ACxAu.HhQBDJ49GUo6Nof2zqtvG8b1SfV54pe4a0b7plj3Q2CS7TzPlDmjcBUblJ fdzLVZdj1l72_huTW4Z2cHiNbg8EQuwa5otlFcDRN.mfXReKmBPkEXec2wtYJKTFQnUT6zLn2F0p bd17Fil87jfNaZ9F04wbm_L7h6s7LptRy2gGiXHVVpMUUaTtnEutEl3Efn3BErqIQ4o6MjNPjRpu OkCBGiNpso7M0MHd5LwjjBWGpVYKzq0gTl6_kKGyTCgP6v10pmpmt1QrrN8fBvqTGdnYoGyLEWl1 71_phcC6BJLv4.Fga07fWDa1K.obiE1fJ1W8CZrB1qEdJ4Yn82Fx5VeQxZUqsNXAFbtmMeQ3fJos RqsOr_FLkmnNQHN6znkltmI4rSUhAZ_VfOJf3GUrdmiY5cyJj8Rf6vafVjm8blq.Y0XOHGCm.5az 68DczaAoJJMW6nQrS_cTA6QFO0bZ9nDItRWB32.HT61cOPHDHTWKsdjE6VDn17KkAV.lLnUAFjnH ANucH2WuQYfCfxPTdChY0PBJ_vVUeYFzgs.j27i89SGQWwV1qjKMUiQqaimMy3HEyJbGLkGOPGH5 ay3C5auIbVw.s1JMor5tnyeKSB5cTnsVgAmyMQ_hdKSyjyulLrF9gzhALEHEEYTNEC26xpWBfAgS nkdfbdwAju6IEuA9wOtrFZTrrjNST0pTZtIXJwcTWa X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.ne1.yahoo.com with HTTP; Mon, 23 May 2022 11:54:07 +0000 Original-Received: by hermes--canary-production-sg3-7959d4d9bd-v94mk (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID c2a1dccabcf7be67a2795924868b4264; Mon, 23 May 2022 11:54:04 +0000 (UTC) In-Reply-To: <87ee0ko6vu.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 23 May 2022 12:55:33 +0200") X-Mailer: WebService/1.1.20225 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.191.204; envelope-from=luangruo@yahoo.com; helo=sonic312-23.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:290147 Archived-At: Lars Ingebrigtsen writes: >> + Lisp_Object rversion, rbranch, rtime; > Our coding style is not to put declarations of variables a long way away > from where they're used. Please revert. It is to put the "=" on column 1. It seemed cleaner to put it next to `version' and `copyright' at the same time.