Re: master 7ff88efc02: Fix coding style of recent change

Re: master 7ff88efc02: Fix coding style of recent change

[Lars Ingebrigtsen]

Po Lu via Mailing list for Emacs changes <emacs-diffs@gnu.org> writes:

>     Fix coding style of recent change
>
>     * src/emacs.c (main): Fix coding style by putting the = operator
>     on the right row.

[...]

> +      Lisp_Object rversion, rbranch, rtime;

Our coding style is not to put declarations of variables a long way away
from where they're used.  Please revert.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master 7ff88efc02: Fix coding style of recent change

[Po Lu]

Lars Ingebrigtsen <larsi@gnus.org> writes:

>> +      Lisp_Object rversion, rbranch, rtime;

> Our coding style is not to put declarations of variables a long way away
> from where they're used.  Please revert.

It is to put the "=" on column 1.  It seemed cleaner to put it next to
`version' and `copyright' at the same time.

Re: master 7ff88efc02: Fix coding style of recent change

[Lars Ingebrigtsen]

Po Lu <luangruo@yahoo.com> writes:

> It is to put the "=" on column 1.

That bit was fine.

> It seemed cleaner to put it next to `version' and `copyright' at the
> same time.

It's a block that is longer than a screenful, so having those
definitions far away (and not used anywhere else in the block) doesn't
seem optimal to me.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master 7ff88efc02: Fix coding style of recent change

[Po Lu]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> It's a block that is longer than a screenful, so having those
> definitions far away (and not used anywhere else in the block) doesn't
> seem optimal to me.

Sure, if you insist.  But while we're on the subject, why all the usage
of intern_c_string, instead of adding a couple of DEFSYMs in
syms_of_emacs?

Re: master 7ff88efc02: Fix coding style of recent change

[Lars Ingebrigtsen]

Po Lu <luangruo@yahoo.com> writes:

> Sure, if you insist.  But while we're on the subject, why all the usage
> of intern_c_string, instead of adding a couple of DEFSYMs in
> syms_of_emacs?

Yeah -- I was just following the coding style in the function, but using
DEFSYM is probably what we prefer these days?  We've got about a 100
intern_c_string on constants, and should probably fix them.  Or at least
not add to them.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no