From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: master 7ff88efc02: Fix coding style of recent change Date: Mon, 23 May 2022 20:06:14 +0800 Message-ID: <87pmk4o3m1.fsf@yahoo.com> References: <165330188594.32608.12929547700249403729@vcs2.savannah.gnu.org> <20220523103126.3CD7EC051FF@vcs2.savannah.gnu.org> <87ee0ko6vu.fsf@gnus.org> <87v8two46g.fsf@yahoo.com> <87a6b8mp9x.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18985"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon May 23 14:07:44 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nt6qe-0004im-1G for ged-emacs-devel@m.gmane-mx.org; Mon, 23 May 2022 14:07:44 +0200 Original-Received: from localhost ([::1]:37920 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nt6qc-0006OB-O5 for ged-emacs-devel@m.gmane-mx.org; Mon, 23 May 2022 08:07:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39498) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nt6pP-0005Zc-Rj for emacs-devel@gnu.org; Mon, 23 May 2022 08:06:30 -0400 Original-Received: from sonic312-23.consmr.mail.ne1.yahoo.com ([66.163.191.204]:33777) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nt6pN-0000RJ-V9 for emacs-devel@gnu.org; Mon, 23 May 2022 08:06:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1653307583; bh=PYJMpADfhHAI+yUQ4fLZCQSxaExjWSSE8hLzVmnG0+Q=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=iMej5XEY1TYhVyfTZjZo4MNGYcDuWsOFc3pbJbs04IcsS9tVHl6TOz7Pi1ZqHTkCUj7zifwO4J+AlwbgR+4nqXMn1RLwx88/NgoSOgF8V+2ICjiH0kCflQEFs9XRLMOzmHJH8E9jgc/veWEK2Wcp95qsygTJrHAopk0k9sih1ovqTz3sj8pezMz6U3gxoPaTC1GEqF1qe5Wwd5ankDjtU8UyveV88jU2eakpFB/C9VVvCZwUpWhjI2pOj0OaNOjQqWnru/MuonLNiAiMI5+YAJk+Qf6ASyfhGIlV+LmzsTck0wLBKHcgZHiXZPCIphv7I2exJBtpvcTivsbKfRCe5g== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1653307583; bh=q6V8PRjML4MSsuiTEZOS1xCSQHtuluOXmWWz1xps81r=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=TAY4oRpd71KEnHbjmIHdgmLtQxkIBWfKN4kWY9dNUlqHIfsTdZ72qT5ePh8oRWVJVH7085xP9otq/xiY6M7Oe3yFgjv7nP+tFcf05bJfETxEdUWrXrctWyejQWyAkWg9jGGgvYnz/XfGdWWUMMDJfCHexO1RRyhKfBVa8FNDZQZlByEFBtpWTdBYQgPpHFhhreU2Xta50uFDjkNIToCiAxxmSSv7EUcUBPADjGYfMhWE64lvF23MnOrOx7xyee0ef6jAK7C7FoDeSZEPHSMf/m4ZKk/Vh4j241k9gRj4AgaAGLKFD2ojy7XO2xbThQ7RHrkzUstlTof9S2RA4nvlbQ== X-YMail-OSG: fQQc6j4VM1lv6oOavrQpZeyrs7zpav17rnblavJwHoQ_8Wf71Ed6mqNxm.5flRI pvONpmPGWrrQYnSXuJV37IOL6XU5i2AYBsno_pBO_I_UGnXUh3MUaWXr28GMoEUZIPi8.plif7wS jQTUQm11DLP2rL6e1Mnt8o7VnZW7DaHvkbJqVA9qdz3xU2Ehtvz6P01uKhxv47aPpHSXua8kGokj P.PSRA56CS0m4rtta20r0JR0CkyfTA1i.S7JORtEP1W7cmfTb9BV683ISoW9CiEy_AINMR4XQRoy dobC6tMuiLmZa5rdKnsyH52JGCnLtcNl3l.5TPxP_JsoZ_n0qi78xmHbJRI9VEIfdvTuRozVkWp6 h4.yNKVKI4TAEGYSiPmITYJADGhyXOGvRdIGjfL3WpuGKzQTVnWAx5MllnIQ.v1X1x6LG_8qTrKF rOa6AsoMPjFO9NZo.cDd7DO5yRf3pHVRJq5y7_yeLVo.YyYezSfDrWaqZUrDQzECw9b32qfKNbJB RTpDKpDZ57UXF6t_nL4uk_tfaT15HNoYE3IrARhi7hg9bViIXe9x__lObclC0sX3mxB6yhiXRFfe Mgfp_MS2mJ_fV8c6sDTom8YWmMzM0xYXQARBqxjsqvKHLoI_l5OitG7Hwre3UZzt5WyfEg_Gt.7j mUqKrI91IrMPQhR5LLuKYtojKsy3gxtWbGW44JciM.c11BVPU7a4gWyNKeEjaEzLA2OM.iZ6zEgh E2nWzPSSa57iCK3QzcJs1EBlngzFoTbYA3F7cLop5qzbzfmEwtzAbti6QuMbr82LvxgHlVUulwVk vPam68CmzbzE0wxTkTtj5T94qoug.eK5QMPyKc3jxx X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.ne1.yahoo.com with HTTP; Mon, 23 May 2022 12:06:23 +0000 Original-Received: by hermes--canary-production-sg3-7959d4d9bd-bjkcg (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID e9a9914b76edcfce2db43f0cb79b7c07; Mon, 23 May 2022 12:06:18 +0000 (UTC) In-Reply-To: <87a6b8mp9x.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 23 May 2022 14:01:14 +0200") X-Mailer: WebService/1.1.20225 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.191.204; envelope-from=luangruo@yahoo.com; helo=sonic312-23.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:290149 Archived-At: Lars Ingebrigtsen writes: > It's a block that is longer than a screenful, so having those > definitions far away (and not used anywhere else in the block) doesn't > seem optimal to me. Sure, if you insist. But while we're on the subject, why all the usage of intern_c_string, instead of adding a couple of DEFSYMs in syms_of_emacs?