From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master 7ff88efc02: Fix coding style of recent change Date: Mon, 23 May 2022 14:09:51 +0200 Message-ID: <874k1gmovk.fsf@gnus.org> References: <165330188594.32608.12929547700249403729@vcs2.savannah.gnu.org> <20220523103126.3CD7EC051FF@vcs2.savannah.gnu.org> <87ee0ko6vu.fsf@gnus.org> <87v8two46g.fsf@yahoo.com> <87a6b8mp9x.fsf@gnus.org> <87pmk4o3m1.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34109"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon May 23 14:10:59 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nt6tm-0008gv-Uz for ged-emacs-devel@m.gmane-mx.org; Mon, 23 May 2022 14:10:58 +0200 Original-Received: from localhost ([::1]:39950 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nt6tl-0007s7-H3 for ged-emacs-devel@m.gmane-mx.org; Mon, 23 May 2022 08:10:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40336) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nt6sq-0007Bj-Vz for emacs-devel@gnu.org; Mon, 23 May 2022 08:10:01 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:41130) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nt6sp-0000so-8S for emacs-devel@gnu.org; Mon, 23 May 2022 08:10:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=WmAwOpXBR+Uzo4e5G4XkmS9QZprTlZ8BXoc51JGH0WA=; b=H7SjysdyDq8fDA36XYKrUznvMn XC1RW2YyT36afSI1g6QcyEWn7bAVoq2aib6KsKm+pmGNVlm6XDtFlcwVlmi/s0J8sFckqu0JmfJgk wuvgxmSq1gzA9I1a15ApE0SQLOMonUHcKmGef3YPWjH8w92jejeMedLHYuJipr/jX5n0=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nt6si-0001oR-Ty; Mon, 23 May 2022 14:09:55 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEXj2sfs3y4nacG5 VDkuHyP///9JyvzbAAAAAWJLR0QF+G/pxwAAAAd0SU1FB+YFFwwHOomwBHgAAAGZSURBVDjLbdMB dsMgCABQUnOAOnuAhu4AOjxAFrj/mQaiieurb3vd4w8UtACwxE8L4Lakz4AKhfQ3pfFR9AOmUomF UzkzLqii63cA4qssrQJJW61QSYCwtRyiDi2lwRMgJqJSHWSUMgj6/6nHhd+ABrRdJqhCXoxpzrAY dSGVxQHEKlkaGxTK0EH7FTaxJC5pgDZih+IUe03oYI3LXmt5+Pbg0Ib1kF1Wrq0P6hAdRGHn1Vp3 ePnMW4P70eBugFsHLUNjWP+gJEq1z+pupSbQCeiY+5VfYP1FapPSlAF2U7pKh3ge1+7K1wx2zYm4 Q7t0wKd3bufNUEdCy1juy2hEqExgb6ukamWY9F6t7gCI8cu32M6n67B0qFtvYwDE42VwbEmDPisH OJC0FSw22fsEQfCb6g+2uwj5hBzkQP3BbHGa4GZRdKAJYIAnqJx74IHgoIfLdMExwE6dwwTo0If/ DhyCx09YK+INv9l2DgRXqZVUUF+nhsO8efXSHLLVClepvif712uaFZ/gjQ8IE+T22vUhzyD2twX+ AB0DhxBFwPgXAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIyLTA1LTIzVDEyOjA3OjU3KzAwOjAwc3p5 UwAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMi0wNS0yM1QxMjowNzo1NyswMDowMAInwe8AAAAASUVO RK5CYII= X-Now-Playing: Ryuichi Sakamoto & The Kakutougi Session's _Summer Nerves_: "Summer Nerves" In-Reply-To: <87pmk4o3m1.fsf@yahoo.com> (Po Lu's message of "Mon, 23 May 2022 20:06:14 +0800") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:290150 Archived-At: Po Lu writes: > Sure, if you insist. But while we're on the subject, why all the usage > of intern_c_string, instead of adding a couple of DEFSYMs in > syms_of_emacs? Yeah -- I was just following the coding style in the function, but using DEFSYM is probably what we prefer these days? We've got about a 100 intern_c_string on constants, and should probably fix them. Or at least not add to them. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no