From: Lars Ingebrigtsen <larsi@gnus.org>
To: Po Lu <luangruo@yahoo.com>
Cc: emacs-devel@gnu.org
Subject: Re: master 7ff88efc02: Fix coding style of recent change
Date: Mon, 23 May 2022 14:09:51 +0200 [thread overview]
Message-ID: <874k1gmovk.fsf@gnus.org> (raw)
In-Reply-To: <87pmk4o3m1.fsf@yahoo.com> (Po Lu's message of "Mon, 23 May 2022 20:06:14 +0800")
Po Lu <luangruo@yahoo.com> writes:
> Sure, if you insist. But while we're on the subject, why all the usage
> of intern_c_string, instead of adding a couple of DEFSYMs in
> syms_of_emacs?
Yeah -- I was just following the coding style in the function, but using
DEFSYM is probably what we prefer these days? We've got about a 100
intern_c_string on constants, and should probably fix them. Or at least
not add to them.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
prev parent reply other threads:[~2022-05-23 12:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <165330188594.32608.12929547700249403729@vcs2.savannah.gnu.org>
[not found] ` <20220523103126.3CD7EC051FF@vcs2.savannah.gnu.org>
2022-05-23 10:55 ` master 7ff88efc02: Fix coding style of recent change Lars Ingebrigtsen
2022-05-23 11:53 ` Po Lu
2022-05-23 12:01 ` Lars Ingebrigtsen
2022-05-23 12:06 ` Po Lu
2022-05-23 12:09 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874k1gmovk.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).