unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Patch to disable links line in *info* buffer
@ 2002-06-06 18:32 Romain FRANCOISE
  2002-06-06 23:24 ` Kim F. Storm
  2002-06-07 23:22 ` Richard Stallman
  0 siblings, 2 replies; 72+ messages in thread
From: Romain FRANCOISE @ 2002-06-06 18:32 UTC (permalink / raw)
  Cc: emacs-devel

Richard,

the change you made to info.el to make the links line show up at the top
of the *info* buffer didn't seem to be very popular, and I myself find
it quite useless, since I never ever had to copy this particular line
out of the buffer.

Following Miles Bader's suggestion, I propose the following patch, it
makes the behavior optional, and disabled by default. Does it look
reasonable to you?

Thank you.



Index: lisp/info.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/info.el,v
retrieving revision 1.302
diff -c -r1.302 info.el
*** lisp/info.el	3 Jun 2002 22:57:40 -0000	1.302
--- lisp/info.el	6 Jun 2002 18:15:09 -0000
***************
*** 86,91 ****
--- 86,99 ----
    :type 'boolean
    :group 'info)
  
+ (defcustom Info-show-links-in-buffer nil
+   "*Non-nil means to put the beginning-of-node links at the top of the buffer.
+ This is convenient if you need to copy the links line out of the buffer using
+ M-w. Please note that if you choose not to use the header line, links will
+ be showed in the buffer regardless of the state of this option."
+   :type 'boolean
+   :group 'info)
+ 
  (defface info-header-xref
    '((t (:inherit info-xref)))
    "Face for Info cross-references in a node header."
***************
*** 1034,1043 ****
      (set (make-local-variable 'Info-header-line)
  	 (buffer-substring header-beg header-end))
      (setq header-line-format 'Info-header-line)
! ;;; It is useful to be able to copy the links line out of the buffer
! ;;; with M-w.
! ;;;    (narrow-to-region (1+ header-end) (point-max))
!     ))
  \f
  ;; Go to an info node specified with a filename-and-nodename string
  ;; of the sort that is found in pointers in nodes.
--- 1042,1049 ----
      (set (make-local-variable 'Info-header-line)
  	 (buffer-substring header-beg header-end))
      (setq header-line-format 'Info-header-line)
!     (when (not Info-show-links-in-buffer)
!       (narrow-to-region (1+ header-end) (point-max)))))
  \f
  ;; Go to an info node specified with a filename-and-nodename string
  ;; of the sort that is found in pointers in nodes.
***************
*** 1247,1256 ****
      (save-excursion
        (save-restriction
  	(goto-char (point-min))
! ;;; 	(when Info-header-line
! ;;; 	  ;; expose the header line in the buffer
! ;;; 	  (widen)
! ;;; 	  (forward-line -1))
  	(let ((bound (point)))
  	  (forward-line 1)
  	  (cond ((re-search-backward (concat name ":") bound t)
--- 1253,1263 ----
      (save-excursion
        (save-restriction
  	(goto-char (point-min))
! 	(when (and Info-header-line (not Info-show-links-in-buffer))
! 	  ;; expose the header line in the buffer if it's
! 	  ;; not there already
! 	  (widen)
! 	  (forward-line -1))
  	(let ((bound (point)))
  	  (forward-line 1)
  	  (cond ((re-search-backward (concat name ":") bound t)


-- 
Romain FRANCOISE <romain@orebokech.com> | This is a man's man's man's
it's a miracle -- http://orebokech.com/ | world.--James Brown

^ permalink raw reply	[flat|nested] 72+ messages in thread
* Re: Patch to disable links line in *info* buffer
@ 2002-06-07 13:35 David Ponce
  0 siblings, 0 replies; 72+ messages in thread
From: David Ponce @ 2002-06-07 13:35 UTC (permalink / raw)
  Cc: emacs-devel

Hi Kim,

I tried your patch and loved it!
It would be nice to have it installed ;-)

David
____________________________________________________________
Faites un voeu et puis Voila ! www.voila.fr 
Avec Voila Mail, consultez vos e-mails sur votre mobile Wap. 

^ permalink raw reply	[flat|nested] 72+ messages in thread
* Re: Patch to disable links line in *info* buffer
@ 2002-06-07 13:56 David Ponce
  0 siblings, 0 replies; 72+ messages in thread
From: David Ponce @ 2002-06-07 13:56 UTC (permalink / raw)
  Cc: emacs-devel

Hi Kim,

I tried your patch and loved it!
It would be nice to have it installed ;-)

David


__________________________________________________________________
Your favorite stores, helpful shopping tools and great gift ideas. Experience the convenience of buying online with Shop@Netscape! http://shopnow.netscape.com/

Get your own FREE, personal Netscape Mail account today at http://webmail.netscape.com/

^ permalink raw reply	[flat|nested] 72+ messages in thread

end of thread, other threads:[~2002-06-21 23:56 UTC | newest]

Thread overview: 72+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-06-06 18:32 Patch to disable links line in *info* buffer Romain FRANCOISE
2002-06-06 23:24 ` Kim F. Storm
2002-06-07 23:22 ` Richard Stallman
2002-06-08  0:52   ` Kim F. Storm
2002-06-08 21:39     ` Romain FRANCOISE
2002-06-08 22:08       ` Alex Schroeder
2002-06-08 22:30       ` Robert J. Chassell
2002-06-09  4:11         ` Miles Bader
2002-06-09 10:56           ` Robert J. Chassell
2002-06-09  5:16         ` Eli Zaretskii
2002-06-10 13:59         ` Stefan Monnier
2002-06-10 16:46           ` Robert J. Chassell
2002-06-10 17:28             ` Stefan Monnier
2002-06-10 20:50               ` Robert J. Chassell
2002-06-10 22:18                 ` Thien-Thi Nguyen
2002-06-10 22:24                   ` Stefan Monnier
2002-06-11 11:15                   ` Robert J. Chassell
2002-06-11 21:00                     ` Thien-Thi Nguyen
2002-06-11  5:26                 ` Eli Zaretskii
2002-06-10 20:58               ` Robert J. Chassell
2002-06-10 21:52                 ` Stefan Monnier
2002-06-11  9:36               ` Andreas Schwab
2002-06-10 19:57             ` Kim F. Storm
2002-06-11 19:25             ` Richard Stallman
2002-06-11 20:01               ` Jason Rumney
2002-06-11 23:45                 ` Kim F. Storm
2002-06-12 12:14                   ` Richard Stallman
2002-06-12 22:15                     ` Kim F. Storm
2002-06-13 21:46                       ` Richard Stallman
2002-06-13 23:22                         ` Kim F. Storm
2002-06-19 13:10                           ` Kim F. Storm
2002-06-19 15:02                             ` Stefan Monnier
2002-06-21 21:40                               ` Kim F. Storm
2002-06-21 23:56                                 ` Kim F. Storm
2002-06-21  9:40                             ` Richard Stallman
2002-06-13 15:34                   ` Robert J. Chassell
2002-06-13 17:17                     ` Andreas Schwab
     [not found]             ` <200206130905.g5D95ie06537@aztec.santafe.edu>
2002-06-13 11:36               ` Robert J. Chassell
2002-06-13 23:18                 ` Kim F. Storm
2002-06-14 15:47                 ` Richard Stallman
2002-06-17 19:28             ` Patch for emacs-lisp-intro.texi Christian Egli
2002-06-11 19:25           ` Patch to disable links line in *info* buffer Richard Stallman
2002-06-09 23:04       ` Kim F. Storm
2002-06-10 10:15       ` Richard Stallman
2002-06-10 10:25         ` Eli Zaretskii
2002-06-09 15:18     ` Richard Stallman
2002-06-09 15:58       ` Kai Großjohann
2002-06-09 23:38       ` Kim F. Storm
2002-06-10 23:43         ` Richard Stallman
2002-06-10  5:14       ` Karl Eichwalder
2002-06-10  5:24         ` Miles Bader
2002-06-10 23:43         ` Richard Stallman
2002-06-11  0:12           ` Miles Bader
2002-06-11  5:27             ` Eli Zaretskii
2002-06-11  7:05             ` Miles Bader
2002-06-11 13:20               ` Robert J. Chassell
2002-06-12  2:34                 ` Richard Stallman
2002-06-12 10:33                   ` Robert J. Chassell
2002-06-12 23:47                     ` Richard Stallman
2002-06-13 13:20                       ` Robert J. Chassell
2002-06-14 15:47                         ` Richard Stallman
2002-06-14 19:00                         ` Karl Eichwalder
2002-06-12  2:32               ` Richard Stallman
2002-06-12  2:53                 ` Miles Bader
2002-06-12 18:21                   ` Karl Eichwalder
2002-06-12 21:36               ` Alex Schroeder
2002-06-11  4:17           ` Karl Eichwalder
2002-06-11  5:29             ` Eli Zaretskii
2002-06-11 15:26               ` Karl Eichwalder
2002-06-09  5:13   ` Eli Zaretskii
  -- strict thread matches above, loose matches on Subject: below --
2002-06-07 13:35 David Ponce
2002-06-07 13:56 David Ponce

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).