From: Dmitry Gutov <dgutov@yandex.ru>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 20322@debbugs.gnu.org
Subject: bug#20322: 25.0.50; indent-tabs-mode should default to nil
Date: Tue, 21 Apr 2015 01:09:28 +0300 [thread overview]
Message-ID: <55357918.7030808@yandex.ru> (raw)
In-Reply-To: <jwvbniid2rh.fsf-monnier+emacsbugs@gnu.org>
On 04/20/2015 10:26 PM, Stefan Monnier wrote:
> Ah, so the units are lines? Indeed, then this can be strongly biased if
> people use smaller tab-width than 8.
>
> It seems it would make more sense to count files (or projects), where
> each file gets to be counted either as SPC or as TAB depending on
> whether it has more lines that use TAB than lines that use either spaces.
That sounds better, but still would discount the JavaScript files with
less than 4 levels of nesting (unless we only count each project once;
but I think the project size is important, too). And in our case, any
hunks which didn't include this level of nesting (see the caveat at the
bottom).
Here's updated counts (in number of files), produced by parsing the log
(one you can download here: http://dropcanvas.com/3mwn1):
C: tabs => 17422, spaces => 6509
C++: tabs => 7366, spaces => 17155
JS: tabs => 30100, spaces => 73370
Java: tabs => 66922, spaces => 38243
Elisp: tabs => 515, spaces => 1465
(The ratio for C became even more tab-favored, but others seem to have
moved towards spaces).
Script:
File.open("print.log", "r") do |file|
results = Hash[%w(c cpp js java el).map { |ext| [ext, {tabs: 0,
spaces: 0}]}]
file_re = /\.(#{results.keys.join("|")}): spaces ([0-9]+), tabs
([0-9]+)$/
file.each_line do |line|
if line =~ file_re
ext = $~[1]
spaces = $~[2].to_i
tabs = $~[3].to_i
ext_results = results[ext]
if spaces > tabs
ext_results[:spaces] += 1
elsif spaces < tabs
ext_results[:tabs] += 1
end
end
end
puts results
end
> This way, the bias only affects a file at a time, which should be
> insignificant if we assume that those files should use a consistent
> style (i.e. either 99% TABs or 99% SPC).
CAVEAT: The above was still only the result of the diffs analysis, and
didn't examine the files in their entirety (the original run took more
than 8 hours here, and downloading the actual files is bound to take an
order of magnitude more, just for January 1st).
But to get a feeling for the margin of error, here's the result of
running a modified script, which sorted all "spaces 0, tabs 0" files
into the "spaces" bucket:
C: tabs => 17422, spaces => 16683
C++: tabs => 7366, spaces => 44641
JS: tabs => 30100, spaces => 143709
Java: tabs => 66922, spaces => 98886
Elisp: tabs => 515, spaces => 2423
So yeah, it seems C programmers favored tabs either way that day. The
Java programmers, however, are undecided.
next prev parent reply other threads:[~2015-04-20 22:09 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-14 2:37 bug#20322: 25.0.50; indent-tabs-mode should default to nil Dmitry Gutov
2015-04-14 3:07 ` Stefan Monnier
2015-04-14 14:14 ` Dmitry Gutov
2015-04-14 15:25 ` Eli Zaretskii
2015-04-14 15:39 ` Dmitry Gutov
2015-04-14 15:59 ` Eli Zaretskii
2015-04-14 20:24 ` Dmitry Gutov
2015-04-14 21:43 ` Stefan Monnier
2015-04-14 22:17 ` Dmitry Gutov
2015-04-15 1:19 ` Stefan Monnier
2015-04-15 2:08 ` Dmitry Gutov
2015-04-15 4:19 ` Stefan Monnier
2015-04-20 14:56 ` Dmitry Gutov
2015-04-20 19:26 ` Stefan Monnier
2015-04-20 22:09 ` Dmitry Gutov [this message]
2015-04-21 1:25 ` Stefan Monnier
2015-04-21 19:25 ` Dmitry Gutov
2015-04-21 19:47 ` Eli Zaretskii
2015-04-22 15:02 ` Dmitry Gutov
2015-04-22 15:18 ` Eli Zaretskii
2015-04-22 15:23 ` Dmitry Gutov
2015-04-22 15:28 ` Eli Zaretskii
2015-04-22 15:49 ` Dmitry Gutov
2015-04-21 20:27 ` Stefan Monnier
2015-04-21 20:51 ` Dmitry Gutov
2015-04-22 13:56 ` Stefan Monnier
2015-04-22 14:59 ` Dmitry Gutov
2015-04-22 16:47 ` Stefan Monnier
2015-11-02 18:18 ` Dmitry Gutov
2015-11-02 20:37 ` John Wiegley
2015-11-02 21:03 ` Dmitry Gutov
2015-11-02 21:18 ` John Wiegley
2015-11-02 21:06 ` Eli Zaretskii
2015-11-02 21:29 ` John Wiegley
2015-11-02 23:31 ` Richard Stallman
2015-11-03 3:32 ` Eli Zaretskii
2015-11-02 23:31 ` Richard Stallman
2015-04-15 14:31 ` Wolfgang Jenkner
2015-04-15 16:10 ` Eli Zaretskii
2015-04-17 2:48 ` Dmitry Gutov
2015-04-17 4:58 ` Stefan Monnier
2015-04-17 13:14 ` Dmitry Gutov
2015-04-17 7:26 ` Eli Zaretskii
2015-04-17 8:11 ` Eli Zaretskii
2015-04-17 14:17 ` Dmitry Gutov
2015-04-17 14:36 ` Eli Zaretskii
2015-04-17 15:55 ` Dmitry Gutov
2015-04-17 16:23 ` Eli Zaretskii
2015-04-17 18:12 ` Stefan Monnier
2015-04-17 18:18 ` Dmitry Gutov
2015-04-20 15:03 ` Dmitry Gutov
2015-04-17 7:55 ` Andreas Schwab
2015-04-17 8:12 ` Eli Zaretskii
2015-04-17 10:55 ` Dmitry Gutov
2015-12-26 14:27 ` Dmitry Gutov
2015-12-27 2:52 ` Richard Stallman
2015-12-27 3:21 ` Dmitry Gutov
2015-12-27 15:50 ` Eli Zaretskii
2015-12-27 16:10 ` Dmitry Gutov
2015-12-27 16:28 ` Eli Zaretskii
2015-12-27 16:51 ` Dmitry Gutov
2015-12-30 4:47 ` John Wiegley
2015-12-30 11:48 ` Dmitry Gutov
2015-12-30 12:15 ` Dmitry Gutov
2015-12-30 19:18 ` John Wiegley
2015-12-31 0:24 ` Dmitry Gutov
2015-12-31 1:17 ` John Wiegley
2015-12-31 1:26 ` Dmitry Gutov
2015-12-31 2:48 ` John Wiegley
2015-12-31 6:30 ` Richard Stallman
2015-04-14 17:15 ` Stefan Monnier
2015-04-14 18:08 ` Nicolas Petton
2015-04-14 20:33 ` Dmitry Gutov
2015-04-14 19:09 ` Achim Gratz
2015-04-14 21:58 ` Dmitry Gutov
2015-04-15 2:33 ` Richard Stallman
2015-04-15 11:18 ` Dmitry Gutov
2015-04-15 16:17 ` Eli Zaretskii
2015-04-15 23:03 ` Dmitry Gutov
[not found] ` <<E1YiD8o-000318-H5@fencepost.gnu.org>
2015-04-15 15:29 ` Drew Adams
2015-04-14 14:17 ` Eli Zaretskii
2015-04-14 14:40 ` Dmitry Gutov
2015-04-14 15:29 ` Eli Zaretskii
2015-04-14 15:48 ` Dmitry Gutov
2015-04-14 16:02 ` Eli Zaretskii
2015-04-17 17:22 ` Philipp Stephani
2015-04-18 2:55 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55357918.7030808@yandex.ru \
--to=dgutov@yandex.ru \
--cc=20322@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).