From: ludo@gnu.org (Ludovic Courtès)
To: Andy Patterson <ajpatter@uwaterloo.ca>
Cc: 28853@debbugs.gnu.org
Subject: [bug#28853] [PATCH 2/8] gnu: qemu: Enable spice usb redirection support.
Date: Thu, 19 Oct 2017 11:52:02 +0200 [thread overview]
Message-ID: <87shefmpml.fsf@gnu.org> (raw)
In-Reply-To: <20171018221442.6e140c5b@uwaterloo.ca> (Andy Patterson's message of "Wed, 18 Oct 2017 22:14:42 -0400")
[-- Attachment #1: Type: text/plain, Size: 1081 bytes --]
Hello,
Andy Patterson <ajpatter@uwaterloo.ca> skribis:
> On Mon, 16 Oct 2017 21:15:39 +0800
> iyzsong@member.fsf.org (宋文武) wrote:
>
>> Andy Patterson <ajpatter@uwaterloo.ca> writes:
>>
>> > * gnu/packages/virtualization.scm
>> > (qemu)[arguments]<#:configure-flags>: New argument.
>> > [inputs]: Add usbredir.
>> > (qemu-minimal)[arguments]<#:configure-flags>: Restrict them even
>> > when they are set by qemu.
>> > [inputs]: Remove usbredir.
>>
>> Doesn't the 'configure' script auto-detect usb redirection support
>> when usbredir is available?
>
> To me, the advantage of specifying the enabled features is that the
> build will require the dependencies to be available for that feature
> even if they change. So, if more dependencies are required for the
> feature in future versions, the build will immediately inform us, rather
> than somewhat silently dropping support. Thoughts?
That makes sense to me.
I took the liberty to make the change below, to avoid a rebuild of
‘qemu-minimal’, and applied it.
Thanks,
Ludo’.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 830 bytes --]
diff --git a/gnu/packages/virtualization.scm b/gnu/packages/virtualization.scm
index 4a711ee7f..49dee07f5 100644
--- a/gnu/packages/virtualization.scm
+++ b/gnu/packages/virtualization.scm
@@ -192,10 +192,8 @@ server and embedded PowerPC, and S390 guests.")
(arguments
(substitute-keyword-arguments (package-arguments qemu)
((#:configure-flags _ '(list))
- `(list
- ,(string-append
- "--target-list=i386-softmmu,x86_64-softmmu,mips64el-softmmu"
- ",arm-softmmu,aarch64-softmmu")))))
+ ;; Restrict to the targets supported by Guix.
+ ''("--target-list=i386-softmmu,x86_64-softmmu,mips64el-softmmu,arm-softmmu,aarch64-softmmu"))))
;; Remove dependencies on optional libraries, notably GUI libraries.
(inputs (fold alist-delete (package-inputs qemu)
next prev parent reply other threads:[~2017-10-19 9:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-15 19:15 [bug#28853] Some virt-manager improvements Andy Patterson
2017-10-15 20:03 ` [bug#28853] [PATCH 1/8] gnu: virt-manager: Enable gtk schemas and glib modules support Andy Patterson
2017-10-16 13:25 ` 宋文武
2017-10-19 2:19 ` Andy Patterson
2017-10-26 5:18 ` Ludovic Courtès
2017-10-15 20:03 ` [bug#28853] [PATCH 2/8] gnu: qemu: Enable spice usb redirection support Andy Patterson
2017-10-16 13:15 ` 宋文武
2017-10-19 2:14 ` Andy Patterson
2017-10-19 9:52 ` Ludovic Courtès [this message]
2017-10-15 20:03 ` [bug#28853] [PATCH 3/8] gnu: spice-gtk: Enable GObject introspection support Andy Patterson
2017-10-19 9:56 ` Ludovic Courtès
2017-10-15 20:03 ` [bug#28853] [PATCH 4/8] gnu: virt-manager: Enable spice-gtk support Andy Patterson
2017-10-19 9:57 ` Ludovic Courtès
2017-10-15 20:03 ` [bug#28853] [PATCH 5/8] gnu: qemu: Add OpenGL support Andy Patterson
2017-10-19 9:59 ` Ludovic Courtès
2017-10-15 20:03 ` [bug#28853] [PATCH 6/8] gnu: virt-manager: Enable statistics graphing support Andy Patterson
2017-10-19 9:59 ` Ludovic Courtès
2017-10-15 20:03 ` [bug#28853] [PATCH 7/8] gnu: virt-manager: Fix default URI check Andy Patterson
2017-10-19 10:01 ` Ludovic Courtès
2017-10-15 20:03 ` [bug#28853] [PATCH 8/8] gnu: virt-manager: Enable persistent configuration support Andy Patterson
2017-10-26 5:22 ` bug#28853: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87shefmpml.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=28853@debbugs.gnu.org \
--cc=ajpatter@uwaterloo.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.