From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40656) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e57Vh-0000Eh-Ki for guix-patches@gnu.org; Thu, 19 Oct 2017 05:53:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e57Ve-0007Ha-Dk for guix-patches@gnu.org; Thu, 19 Oct 2017 05:53:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:40435) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e57Ve-0007HM-9r for guix-patches@gnu.org; Thu, 19 Oct 2017 05:53:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e57Vd-0005wo-SK for guix-patches@gnu.org; Thu, 19 Oct 2017 05:53:01 -0400 Subject: [bug#28853] [PATCH 2/8] gnu: qemu: Enable spice usb redirection support. Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20171015151545.024a589f@uwaterloo.ca> <20171015200328.4830-2-ajpatter@uwaterloo.ca> <87r2u3kzd0.fsf@member.fsf.org> <20171018221442.6e140c5b@uwaterloo.ca> Date: Thu, 19 Oct 2017 11:52:02 +0200 In-Reply-To: <20171018221442.6e140c5b@uwaterloo.ca> (Andy Patterson's message of "Wed, 18 Oct 2017 22:14:42 -0400") Message-ID: <87shefmpml.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Andy Patterson Cc: 28853@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello, Andy Patterson skribis: > On Mon, 16 Oct 2017 21:15:39 +0800 > iyzsong@member.fsf.org (=E5=AE=8B=E6=96=87=E6=AD=A6) wrote: > >> Andy Patterson writes: >>=20 >> > * gnu/packages/virtualization.scm >> > (qemu)[arguments]<#:configure-flags>: New argument. >> > [inputs]: Add usbredir. >> > (qemu-minimal)[arguments]<#:configure-flags>: Restrict them even >> > when they are set by qemu. >> > [inputs]: Remove usbredir.=20=20 >>=20 >> Doesn't the 'configure' script auto-detect usb redirection support >> when usbredir is available? > > To me, the advantage of specifying the enabled features is that the > build will require the dependencies to be available for that feature > even if they change. So, if more dependencies are required for the > feature in future versions, the build will immediately inform us, rather > than somewhat silently dropping support. Thoughts? That makes sense to me. I took the liberty to make the change below, to avoid a rebuild of =E2=80=98qemu-minimal=E2=80=99, and applied it. Thanks, Ludo=E2=80=99. --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/gnu/packages/virtualization.scm b/gnu/packages/virtualization.scm index 4a711ee7f..49dee07f5 100644 --- a/gnu/packages/virtualization.scm +++ b/gnu/packages/virtualization.scm @@ -192,10 +192,8 @@ server and embedded PowerPC, and S390 guests.") (arguments (substitute-keyword-arguments (package-arguments qemu) ((#:configure-flags _ '(list)) - `(list - ,(string-append - "--target-list=i386-softmmu,x86_64-softmmu,mips64el-softmmu" - ",arm-softmmu,aarch64-softmmu"))))) + ;; Restrict to the targets supported by Guix. + ''("--target-list=i386-softmmu,x86_64-softmmu,mips64el-softmmu,arm-softmmu,aarch64-softmmu")))) ;; Remove dependencies on optional libraries, notably GUI libraries. (inputs (fold alist-delete (package-inputs qemu) --=-=-=--