all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Andy Patterson <ajpatter@uwaterloo.ca>
To: 宋文武 <iyzsong@member.fsf.org>
Cc: 28853@debbugs.gnu.org
Subject: [bug#28853] [PATCH 2/8] gnu: qemu: Enable spice usb redirection support.
Date: Wed, 18 Oct 2017 22:14:42 -0400	[thread overview]
Message-ID: <20171018221442.6e140c5b@uwaterloo.ca> (raw)
In-Reply-To: <87r2u3kzd0.fsf@member.fsf.org>

Hey 宋文武,

Thanks for the review!

On Mon, 16 Oct 2017 21:15:39 +0800
iyzsong@member.fsf.org (宋文武) wrote:

> Andy Patterson <ajpatter@uwaterloo.ca> writes:
> 
> > * gnu/packages/virtualization.scm
> > (qemu)[arguments]<#:configure-flags>: New argument.
> > [inputs]: Add usbredir.
> > (qemu-minimal)[arguments]<#:configure-flags>: Restrict them even
> > when they are set by qemu.
> > [inputs]: Remove usbredir.  
> 
> Doesn't the 'configure' script auto-detect usb redirection support
> when usbredir is available?

To me, the advantage of specifying the enabled features is that the
build will require the dependencies to be available for that feature
even if they change. So, if more dependencies are required for the
feature in future versions, the build will immediately inform us, rather
than somewhat silently dropping support. Thoughts?

[...]

Thanks,

--
Andy

  reply	other threads:[~2017-10-19  2:15 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-15 19:15 [bug#28853] Some virt-manager improvements Andy Patterson
2017-10-15 20:03 ` [bug#28853] [PATCH 1/8] gnu: virt-manager: Enable gtk schemas and glib modules support Andy Patterson
2017-10-16 13:25   ` 宋文武
2017-10-19  2:19     ` Andy Patterson
2017-10-26  5:18       ` Ludovic Courtès
2017-10-15 20:03 ` [bug#28853] [PATCH 2/8] gnu: qemu: Enable spice usb redirection support Andy Patterson
2017-10-16 13:15   ` 宋文武
2017-10-19  2:14     ` Andy Patterson [this message]
2017-10-19  9:52       ` Ludovic Courtès
2017-10-15 20:03 ` [bug#28853] [PATCH 3/8] gnu: spice-gtk: Enable GObject introspection support Andy Patterson
2017-10-19  9:56   ` Ludovic Courtès
2017-10-15 20:03 ` [bug#28853] [PATCH 4/8] gnu: virt-manager: Enable spice-gtk support Andy Patterson
2017-10-19  9:57   ` Ludovic Courtès
2017-10-15 20:03 ` [bug#28853] [PATCH 5/8] gnu: qemu: Add OpenGL support Andy Patterson
2017-10-19  9:59   ` Ludovic Courtès
2017-10-15 20:03 ` [bug#28853] [PATCH 6/8] gnu: virt-manager: Enable statistics graphing support Andy Patterson
2017-10-19  9:59   ` Ludovic Courtès
2017-10-15 20:03 ` [bug#28853] [PATCH 7/8] gnu: virt-manager: Fix default URI check Andy Patterson
2017-10-19 10:01   ` Ludovic Courtès
2017-10-15 20:03 ` [bug#28853] [PATCH 8/8] gnu: virt-manager: Enable persistent configuration support Andy Patterson
2017-10-26  5:22   ` bug#28853: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171018221442.6e140c5b@uwaterloo.ca \
    --to=ajpatter@uwaterloo.ca \
    --cc=28853@debbugs.gnu.org \
    --cc=iyzsong@member.fsf.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.