From: iyzsong@member.fsf.org (宋文武)
To: Andy Patterson <ajpatter@uwaterloo.ca>
Cc: 28853@debbugs.gnu.org
Subject: [bug#28853] [PATCH 2/8] gnu: qemu: Enable spice usb redirection support.
Date: Mon, 16 Oct 2017 21:15:39 +0800 [thread overview]
Message-ID: <87r2u3kzd0.fsf@member.fsf.org> (raw)
In-Reply-To: <20171015200328.4830-2-ajpatter@uwaterloo.ca> (Andy Patterson's message of "Sun, 15 Oct 2017 16:03:22 -0400")
Andy Patterson <ajpatter@uwaterloo.ca> writes:
> * gnu/packages/virtualization.scm (qemu)[arguments]<#:configure-flags>: New
> argument.
> [inputs]: Add usbredir.
> (qemu-minimal)[arguments]<#:configure-flags>: Restrict them even when they are
> set by qemu.
> [inputs]: Remove usbredir.
Doesn't the 'configure' script auto-detect usb redirection support when
usbredir is available?
> ---
> gnu/packages/virtualization.scm | 17 +++++++++++------
> 1 file changed, 11 insertions(+), 6 deletions(-)
>
> diff --git a/gnu/packages/virtualization.scm b/gnu/packages/virtualization.scm
> index 5cdf6d09b..24ffc2f28 100644
> --- a/gnu/packages/virtualization.scm
> +++ b/gnu/packages/virtualization.scm
> @@ -4,6 +4,7 @@
> ;;; Copyright © 2016, 2017 Efraim Flashner <efraim@flashner.co.il>
> ;;; Copyright © 2016 Ricardo Wurmus <rekado@elephly.net>
> ;;; Copyright © 2017 Alex Vong <alexvong1995@gmail.com>
> +;;; Copyright © 2017 Andy Patterson <ajpatter@uwaterloo.ca>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -85,7 +86,7 @@
> '(;; Running tests in parallel can occasionally lead to failures, like:
> ;; boot_sector_test: assertion failed (signature == SIGNATURE): (0x00000000 == 0x0000dead)
> #:parallel-tests? #f
> -
> + #:configure-flags '("--enable-usb-redir")
In that case, this and ...
> #:phases
> (modify-phases %standard-phases
> (replace 'configure
> @@ -152,6 +153,7 @@
> ("pixman" ,pixman)
> ("sdl" ,sdl)
> ("spice" ,spice)
> + ("usbredir" ,usbredir)
> ("util-linux" ,util-linux)
> ;; ("vde2" ,vde2)
> ("virglrenderer" ,virglrenderer)
> @@ -188,14 +190,17 @@ server and embedded PowerPC, and S390 guests.")
> (name "qemu-minimal")
> (synopsis "Machine emulator and virtualizer (without GUI)")
> (arguments
> - `(#:configure-flags
> - ;; Restrict to the targets supported by Guix.
> - '("--target-list=i386-softmmu,x86_64-softmmu,mips64el-softmmu,arm-softmmu,aarch64-softmmu")
> - ,@(package-arguments qemu)))
> + (substitute-keyword-arguments (package-arguments qemu)
> + ((#:configure-flags _ '(list))
> + `(list
> + ,(string-append
> + "--target-list=i386-softmmu,x86_64-softmmu,mips64el-softmmu"
> + ",arm-softmmu,aarch64-softmmu")))))
>
... can be removed.
next prev parent reply other threads:[~2017-10-16 13:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-15 19:15 [bug#28853] Some virt-manager improvements Andy Patterson
2017-10-15 20:03 ` [bug#28853] [PATCH 1/8] gnu: virt-manager: Enable gtk schemas and glib modules support Andy Patterson
2017-10-16 13:25 ` 宋文武
2017-10-19 2:19 ` Andy Patterson
2017-10-26 5:18 ` Ludovic Courtès
2017-10-15 20:03 ` [bug#28853] [PATCH 2/8] gnu: qemu: Enable spice usb redirection support Andy Patterson
2017-10-16 13:15 ` 宋文武 [this message]
2017-10-19 2:14 ` Andy Patterson
2017-10-19 9:52 ` Ludovic Courtès
2017-10-15 20:03 ` [bug#28853] [PATCH 3/8] gnu: spice-gtk: Enable GObject introspection support Andy Patterson
2017-10-19 9:56 ` Ludovic Courtès
2017-10-15 20:03 ` [bug#28853] [PATCH 4/8] gnu: virt-manager: Enable spice-gtk support Andy Patterson
2017-10-19 9:57 ` Ludovic Courtès
2017-10-15 20:03 ` [bug#28853] [PATCH 5/8] gnu: qemu: Add OpenGL support Andy Patterson
2017-10-19 9:59 ` Ludovic Courtès
2017-10-15 20:03 ` [bug#28853] [PATCH 6/8] gnu: virt-manager: Enable statistics graphing support Andy Patterson
2017-10-19 9:59 ` Ludovic Courtès
2017-10-15 20:03 ` [bug#28853] [PATCH 7/8] gnu: virt-manager: Fix default URI check Andy Patterson
2017-10-19 10:01 ` Ludovic Courtès
2017-10-15 20:03 ` [bug#28853] [PATCH 8/8] gnu: virt-manager: Enable persistent configuration support Andy Patterson
2017-10-26 5:22 ` bug#28853: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2u3kzd0.fsf@member.fsf.org \
--to=iyzsong@member.fsf.org \
--cc=28853@debbugs.gnu.org \
--cc=ajpatter@uwaterloo.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.