all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Andy Patterson <ajpatter@uwaterloo.ca>
To: 宋文武 <iyzsong@member.fsf.org>
Cc: 28853@debbugs.gnu.org
Subject: [bug#28853] [PATCH 1/8] gnu: virt-manager: Enable gtk schemas and glib modules support.
Date: Wed, 18 Oct 2017 22:19:06 -0400	[thread overview]
Message-ID: <20171018221906.7f76610a@uwaterloo.ca> (raw)
In-Reply-To: <87mv4rkywx.fsf@member.fsf.org>

Hi,

On Mon, 16 Oct 2017 21:25:18 +0800
iyzsong@member.fsf.org (宋文武) wrote:

> Andy Patterson <ajpatter@uwaterloo.ca> writes:
> 
> > virt-manager: Enable gtk schemas and glib modules support.  
> 
> How about: Wrap with GSettings schema and GIO modules search paths.
> 
> Otherwise, this patch series look good to me, thanks!

Sounds good, updated patch appened:

--
Andy

From f504ccc9e961e7657261a478e278c142b9006e6b Mon Sep 17 00:00:00 2001
From: Andy Patterson <ajpatter@uwaterloo.ca>
Date: Sun, 15 Oct 2017 11:47:16 -0400
Subject: [PATCH] gnu: virt-manager: Wrap with GSettings schema and GIO modules
 search paths.

Fixes a crash when opening the file chooser dialog.

* gnu/packages/virtualization.scm (virt-manager)[arguments]
<#:imported-modules>: Add (guix build glib-or-gtk-build-system).
<#:modules>: Import (guix build glib-or-gtk-build-system) as glib-or-gtk:.
<#:arguments>: Add 'glib-or-gtk-compile-schemas and 'glib-or-gtk-wrap.
---
 gnu/packages/virtualization.scm | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/virtualization.scm b/gnu/packages/virtualization.scm
index 4e384e79a..5cdf6d09b 100644
--- a/gnu/packages/virtualization.scm
+++ b/gnu/packages/virtualization.scm
@@ -499,9 +499,12 @@ virtualization library.")
        ;; Some of the tests seem to require network access to install virtual
        ;; machines.
        #:tests? #f
+       #:imported-modules ((guix build glib-or-gtk-build-system)
+                           ,@%python-build-system-modules)
        #:modules ((ice-9 match)
                   (srfi srfi-26)
                   (guix build python-build-system)
+                  ((guix build glib-or-gtk-build-system) #:prefix glib-or-gtk:)
                   (guix build utils))
        #:phases
        (modify-phases %standard-phases
@@ -528,7 +531,11 @@ virtualization library.")
                              `("GI_TYPELIB_PATH" ":" prefix
                                ,(filter identity paths))))
                          bin-files))
-             #t)))))
+             #t))
+         (add-after 'install 'glib-or-gtk-compile-schemas
+           (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-compile-schemas))
+         (add-after 'install 'glib-or-gtk-wrap
+           (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap)))))
     (inputs
      `(("gtk+" ,gtk+)
        ("gtk-vnc" ,gtk-vnc)
-- 
2.14.2

  reply	other threads:[~2017-10-19  2:20 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-15 19:15 [bug#28853] Some virt-manager improvements Andy Patterson
2017-10-15 20:03 ` [bug#28853] [PATCH 1/8] gnu: virt-manager: Enable gtk schemas and glib modules support Andy Patterson
2017-10-16 13:25   ` 宋文武
2017-10-19  2:19     ` Andy Patterson [this message]
2017-10-26  5:18       ` Ludovic Courtès
2017-10-15 20:03 ` [bug#28853] [PATCH 2/8] gnu: qemu: Enable spice usb redirection support Andy Patterson
2017-10-16 13:15   ` 宋文武
2017-10-19  2:14     ` Andy Patterson
2017-10-19  9:52       ` Ludovic Courtès
2017-10-15 20:03 ` [bug#28853] [PATCH 3/8] gnu: spice-gtk: Enable GObject introspection support Andy Patterson
2017-10-19  9:56   ` Ludovic Courtès
2017-10-15 20:03 ` [bug#28853] [PATCH 4/8] gnu: virt-manager: Enable spice-gtk support Andy Patterson
2017-10-19  9:57   ` Ludovic Courtès
2017-10-15 20:03 ` [bug#28853] [PATCH 5/8] gnu: qemu: Add OpenGL support Andy Patterson
2017-10-19  9:59   ` Ludovic Courtès
2017-10-15 20:03 ` [bug#28853] [PATCH 6/8] gnu: virt-manager: Enable statistics graphing support Andy Patterson
2017-10-19  9:59   ` Ludovic Courtès
2017-10-15 20:03 ` [bug#28853] [PATCH 7/8] gnu: virt-manager: Fix default URI check Andy Patterson
2017-10-19 10:01   ` Ludovic Courtès
2017-10-15 20:03 ` [bug#28853] [PATCH 8/8] gnu: virt-manager: Enable persistent configuration support Andy Patterson
2017-10-26  5:22   ` bug#28853: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171018221906.7f76610a@uwaterloo.ca \
    --to=ajpatter@uwaterloo.ca \
    --cc=28853@debbugs.gnu.org \
    --cc=iyzsong@member.fsf.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.