unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#60997] [patch] gnu: Add python-cmseq, python-cmseq, python-phylophlan and python-metaphlan.
@ 2023-01-22  0:44 MadalinIonel.Patrascu
  2023-01-22  0:49 ` [bug#60997] [PATCH 1/4] gnu: Add python-cmseq Mădălin Ionel Patrașcu
  0 siblings, 1 reply; 8+ messages in thread
From: MadalinIonel.Patrascu @ 2023-01-22  0:44 UTC (permalink / raw)
  To: 60997

[-- Attachment #1: Type: text/plain, Size: 2 bytes --]



[-- Attachment #2: Type: text/html, Size: 830 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [bug#60997] [PATCH 1/4] gnu: Add python-cmseq.
  2023-01-22  0:44 [bug#60997] [patch] gnu: Add python-cmseq, python-cmseq, python-phylophlan and python-metaphlan MadalinIonel.Patrascu
@ 2023-01-22  0:49 ` Mădălin Ionel Patrașcu
  2023-01-22  0:49   ` [bug#60997] [PATCH 2/4] gnu: Add python-hclust2 Mădălin Ionel Patrașcu
                     ` (3 more replies)
  0 siblings, 4 replies; 8+ messages in thread
From: Mădălin Ionel Patrașcu @ 2023-01-22  0:49 UTC (permalink / raw)
  To: 60997; +Cc: rekado

* gnu/packages/bioinformatics.scm (python-cmseq): New variable.
---
 gnu/packages/bioinformatics.scm | 29 ++++++++++++++++++++++++++++-
 1 file changed, 28 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm
index 36c9db90bd..4e7bc07a5f 100644
--- a/gnu/packages/bioinformatics.scm
+++ b/gnu/packages/bioinformatics.scm
@@ -11,7 +11,7 @@
 ;;; Copyright © 2017, 2021, 2022 Arun Isaac <arunisaac@systemreboot.net>
 ;;; Copyright © 2018 Joshua Sierles, Nextjournal <joshua@nextjournal.com>
 ;;; Copyright © 2018 Gábor Boskovits <boskovits@gmail.com>
-;;; Copyright © 2018, 2019, 2020, 2021, 2022 Mădălin Ionel Patrașcu <madalinionel.patrascu@mdc-berlin.de>
+;;; Copyright © 2018-2023 Mădălin Ionel Patrașcu <madalinionel.patrascu@mdc-berlin.de>
 ;;; Copyright © 2019, 2020, 2021 Maxim Cournoyer <maxim.cournoyer@gmail.com>
 ;;; Copyright © 2019 Brian Leung <bkleung89@gmail.com>
 ;;; Copyright © 2019 Brett Gilio <brettg@gnu.org>
@@ -1014,6 +1014,33 @@ (define-public python-cellbender
 from high-throughput single-cell RNA sequencing (scRNA-seq) data.")
     (license license:bsd-3)))
 
+(define-public python-cmseq
+  (package
+    (name "python-cmseq")
+    (version "1.0.4")
+    (source (origin
+              (method url-fetch)
+              (uri (pypi-uri "CMSeq" version))
+              (sha256
+               (base32
+                "0p6a99c299m5wi2z57dgqz52m1z3nfr8mv7kdnk2jvl2p9nql0wk"))))
+    (build-system python-build-system)
+    (arguments
+     (list #:tests? #f )) ;pypi no tests
+    (propagated-inputs
+     (list python-bcbio-gff
+           python-biopython
+           python-numpy
+           python-pandas
+           python-pysam
+           python-scipy))
+    (home-page "http://github.com/SegataLab/cmseq/")
+    (synopsis "Set of utilities on sequences and BAM files")
+    (description
+     "CMSeq is a set of commands to provide an interface to .bam files for coverage
+and sequence consensus.")
+    (license license:expat)))
+
 (define-public python-htsget
   (package
    (name "python-htsget")

base-commit: f088763356e88c4911ee933fdafcad6ed66a7aa3
-- 
2.39.1





^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [bug#60997] [PATCH 2/4] gnu: Add python-hclust2.
  2023-01-22  0:49 ` [bug#60997] [PATCH 1/4] gnu: Add python-cmseq Mădălin Ionel Patrașcu
@ 2023-01-22  0:49   ` Mădălin Ionel Patrașcu
  2023-01-22  0:49   ` [bug#60997] [PATCH 3/4] gnu: Add python-phylophlan Mădălin Ionel Patrașcu
                     ` (2 subsequent siblings)
  3 siblings, 0 replies; 8+ messages in thread
From: Mădălin Ionel Patrașcu @ 2023-01-22  0:49 UTC (permalink / raw)
  To: 60997; +Cc: rekado

* gnu/packages/bioinformatics.scm (python-hclust2): New variable.
---
 gnu/packages/bioinformatics.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm
index 4e7bc07a5f..bf01c9c7e4 100644
--- a/gnu/packages/bioinformatics.scm
+++ b/gnu/packages/bioinformatics.scm
@@ -1041,6 +1041,32 @@ (define-public python-cmseq
 and sequence consensus.")
     (license license:expat)))
 
+(define-public python-hclust2
+  (package
+    (name "python-hclust2")
+    (version "1.0.0")
+    (source (origin
+              (method url-fetch)
+              (uri (pypi-uri "hclust2" version))
+              (sha256
+               (base32
+                "0v89n2g42d7jhgfs8glf06apgxx6aswp3mfisgnhm518cv8z2rwn"))))
+    (build-system python-build-system)
+    (arguments
+     (list
+      #:tests? #f)) ;;pypi no tests
+    (propagated-inputs
+     (list python-matplotlib
+           python-numpy
+           python-pandas
+           python-scipy))
+    (home-page "http://github.com/SegataLab/hclust2/")
+    (synopsis "Plotting heat-maps for publications")
+    (description
+     "Hclust2 is a handy tool for plotting heat-maps with several useful options
+to produce high quality figures that can be used in publication")
+    (license license:expat)))
+
 (define-public python-htsget
   (package
    (name "python-htsget")
-- 
2.39.1





^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [bug#60997] [PATCH 3/4] gnu: Add python-phylophlan.
  2023-01-22  0:49 ` [bug#60997] [PATCH 1/4] gnu: Add python-cmseq Mădălin Ionel Patrașcu
  2023-01-22  0:49   ` [bug#60997] [PATCH 2/4] gnu: Add python-hclust2 Mădălin Ionel Patrașcu
@ 2023-01-22  0:49   ` Mădălin Ionel Patrașcu
  2023-01-24  9:10     ` Ricardo Wurmus
  2023-01-22  0:49   ` [bug#60997] [PATCH 4/4] gnu: Add python-metaphlan Mădălin Ionel Patrașcu
  2023-01-24  8:36   ` [bug#60997] [PATCH 1/4] gnu: Add python-cmseq Ricardo Wurmus
  3 siblings, 1 reply; 8+ messages in thread
From: Mădălin Ionel Patrașcu @ 2023-01-22  0:49 UTC (permalink / raw)
  To: 60997; +Cc: rekado

* gnu/packages/bioinformatics.scm (python-phylophlan): New variable.
---
 gnu/packages/bioinformatics.scm | 43 +++++++++++++++++++++++++++++++++
 1 file changed, 43 insertions(+)

diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm
index bf01c9c7e4..5c9c222d59 100644
--- a/gnu/packages/bioinformatics.scm
+++ b/gnu/packages/bioinformatics.scm
@@ -1089,6 +1089,49 @@ (define-public python-htsget
 servers supporting the protocol.")
    (license license:asl2.0)))
 
+(define-public python-phylophlan
+  (package
+    (name "python-phylophlan")
+    (version "3.0.3")
+    (source (origin
+              (method url-fetch)
+              (uri (pypi-uri "PhyloPhlAn" version))
+              (sha256
+               (base32
+                "1r1bnnh4d38l410hfzf882y43ln8fd2lcsqbralqshxqw2hzc7x7"))))
+    (build-system python-build-system)
+    (arguments
+     (list
+      #:tests? #f ;pypi no tests
+      #:phases
+      #~(modify-phases %standard-phases
+          ;;pypi does not provide the readme.md file
+          (add-before 'build 'loose-readme-file-requirement
+           (lambda _
+              (substitute* "setup.py"
+                (("long_description")
+                  "#long_description")))))))
+    (propagated-inputs
+     (list python-biopython
+           python-dendropy
+           python-matplotlib
+           python-numpy
+           python-pandas
+           python-seaborn))
+    (home-page "https://github.com/biobakery/phylophlan")
+    (synopsis
+     "Phylogenetic analysis of microbial isolates and genomes from metagenomes")
+    (description
+     "This package is an integrated pipeline for large-scale phylogenetic profiling
+of genomes and metagenomes.  PhyloPhlAn is an accurate, rapid, and easy-to-use
+method for large-scale microbial genome characterization and phylogenetic analysis
+at multiple levels of resolution.  This software package can assign both genomes
+and @acronym{MAGs, metagenome-assembled genomes} to @acronym{SGBs, species-level
+genome bins}.  PhyloPhlAn can reconstruct strain-level phylogenies using clade-
+specific maximally informative phylogenetic markers, and can also scale to very
+large phylogenies comprising >17,000 microbial species.")
+    (license license:expat)))
+
 (define-public python-pybedtools
   (package
     (name "python-pybedtools")
-- 
2.39.1





^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [bug#60997] [PATCH 4/4] gnu: Add python-metaphlan.
  2023-01-22  0:49 ` [bug#60997] [PATCH 1/4] gnu: Add python-cmseq Mădălin Ionel Patrașcu
  2023-01-22  0:49   ` [bug#60997] [PATCH 2/4] gnu: Add python-hclust2 Mădălin Ionel Patrașcu
  2023-01-22  0:49   ` [bug#60997] [PATCH 3/4] gnu: Add python-phylophlan Mădălin Ionel Patrașcu
@ 2023-01-22  0:49   ` Mădălin Ionel Patrașcu
  2023-01-24  9:11     ` Ricardo Wurmus
  2023-01-24  8:36   ` [bug#60997] [PATCH 1/4] gnu: Add python-cmseq Ricardo Wurmus
  3 siblings, 1 reply; 8+ messages in thread
From: Mădălin Ionel Patrașcu @ 2023-01-22  0:49 UTC (permalink / raw)
  To: 60997; +Cc: rekado

* gnu/packages/bioinformatics.scm (python-metaphlan): New variable.
---
 gnu/packages/bioinformatics.scm | 37 +++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)

diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm
index 5c9c222d59..884e5aa1e5 100644
--- a/gnu/packages/bioinformatics.scm
+++ b/gnu/packages/bioinformatics.scm
@@ -11234,6 +11234,43 @@ (define-public python-biothings-client
 API services.")
     (license license:bsd-3)))
 
+(define-public python-metaphlan
+  (package
+    (name "python-metaphlan")
+    (version "4.0.4")
+    (source
+     (origin
+     (method url-fetch)
+              (uri (pypi-uri "MetaPhlAn" version))
+              (sha256
+               (base32
+                "1jw29m8p8bcwn4q5qvh8s96qlgqv1kaizbmm87jk55f34k1y3y8a"))))
+    (build-system python-build-system)
+    (arguments
+     (list
+      #:tests? #f)) ;pypi no tests
+    (propagated-inputs
+     (list python-biom-format
+           python-biopython
+           python-cmseq
+           python-dendropy
+           python-h5py
+           python-hclust2
+           python-numpy
+           python-pandas
+           python-phylophlan
+           python-pysam
+           python-requests
+           python-scipy))
+    (home-page "http://github.com/biobakery/MetaPhlAn/")
+    (synopsis "Metagenomic phylogenetic analysis")
+    (description
+     "MetaPhlAn is a computational tool for profiling the composition of microbial
+communities (Bacteria, Archaea and Eukaryotes) from metagenomic shotgun sequencing
+data (i.e.  not 16S) with species-level.  With the newly added StrainPhlAn module,
+it is now possible to perform accurate strain-level microbial profiling.")
+    (license license:expat)))
+
 (define-public python-multivelo
   (package
     (name "python-multivelo")
-- 
2.39.1





^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [bug#60997] [PATCH 1/4] gnu: Add python-cmseq.
  2023-01-22  0:49 ` [bug#60997] [PATCH 1/4] gnu: Add python-cmseq Mădălin Ionel Patrașcu
                     ` (2 preceding siblings ...)
  2023-01-22  0:49   ` [bug#60997] [PATCH 4/4] gnu: Add python-metaphlan Mădălin Ionel Patrașcu
@ 2023-01-24  8:36   ` Ricardo Wurmus
  3 siblings, 0 replies; 8+ messages in thread
From: Ricardo Wurmus @ 2023-01-24  8:36 UTC (permalink / raw)
  To: Mădălin Ionel Patrașcu; +Cc: 60997


Hi Mădălin,

> * gnu/packages/bioinformatics.scm (python-cmseq): New variable.

Thanks for the patch.

Unfortunately, this is incomplete:

- The tool calls out to samtools (see cmseq/cmseq.py), so it needs
  samtools as an input and the call needs to be patched.

- The README says that biopython <= 1.76 is needed for polymut.py.
  You’re using 1.80.

> +    (build-system python-build-system)

Please consider using the pyproject-build-system.

> +    (arguments
> +     (list #:tests? #f )) ;pypi no tests

Apparantly, there are no tests anywhere.  It’s not a pypi problem.
Please update the comment and remove that extra space after #f.

> +    (home-page "http://github.com/SegataLab/cmseq/")

Please use HTTPS.  “guix lint” informs you about the redirect.

-- 
Ricardo




^ permalink raw reply	[flat|nested] 8+ messages in thread

* [bug#60997] [PATCH 3/4] gnu: Add python-phylophlan.
  2023-01-22  0:49   ` [bug#60997] [PATCH 3/4] gnu: Add python-phylophlan Mădălin Ionel Patrașcu
@ 2023-01-24  9:10     ` Ricardo Wurmus
  0 siblings, 0 replies; 8+ messages in thread
From: Ricardo Wurmus @ 2023-01-24  9:10 UTC (permalink / raw)
  To: Mădălin Ionel Patrașcu; +Cc: 60997


Mădălin Ionel Patrașcu <madalinionel.patrascu@mdc-berlin.de> writes:

> +    (build-system python-build-system)

Please use pyproject-build-system where possible.

> +    (arguments
> +     (list
> +      #:tests? #f ;pypi no tests

There are no tests, nothing to do with pypi.

> +      #:phases
> +      #~(modify-phases %standard-phases
> +          ;;pypi does not provide the readme.md file
> +          (add-before 'build 'loose-readme-file-requirement
> +           (lambda _
> +              (substitute* "setup.py"
> +                (("long_description")
> +                  "#long_description")))))))

I changed this to just fetch the source from git.

> +    (propagated-inputs
> +     (list python-biopython

This will become a problem down the line when combined with cmseq.

-- 
Ricardo




^ permalink raw reply	[flat|nested] 8+ messages in thread

* [bug#60997] [PATCH 4/4] gnu: Add python-metaphlan.
  2023-01-22  0:49   ` [bug#60997] [PATCH 4/4] gnu: Add python-metaphlan Mădălin Ionel Patrașcu
@ 2023-01-24  9:11     ` Ricardo Wurmus
  0 siblings, 0 replies; 8+ messages in thread
From: Ricardo Wurmus @ 2023-01-24  9:11 UTC (permalink / raw)
  To: Mădălin Ionel Patrașcu; +Cc: 60997


Mădălin Ionel Patrașcu <madalinionel.patrascu@mdc-berlin.de> writes:

> * gnu/packages/bioinformatics.scm (python-metaphlan): New variable.

Unfortunately, this one is also incomplete.

The package includes R code that needs to have its dependencies
satisfied.  It also calls out to bowtie2, and needs raxml, muscle,
blast, etc.

The clash of biopython versions will also need to be addressed.

I’ll push as much as is feasible, but I’d like to ask you to rework this
package definition in particular.

Thanks!

-- 
Ricardo




^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2023-01-24  9:16 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-22  0:44 [bug#60997] [patch] gnu: Add python-cmseq, python-cmseq, python-phylophlan and python-metaphlan MadalinIonel.Patrascu
2023-01-22  0:49 ` [bug#60997] [PATCH 1/4] gnu: Add python-cmseq Mădălin Ionel Patrașcu
2023-01-22  0:49   ` [bug#60997] [PATCH 2/4] gnu: Add python-hclust2 Mădălin Ionel Patrașcu
2023-01-22  0:49   ` [bug#60997] [PATCH 3/4] gnu: Add python-phylophlan Mădălin Ionel Patrașcu
2023-01-24  9:10     ` Ricardo Wurmus
2023-01-22  0:49   ` [bug#60997] [PATCH 4/4] gnu: Add python-metaphlan Mădălin Ionel Patrașcu
2023-01-24  9:11     ` Ricardo Wurmus
2023-01-24  8:36   ` [bug#60997] [PATCH 1/4] gnu: Add python-cmseq Ricardo Wurmus

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).