* [bug#45604] [PATCH 0/1] Add magic-enum package
@ 2021-01-02 0:51 Anadon
2021-01-02 0:51 ` [bug#45604] [PATCH 1/1] Added magic-enum header-only library as a package Anadon
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Anadon @ 2021-01-02 0:51 UTC (permalink / raw)
To: 45604; +Cc: Anadon
Magic-enum is a C++17 header-only library for support of static
reflection on enums.
Josh Marshall (1):
Added magic-enum header-only library as a package.
gnu/packages/cpp.scm | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
--
2.29.2
^ permalink raw reply [flat|nested] 8+ messages in thread
* [bug#45604] [PATCH 1/1] Added magic-enum header-only library as a package.
2021-01-02 0:51 [bug#45604] [PATCH 0/1] Add magic-enum package Anadon
@ 2021-01-02 0:51 ` Anadon
2021-01-04 13:06 ` Leo Prikler
2021-01-09 7:51 ` [bug#45604] [PATCH 0/2] " Leo Prikler
2021-01-20 4:09 ` [bug#45604] [PATCH] gnu: Add magic-enum Anadon
2 siblings, 1 reply; 8+ messages in thread
From: Anadon @ 2021-01-02 0:51 UTC (permalink / raw)
To: 45604; +Cc: Josh Marshall
From: Josh Marshall <joshua.r.marshall.1991@gmail.com>
---
gnu/packages/cpp.scm | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/gnu/packages/cpp.scm b/gnu/packages/cpp.scm
index 00e006928e..ff10a4247b 100644
--- a/gnu/packages/cpp.scm
+++ b/gnu/packages/cpp.scm
@@ -807,3 +807,27 @@ code will be mixed in with the actual programming logic. This implementation
provides a number of utilities to make coding with expected cleaner.")
(home-page "https://tl.tartanllama.xyz/")
(license license:cc0)))
+
+(define-public magic-enum
+ (package
+ (name "magic-enum")
+ (version "0.7.2")
+ (home-page "https://github.com/Neargye/magic_enum")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url home-page)
+ (commit (string-append "v" version))))
+ (sha256
+ (base32
+ "0fmkyh1srkz2bx68agfa30sankg1ig1f95xqp8sp9wj3p9qilsv2"))
+ (modules '((guix build utils)))))
+ (build-system cmake-build-system)
+
+ (inputs
+ `(("gcc" ,gcc-10)))
+ (synopsis "Header-only C++17 library for reflection for enums")
+ (description "Static reflection for enums (to string, from string,
+iteration) for modern C++, work with any enum type without any macro or
+boilerplate code")
+ (license license:expat)))
--
2.29.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [bug#45604] [PATCH 1/1] Added magic-enum header-only library as a package.
2021-01-02 0:51 ` [bug#45604] [PATCH 1/1] Added magic-enum header-only library as a package Anadon
@ 2021-01-04 13:06 ` Leo Prikler
2021-01-04 21:59 ` Josh Marshall
0 siblings, 1 reply; 8+ messages in thread
From: Leo Prikler @ 2021-01-04 13:06 UTC (permalink / raw)
To: Anadon; +Cc: 45604
Hello Anadon,
I have not yet built your package (because I'm currently also handling
another patch), but since you've requested review over at guix-devel,
I'll have a go at it.
For the future please note, that a delay of 2 days does not mean we
haven't noticed you at all. The manual has the following to say for
committers:
> For anything else, please post to <guix-patches@gnu.org> and leave
> time for a review, without committing anything (*note Submitting
> Patches::). If you didn’t receive any reply after two weeks, and if
> you’re confident, it’s OK to commit.
Am Freitag, den 01.01.2021, 19:51 -0500 schrieb Anadon:
> From: Josh Marshall <joshua.r.marshall.1991@gmail.com>
Ehh, somehow the commit message and everything is missing here. Is
that intended or just misconfigured?
> ---
> gnu/packages/cpp.scm | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/gnu/packages/cpp.scm b/gnu/packages/cpp.scm
> index 00e006928e..ff10a4247b 100644
> --- a/gnu/packages/cpp.scm
> +++ b/gnu/packages/cpp.scm
> @@ -807,3 +807,27 @@ code will be mixed in with the actual
> programming logic. This implementation
> provides a number of utilities to make coding with expected
> cleaner.")
> (home-page "https://tl.tartanllama.xyz/")
> (license license:cc0)))
> +
> +(define-public magic-enum
> + (package
> + (name "magic-enum")
> + (version "0.7.2")
> + (home-page "https://github.com/Neargye/magic_enum")
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url home-page)
> + (commit (string-append "v" version))))
> + (sha256
> + (base32
> + "0fmkyh1srkz2bx68agfa30sankg1ig1f95xqp8sp9wj3p9qil
> sv2"))
> + (modules '((guix build utils)))))
> + (build-system cmake-build-system)
> +
> + (inputs
> + `(("gcc" ,gcc-10)))
The home-page claims, that it works with GCC>=9. Have you encountered
any issues with gcc-9 instead?
> + (synopsis "Header-only C++17 library for reflection for
> enums")
I feel as though that could be worded better.
> + (description "Static reflection for enums (to string, from
> string,
> +iteration) for modern C++, work with any enum type without any macro
> or
> +boilerplate code")
Descriptions should be complete sentences and end with a period.
> + (license license:expat)))
Regards,
Leo
^ permalink raw reply [flat|nested] 8+ messages in thread
* [bug#45604] [PATCH 1/1] Added magic-enum header-only library as a package.
2021-01-04 13:06 ` Leo Prikler
@ 2021-01-04 21:59 ` Josh Marshall
2021-01-05 20:39 ` Leo Prikler
0 siblings, 1 reply; 8+ messages in thread
From: Josh Marshall @ 2021-01-04 21:59 UTC (permalink / raw)
To: Leo Prikler; +Cc: 45604
[-- Attachment #1: Type: text/plain, Size: 3124 bytes --]
Sorry, one more thing I missed in the documentation was the waiting
period. The commit message missing is probably a misconfiguration. I can
change to gcc-9, I just defaulted to the newest since the default was too
old. That description is a verbatim copy of their description.
I'll fix these up, then issue another patch series.
On Mon, Jan 4, 2021 at 8:06 AM Leo Prikler <leo.prikler@student.tugraz.at>
wrote:
> Hello Anadon,
>
> I have not yet built your package (because I'm currently also handling
> another patch), but since you've requested review over at guix-devel,
> I'll have a go at it.
> For the future please note, that a delay of 2 days does not mean we
> haven't noticed you at all. The manual has the following to say for
> committers:
> > For anything else, please post to <guix-patches@gnu.org> and leave
> > time for a review, without committing anything (*note Submitting
> > Patches::). If you didn’t receive any reply after two weeks, and if
> > you’re confident, it’s OK to commit.
>
> Am Freitag, den 01.01.2021, 19:51 -0500 schrieb Anadon:
> > From: Josh Marshall <joshua.r.marshall.1991@gmail.com>
> Ehh, somehow the commit message and everything is missing here. Is
> that intended or just misconfigured?
>
> > ---
> > gnu/packages/cpp.scm | 24 ++++++++++++++++++++++++
> > 1 file changed, 24 insertions(+)
> >
> > diff --git a/gnu/packages/cpp.scm b/gnu/packages/cpp.scm
> > index 00e006928e..ff10a4247b 100644
> > --- a/gnu/packages/cpp.scm
> > +++ b/gnu/packages/cpp.scm
> > @@ -807,3 +807,27 @@ code will be mixed in with the actual
> > programming logic. This implementation
> > provides a number of utilities to make coding with expected
> > cleaner.")
> > (home-page "https://tl.tartanllama.xyz/")
> > (license license:cc0)))
> > +
> > +(define-public magic-enum
> > + (package
> > + (name "magic-enum")
> > + (version "0.7.2")
> > + (home-page "https://github.com/Neargye/magic_enum")
> > + (source (origin
> > + (method git-fetch)
> > + (uri (git-reference
> > + (url home-page)
> > + (commit (string-append "v" version))))
> > + (sha256
> > + (base32
> > + "0fmkyh1srkz2bx68agfa30sankg1ig1f95xqp8sp9wj3p9qil
> > sv2"))
> > + (modules '((guix build utils)))))
> > + (build-system cmake-build-system)
> > +
> > + (inputs
> > + `(("gcc" ,gcc-10)))
> The home-page claims, that it works with GCC>=9. Have you encountered
> any issues with gcc-9 instead?
> > + (synopsis "Header-only C++17 library for reflection for
> > enums")
> I feel as though that could be worded better.
> > + (description "Static reflection for enums (to string, from
> > string,
> > +iteration) for modern C++, work with any enum type without any macro
> > or
> > +boilerplate code")
> Descriptions should be complete sentences and end with a period.
> > + (license license:expat)))
>
> Regards,
> Leo
>
>
[-- Attachment #2: Type: text/html, Size: 4289 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* [bug#45604] [PATCH 1/1] Added magic-enum header-only library as a package.
2021-01-04 21:59 ` Josh Marshall
@ 2021-01-05 20:39 ` Leo Prikler
0 siblings, 0 replies; 8+ messages in thread
From: Leo Prikler @ 2021-01-05 20:39 UTC (permalink / raw)
To: Josh Marshall; +Cc: 45604
Hello Josh,
Am Montag, den 04.01.2021, 16:59 -0500 schrieb Josh Marshall:
> Sorry, one more thing I missed in the documentation was the waiting
> period. The commit message missing is probably a misconfiguration.
> I can change to gcc-9, I just defaulted to the newest since the
> default was too old. That description is a verbatim copy of their
> description.
W.r.t. the description you should probably come up with words of your
own. The upstream one doesn't appear all that usable.
For the record, gcc should likely also be a native-input, given that
it'll be used for compilation and testing.
> I'll fix these up, then issue another patch series.
Don't forget to set --to, --cc and --reroll-count when you do ;)
Otherwise you might inadvertently open up new issues which will at
least confuse the bug tracker.
Regards,
Leo
> On Mon, Jan 4, 2021 at 8:06 AM Leo Prikler <
> leo.prikler@student.tugraz.at> wrote:
> > Hello Anadon,
> >
> > I have not yet built your package (because I'm currently also
> > handling
> > another patch), but since you've requested review over at guix-
> > devel,
> > I'll have a go at it.
> > For the future please note, that a delay of 2 days does not mean we
> > haven't noticed you at all. The manual has the following to say
> > for
> > committers:
> > > For anything else, please post to <guix-patches@gnu.org> and
> > leave
> > > time for a review, without committing anything (*note Submitting
> > > Patches::). If you didn’t receive any reply after two weeks, and
> > if
> > > you’re confident, it’s OK to commit.
> >
> > Am Freitag, den 01.01.2021, 19:51 -0500 schrieb Anadon:
> > > From: Josh Marshall <joshua.r.marshall.1991@gmail.com>
> > Ehh, somehow the commit message and everything is missing here. Is
> > that intended or just misconfigured?
> >
> > > ---
> > > gnu/packages/cpp.scm | 24 ++++++++++++++++++++++++
> > > 1 file changed, 24 insertions(+)
> > >
> > > diff --git a/gnu/packages/cpp.scm b/gnu/packages/cpp.scm
> > > index 00e006928e..ff10a4247b 100644
> > > --- a/gnu/packages/cpp.scm
> > > +++ b/gnu/packages/cpp.scm
> > > @@ -807,3 +807,27 @@ code will be mixed in with the actual
> > > programming logic. This implementation
> > > provides a number of utilities to make coding with expected
> > > cleaner.")
> > > (home-page "https://tl.tartanllama.xyz/")
> > > (license license:cc0)))
> > > +
> > > +(define-public magic-enum
> > > + (package
> > > + (name "magic-enum")
> > > + (version "0.7.2")
> > > + (home-page "https://github.com/Neargye/magic_enum")
> > > + (source (origin
> > > + (method git-fetch)
> > > + (uri (git-reference
> > > + (url home-page)
> > > + (commit (string-append "v" version))))
> > > + (sha256
> > > + (base32
> > > +
> > "0fmkyh1srkz2bx68agfa30sankg1ig1f95xqp8sp9wj3p9qil
> > > sv2"))
> > > + (modules '((guix build utils)))))
> > > + (build-system cmake-build-system)
> > > +
> > > + (inputs
> > > + `(("gcc" ,gcc-10)))
> > The home-page claims, that it works with GCC>=9. Have you
> > encountered
> > any issues with gcc-9 instead?
> > > + (synopsis "Header-only C++17 library for reflection for
> > > enums")
> > I feel as though that could be worded better.
> > > + (description "Static reflection for enums (to string, from
> > > string,
> > > +iteration) for modern C++, work with any enum type without any
> > macro
> > > or
> > > +boilerplate code")
> > Descriptions should be complete sentences and end with a period.
> > > + (license license:expat)))
> >
> > Regards,
> > Leo
> >
^ permalink raw reply [flat|nested] 8+ messages in thread
* [bug#45604] [PATCH 0/2] Added magic-enum header-only library as a package.
2021-01-02 0:51 [bug#45604] [PATCH 0/1] Add magic-enum package Anadon
2021-01-02 0:51 ` [bug#45604] [PATCH 1/1] Added magic-enum header-only library as a package Anadon
@ 2021-01-09 7:51 ` Leo Prikler
2021-01-20 4:09 ` [bug#45604] [PATCH] gnu: Add magic-enum Anadon
2 siblings, 0 replies; 8+ messages in thread
From: Leo Prikler @ 2021-01-09 7:51 UTC (permalink / raw)
To: joshua.r.marshall.1991; +Cc: 45604
Hello Anadon,
three nitpicks:
1. You should squash the changes into the original commit.
2. The commit message(s) is/are still missing.
3. Please pick one name for your contributions.
Otherwise LGTM,
Leo
^ permalink raw reply [flat|nested] 8+ messages in thread
* [bug#45604] [PATCH] gnu: Add magic-enum.
2021-01-02 0:51 [bug#45604] [PATCH 0/1] Add magic-enum package Anadon
2021-01-02 0:51 ` [bug#45604] [PATCH 1/1] Added magic-enum header-only library as a package Anadon
2021-01-09 7:51 ` [bug#45604] [PATCH 0/2] " Leo Prikler
@ 2021-01-20 4:09 ` Anadon
2021-01-20 8:14 ` bug#45604: " Leo Prikler
2 siblings, 1 reply; 8+ messages in thread
From: Anadon @ 2021-01-20 4:09 UTC (permalink / raw)
To: 45604; +Cc: leo.prikler, Anadon
* gnu/packages/cpp.scm (magic-enum): Added the package definition.
---
gnu/packages/cpp.scm | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/gnu/packages/cpp.scm b/gnu/packages/cpp.scm
index 00e006928e..012640171a 100644
--- a/gnu/packages/cpp.scm
+++ b/gnu/packages/cpp.scm
@@ -807,3 +807,27 @@ code will be mixed in with the actual programming logic. This implementation
provides a number of utilities to make coding with expected cleaner.")
(home-page "https://tl.tartanllama.xyz/")
(license license:cc0)))
+
+(define-public magic-enum
+ (package
+ (name "magic-enum")
+ (version "0.7.2")
+ (home-page "https://github.com/Neargye/magic_enum")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url home-page)
+ (commit (string-append "v" version))))
+ (sha256
+ (base32
+ "07j5zdf3vkliwrcv6k663k35akn7qp23794sz2mnvkj9hbv9s8cx"))
+ (file-name (git-file-name name version))))
+ (build-system cmake-build-system)
+
+ (native-inputs
+ `(("gcc" ,gcc-9)))
+ (synopsis "C++17 header only library for compile time reflection of enums")
+ (description "C++17 header only library which offers static reflection
+of enums, with to string, from string, and iteration, and relate324 d
+functionality.")
+ (license license:expat)))
--
2.30.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* bug#45604: [PATCH] gnu: Add magic-enum.
2021-01-20 4:09 ` [bug#45604] [PATCH] gnu: Add magic-enum Anadon
@ 2021-01-20 8:14 ` Leo Prikler
0 siblings, 0 replies; 8+ messages in thread
From: Leo Prikler @ 2021-01-20 8:14 UTC (permalink / raw)
To: Anadon, 45604-done
Pushed with some slight changes in the description. Thanks!
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-01-20 8:15 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-02 0:51 [bug#45604] [PATCH 0/1] Add magic-enum package Anadon
2021-01-02 0:51 ` [bug#45604] [PATCH 1/1] Added magic-enum header-only library as a package Anadon
2021-01-04 13:06 ` Leo Prikler
2021-01-04 21:59 ` Josh Marshall
2021-01-05 20:39 ` Leo Prikler
2021-01-09 7:51 ` [bug#45604] [PATCH 0/2] " Leo Prikler
2021-01-20 4:09 ` [bug#45604] [PATCH] gnu: Add magic-enum Anadon
2021-01-20 8:14 ` bug#45604: " Leo Prikler
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).