From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id GNNVGSuQ81/5VwAA0tVLHw (envelope-from ) for ; Mon, 04 Jan 2021 22:01:15 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 6PwUFSuQ81+1MQAAbx9fmQ (envelope-from ) for ; Mon, 04 Jan 2021 22:01:15 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1537294062D for ; Mon, 4 Jan 2021 22:01:15 +0000 (UTC) Received: from localhost ([::1]:43036 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kwXuc-0004FI-1D for larch@yhetil.org; Mon, 04 Jan 2021 17:01:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:39914) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kwXuQ-0004Er-K9 for guix-patches@gnu.org; Mon, 04 Jan 2021 17:01:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:48924) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kwXuP-00047C-Un for guix-patches@gnu.org; Mon, 04 Jan 2021 17:01:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kwXuP-0007J9-T5 for guix-patches@gnu.org; Mon, 04 Jan 2021 17:01:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45604] [PATCH 1/1] Added magic-enum header-only library as a package. Resent-From: Josh Marshall Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 04 Jan 2021 22:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45604 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Prikler Received: via spool by 45604-submit@debbugs.gnu.org id=B45604.160979760327953 (code B ref 45604); Mon, 04 Jan 2021 22:01:01 +0000 Received: (at 45604) by debbugs.gnu.org; 4 Jan 2021 22:00:03 +0000 Received: from localhost ([127.0.0.1]:60470 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwXtS-0007Gd-70 for submit@debbugs.gnu.org; Mon, 04 Jan 2021 17:00:03 -0500 Received: from mail-vk1-f171.google.com ([209.85.221.171]:41921) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwXtP-0007Fm-I5 for 45604@debbugs.gnu.org; Mon, 04 Jan 2021 17:00:00 -0500 Received: by mail-vk1-f171.google.com with SMTP id a6so6515575vkb.8 for <45604@debbugs.gnu.org>; Mon, 04 Jan 2021 13:59:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OqGm3/v4CZgnhUotuD4PYf/QvfotMS6qNM7g51UEG9I=; b=FXpELCk3nXh40/sQD05rbu6Vmo3+lfGJeTZ15kQbFdty3Bup6yOWFXoYO7u9KRRBoL oTo6+w8lCPrPOSJVosqCYaEJnKLy1JirXJ+1Zkxq75g8VH2n8qSS5ij8ySLt/X9JetxQ XS3nWw55AHhOtWqd2jsJHqqdJTmYBpYjzwKpXeeyWRzVTwJ06xBAy/imapA4o1U91JjO dIx8Kfrl5vgULN8eHYsZxtGalDM9TlVOD1TwK6L8Ke1xcxOuYgCOfav4Jx+Wp/5ADqWh H7y6lLhkCT/J34k9MLKwm2mi7nQb7tYJ2qp+zcyRIuK4A93pYCcXkSBDoH59qg1utYsS 6c8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OqGm3/v4CZgnhUotuD4PYf/QvfotMS6qNM7g51UEG9I=; b=rFq54eotLKetnksNR+iGi4rO2XZepmjutLISsVpNo7kHkQpUDKRBuOxGC1tYF4lJWM fA3HF/L7DKCxUilyaUDyIkZnegui0mQGgGZk7FqM8H+1Ecn1SC7re044lTWWzjHcitmd fU7VxVQdo57eC80T9yD0LQ0lnv4OnMGo5A4S0Vi15HBAT0Unij03M0sdGMcIZSO+yrR6 E9oWyME9xGifDhlUejsX4gvHiI9JSJa4679jZXozbvNkX49vmKSxm37b7aAV44IL+ISr 7Ivzv2FoxNxVWVuyC6LW/eFnoxeBx7Hg+XJ4IreXQWERVcAu2Lv7qPvnJuA5GMAoV9p/ LVlA== X-Gm-Message-State: AOAM532oH9jWWGethGNLJ+vja+EfnQbg9IlyeTJbWFCjgGB/4WDOV6dj ufOfRCMLFaR+GtJoyGMYaEup3Bivs7dH9bFBm9BWXiTH+EY= X-Google-Smtp-Source: ABdhPJxrO6LuqYbRb4cVspllBpKnVRxuLj7DZphTaYy9Wunq/DdBGfr2q1cj9aEhnVOTpd3cd6l4xf81nmMAzFSGEhU= X-Received: by 2002:a1f:9409:: with SMTP id w9mr20812636vkd.8.1609797593789; Mon, 04 Jan 2021 13:59:53 -0800 (PST) MIME-Version: 1.0 References: <20210102005145.582428-1-joshua.r.marshall.1991@gmail.com> <20210102005145.582428-2-joshua.r.marshall.1991@gmail.com> <678c89426254d320a0962d8c47d88b29aa754b03.camel@student.tugraz.at> In-Reply-To: <678c89426254d320a0962d8c47d88b29aa754b03.camel@student.tugraz.at> From: Josh Marshall Date: Mon, 4 Jan 2021 16:59:42 -0500 Message-ID: Content-Type: multipart/alternative; boundary="000000000000bcf95f05b81a358f" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45604@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.23 Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=gmail.com header.s=20161025 header.b=FXpELCk3; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 1537294062D X-Spam-Score: -1.23 X-Migadu-Scanner: scn1.migadu.com X-TUID: DmuAGmbeIDCy --000000000000bcf95f05b81a358f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sorry, one more thing I missed in the documentation was the waiting period. The commit message missing is probably a misconfiguration. I can change to gcc-9, I just defaulted to the newest since the default was too old. That description is a verbatim copy of their description. I'll fix these up, then issue another patch series. On Mon, Jan 4, 2021 at 8:06 AM Leo Prikler wrote: > Hello Anadon, > > I have not yet built your package (because I'm currently also handling > another patch), but since you've requested review over at guix-devel, > I'll have a go at it. > For the future please note, that a delay of 2 days does not mean we > haven't noticed you at all. The manual has the following to say for > committers: > > For anything else, please post to and leave > > time for a review, without committing anything (*note Submitting > > Patches::). If you didn=E2=80=99t receive any reply after two weeks, a= nd if > > you=E2=80=99re confident, it=E2=80=99s OK to commit. > > Am Freitag, den 01.01.2021, 19:51 -0500 schrieb Anadon: > > From: Josh Marshall > Ehh, somehow the commit message and everything is missing here. Is > that intended or just misconfigured? > > > --- > > gnu/packages/cpp.scm | 24 ++++++++++++++++++++++++ > > 1 file changed, 24 insertions(+) > > > > diff --git a/gnu/packages/cpp.scm b/gnu/packages/cpp.scm > > index 00e006928e..ff10a4247b 100644 > > --- a/gnu/packages/cpp.scm > > +++ b/gnu/packages/cpp.scm > > @@ -807,3 +807,27 @@ code will be mixed in with the actual > > programming logic. This implementation > > provides a number of utilities to make coding with expected > > cleaner.") > > (home-page "https://tl.tartanllama.xyz/") > > (license license:cc0))) > > + > > +(define-public magic-enum > > + (package > > + (name "magic-enum") > > + (version "0.7.2") > > + (home-page "https://github.com/Neargye/magic_enum") > > + (source (origin > > + (method git-fetch) > > + (uri (git-reference > > + (url home-page) > > + (commit (string-append "v" version)))) > > + (sha256 > > + (base32 > > + "0fmkyh1srkz2bx68agfa30sankg1ig1f95xqp8sp9wj3p9qil > > sv2")) > > + (modules '((guix build utils))))) > > + (build-system cmake-build-system) > > + > > + (inputs > > + `(("gcc" ,gcc-10))) > The home-page claims, that it works with GCC>=3D9. Have you encountered > any issues with gcc-9 instead? > > + (synopsis "Header-only C++17 library for reflection for > > enums") > I feel as though that could be worded better. > > + (description "Static reflection for enums (to string, from > > string, > > +iteration) for modern C++, work with any enum type without any macro > > or > > +boilerplate code") > Descriptions should be complete sentences and end with a period. > > + (license license:expat))) > > Regards, > Leo > > --000000000000bcf95f05b81a358f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Sorry, one more thing I missed in the documentation w= as the waiting period.=C2=A0 The commit message missing is probably a misco= nfiguration.=C2=A0 I can change to gcc-9, I just defaulted to the newest si= nce the default was too old.=C2=A0 That description is a verbatim copy of t= heir description.

I'll fix these up, then issu= e another patch series.






<= br>
On Mon,= Jan 4, 2021 at 8:06 AM Leo Prikler <leo.prikler@student.tugraz.at> wrote:
Hello Anadon,

I have not yet built your package (because I'm currently also handling<= br> another patch), but since you've requested review over at guix-devel, I'll have a go at it.
For the future please note, that a delay of 2 days does not mean we
haven't noticed you at all.=C2=A0 The manual has the following to say f= or
committers:
> For anything else, please post to <guix-patches@gnu.org> and leave
> time for a review, without committing anything (*note Submitting
> Patches::).=C2=A0 If you didn=E2=80=99t receive any reply after two we= eks, and if
> you=E2=80=99re confident, it=E2=80=99s OK to commit.

Am Freitag, den 01.01.2021, 19:51 -0500 schrieb Anadon:
> From: Josh Marshall <joshua.r.marshall.1991@gmail.com>
Ehh, somehow the commit message and everything is missing here.=C2=A0 Is that intended or just misconfigured?

> ---
>=C2=A0 gnu/packages/cpp.scm | 24 ++++++++++++++++++++++++
>=C2=A0 1 file changed, 24 insertions(+)
>
> diff --git a/gnu/packages/cpp.scm b/gnu/packages/cpp.scm
> index 00e006928e..ff10a4247b 100644
> --- a/gnu/packages/cpp.scm
> +++ b/gnu/packages/cpp.scm
> @@ -807,3 +807,27 @@ code will be mixed in with the actual
> programming logic.=C2=A0 This implementation
>=C2=A0 provides a number of utilities to make coding with expected
> cleaner.")
>=C2=A0 =C2=A0 =C2=A0 (home-page "https://tl.tartanllama.xyz/= ")
>=C2=A0 =C2=A0 =C2=A0 (license license:cc0)))
> +
> +(define-public magic-enum
> +=C2=A0 =C2=A0 (package
> +=C2=A0 =C2=A0 =C2=A0 (name "magic-enum")
> +=C2=A0 =C2=A0 =C2=A0 (version "0.7.2")
> +=C2=A0 =C2=A0 =C2=A0 (home-page "https://github.com/= Neargye/magic_enum")
> +=C2=A0 =C2=A0 =C2=A0 (source (origin
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (method git-f= etch)
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (uri (git-ref= erence
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 (url home-page)
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 (commit (string-append "v" version))))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (sha256
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(base32=
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "= 0fmkyh1srkz2bx68agfa30sankg1ig1f95xqp8sp9wj3p9qil
> sv2"))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (modules '= ;((guix build utils)))))
> +=C2=A0 =C2=A0 =C2=A0 (build-system cmake-build-system)
> +
> +=C2=A0 =C2=A0 =C2=A0 (inputs
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0`(("gcc" ,gcc-10)))
The home-page claims, that it works with GCC>=3D9.=C2=A0 Have you encoun= tered
any issues with gcc-9 instead?
> +=C2=A0 =C2=A0 =C2=A0 (synopsis "Header-only C++17 library for re= flection for
> enums")
I feel as though that could be worded better.
> +=C2=A0 =C2=A0 =C2=A0 (description "Static reflection for enums (= to string, from
> string,
> +iteration) for modern C++, work with any enum type without any macro<= br> > or
> +boilerplate code")
Descriptions should be complete sentences and end with a period.
> +=C2=A0 =C2=A0 =C2=A0 (license license:expat)))

Regards,
Leo

--000000000000bcf95f05b81a358f--