From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id Jq6fKK3O9F9vSQAA0tVLHw (envelope-from ) for ; Tue, 05 Jan 2021 20:40:13 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 8tv7I63O9F9YEwAAbx9fmQ (envelope-from ) for ; Tue, 05 Jan 2021 20:40:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1D7EC9402A0 for ; Tue, 5 Jan 2021 20:40:12 +0000 (UTC) Received: from localhost ([::1]:53956 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kwt7j-0002es-Ud for larch@yhetil.org; Tue, 05 Jan 2021 15:40:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42562) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kwt7c-0002eY-33 for guix-patches@gnu.org; Tue, 05 Jan 2021 15:40:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:59458) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kwt7a-000232-LY for guix-patches@gnu.org; Tue, 05 Jan 2021 15:40:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kwt7a-000631-HY for guix-patches@gnu.org; Tue, 05 Jan 2021 15:40:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45604] [PATCH 1/1] Added magic-enum header-only library as a package. Resent-From: Leo Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 05 Jan 2021 20:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45604 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Josh Marshall Received: via spool by 45604-submit@debbugs.gnu.org id=B45604.160987918823213 (code B ref 45604); Tue, 05 Jan 2021 20:40:02 +0000 Received: (at 45604) by debbugs.gnu.org; 5 Jan 2021 20:39:48 +0000 Received: from localhost ([127.0.0.1]:42771 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwt7M-00062K-Bi for submit@debbugs.gnu.org; Tue, 05 Jan 2021 15:39:48 -0500 Received: from mailrelay.tugraz.at ([129.27.2.202]:27403) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwt7J-000626-E0 for 45604@debbugs.gnu.org; Tue, 05 Jan 2021 15:39:46 -0500 Received: from nijino.local (217-149-174-13.nat.highway.telekom.at [217.149.174.13]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4D9PW15pSwz3x8T; Tue, 5 Jan 2021 21:39:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1609879182; bh=S551WK9/3TjvvJR6C8lj1AAdKdM+uO2EMn0W5jtb098=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=M1qHXeXssBsjHzL/NIIGToffctCpmy5YRAOZFpnfYUPtMv+4xVtjUXdU0dg1Dv2+a rFw6c/0XJuFnky0g8hMlrCQOqImLKLNLVfZ5VYN/srdNZi7xzhUsn1JSVw1QFpFzu5 /6qHMDPaoiPWWigAjzotNj3q2sBZexo85kNPa5uQ= Message-ID: <7c5a8335d41424b10c950d6dd5f20adb16a4bbfb.camel@student.tugraz.at> From: Leo Prikler Date: Tue, 05 Jan 2021 21:39:40 +0100 In-Reply-To: References: <20210102005145.582428-1-joshua.r.marshall.1991@gmail.com> <20210102005145.582428-2-joshua.r.marshall.1991@gmail.com> <678c89426254d320a0962d8c47d88b29aa754b03.camel@student.tugraz.at> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45604@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.24 Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=tugraz.at header.s=mailrelay header.b=M1qHXeXs; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 1D7EC9402A0 X-Spam-Score: -1.24 X-Migadu-Scanner: scn0.migadu.com X-TUID: koFtZ311SF5S Hello Josh, Am Montag, den 04.01.2021, 16:59 -0500 schrieb Josh Marshall: > Sorry, one more thing I missed in the documentation was the waiting > period. The commit message missing is probably a misconfiguration. > I can change to gcc-9, I just defaulted to the newest since the > default was too old. That description is a verbatim copy of their > description. W.r.t. the description you should probably come up with words of your own. The upstream one doesn't appear all that usable. For the record, gcc should likely also be a native-input, given that it'll be used for compilation and testing. > I'll fix these up, then issue another patch series. Don't forget to set --to, --cc and --reroll-count when you do ;) Otherwise you might inadvertently open up new issues which will at least confuse the bug tracker. Regards, Leo > On Mon, Jan 4, 2021 at 8:06 AM Leo Prikler < > leo.prikler@student.tugraz.at> wrote: > > Hello Anadon, > > > > I have not yet built your package (because I'm currently also > > handling > > another patch), but since you've requested review over at guix- > > devel, > > I'll have a go at it. > > For the future please note, that a delay of 2 days does not mean we > > haven't noticed you at all. The manual has the following to say > > for > > committers: > > > For anything else, please post to and > > leave > > > time for a review, without committing anything (*note Submitting > > > Patches::). If you didn’t receive any reply after two weeks, and > > if > > > you’re confident, it’s OK to commit. > > > > Am Freitag, den 01.01.2021, 19:51 -0500 schrieb Anadon: > > > From: Josh Marshall > > Ehh, somehow the commit message and everything is missing here. Is > > that intended or just misconfigured? > > > > > --- > > > gnu/packages/cpp.scm | 24 ++++++++++++++++++++++++ > > > 1 file changed, 24 insertions(+) > > > > > > diff --git a/gnu/packages/cpp.scm b/gnu/packages/cpp.scm > > > index 00e006928e..ff10a4247b 100644 > > > --- a/gnu/packages/cpp.scm > > > +++ b/gnu/packages/cpp.scm > > > @@ -807,3 +807,27 @@ code will be mixed in with the actual > > > programming logic. This implementation > > > provides a number of utilities to make coding with expected > > > cleaner.") > > > (home-page "https://tl.tartanllama.xyz/") > > > (license license:cc0))) > > > + > > > +(define-public magic-enum > > > + (package > > > + (name "magic-enum") > > > + (version "0.7.2") > > > + (home-page "https://github.com/Neargye/magic_enum") > > > + (source (origin > > > + (method git-fetch) > > > + (uri (git-reference > > > + (url home-page) > > > + (commit (string-append "v" version)))) > > > + (sha256 > > > + (base32 > > > + > > "0fmkyh1srkz2bx68agfa30sankg1ig1f95xqp8sp9wj3p9qil > > > sv2")) > > > + (modules '((guix build utils))))) > > > + (build-system cmake-build-system) > > > + > > > + (inputs > > > + `(("gcc" ,gcc-10))) > > The home-page claims, that it works with GCC>=9. Have you > > encountered > > any issues with gcc-9 instead? > > > + (synopsis "Header-only C++17 library for reflection for > > > enums") > > I feel as though that could be worded better. > > > + (description "Static reflection for enums (to string, from > > > string, > > > +iteration) for modern C++, work with any enum type without any > > macro > > > or > > > +boilerplate code") > > Descriptions should be complete sentences and end with a period. > > > + (license license:expat))) > > > > Regards, > > Leo > >