unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Prikler <leo.prikler@student.tugraz.at>
To: joshua.r.marshall.1991@gmail.com
Cc: 45604@debbugs.gnu.org
Subject: [bug#45604] [PATCH 0/2] Added magic-enum header-only library as a package.
Date: Sat, 09 Jan 2021 08:51:57 +0100	[thread overview]
Message-ID: <734fefc52faea2d05b562f823dcc844696d7aed1.camel@student.tugraz.at> (raw)
In-Reply-To: 20210109024058.68902-1-joshua.r.marshall.1991@gmail.com

Hello Anadon,

three nitpicks:
1. You should squash the changes into the original commit.
2. The commit message(s) is/are still missing.
3. Please pick one name for your contributions.

Otherwise LGTM,
Leo





  parent reply	other threads:[~2021-01-09  7:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-02  0:51 [bug#45604] [PATCH 0/1] Add magic-enum package Anadon
2021-01-02  0:51 ` [bug#45604] [PATCH 1/1] Added magic-enum header-only library as a package Anadon
2021-01-04 13:06   ` Leo Prikler
2021-01-04 21:59     ` Josh Marshall
2021-01-05 20:39       ` Leo Prikler
2021-01-09  7:51 ` Leo Prikler [this message]
2021-01-20  4:09 ` [bug#45604] [PATCH] gnu: Add magic-enum Anadon
2021-01-20  8:14   ` bug#45604: " Leo Prikler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=734fefc52faea2d05b562f823dcc844696d7aed1.camel@student.tugraz.at \
    --to=leo.prikler@student.tugraz.at \
    --cc=45604@debbugs.gnu.org \
    --cc=joshua.r.marshall.1991@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).