From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id wM6WEQUT818lWwAA0tVLHw (envelope-from ) for ; Mon, 04 Jan 2021 13:07:17 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id cKNrDQUT81+EEgAAB5/wlQ (envelope-from ) for ; Mon, 04 Jan 2021 13:07:17 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A0D369406A1 for ; Mon, 4 Jan 2021 13:07:16 +0000 (UTC) Received: from localhost ([::1]:45188 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kwPZp-0005OL-SM for larch@yhetil.org; Mon, 04 Jan 2021 08:07:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54812) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kwPZf-0005Mi-4K for guix-patches@gnu.org; Mon, 04 Jan 2021 08:07:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:46552) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kwPZe-00064F-Rb for guix-patches@gnu.org; Mon, 04 Jan 2021 08:07:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kwPZe-0003LG-J1 for guix-patches@gnu.org; Mon, 04 Jan 2021 08:07:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45604] [PATCH 1/1] Added magic-enum header-only library as a package. Resent-From: Leo Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 04 Jan 2021 13:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45604 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Anadon Received: via spool by 45604-submit@debbugs.gnu.org id=B45604.160976558112799 (code B ref 45604); Mon, 04 Jan 2021 13:07:02 +0000 Received: (at 45604) by debbugs.gnu.org; 4 Jan 2021 13:06:21 +0000 Received: from localhost ([127.0.0.1]:58098 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwPYz-0003KN-HX for submit@debbugs.gnu.org; Mon, 04 Jan 2021 08:06:21 -0500 Received: from mailrelay.tugraz.at ([129.27.2.202]:23926) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwPYx-0003KC-68 for 45604@debbugs.gnu.org; Mon, 04 Jan 2021 08:06:20 -0500 Received: from nijino.local (217-149-174-13.nat.highway.telekom.at [217.149.174.13]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4D8bVH3PHLz3wMF; Mon, 4 Jan 2021 14:06:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1609765575; bh=TVd8vIT5vBYvompx2B50lgMIBGvUrdhQAgd1KrE/PIU=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=l8jtN9oFkybipYPAtySoYXLm1yOwsc9v8NyzL481cs09dNUBxyfuCnar5eXA3Kg/y mCs0tX7j/NBVxwBg3OFM26YOsxJovkjXltaMrfWKHuctAPFBnNrHrv3gHlTkTIN9qm Q//3/OqqR3SKkoln5+BgAQbQdAw8iG0UopD7eS7k= Message-ID: <678c89426254d320a0962d8c47d88b29aa754b03.camel@student.tugraz.at> From: Leo Prikler Date: Mon, 04 Jan 2021 14:06:14 +0100 In-Reply-To: <20210102005145.582428-2-joshua.r.marshall.1991@gmail.com> References: <20210102005145.582428-1-joshua.r.marshall.1991@gmail.com> <20210102005145.582428-2-joshua.r.marshall.1991@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45604@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.23 Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=tugraz.at header.s=mailrelay header.b=l8jtN9oF; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: A0D369406A1 X-Spam-Score: -1.23 X-Migadu-Scanner: scn0.migadu.com X-TUID: 5FFET+C1p5x6 Hello Anadon, I have not yet built your package (because I'm currently also handling another patch), but since you've requested review over at guix-devel, I'll have a go at it. For the future please note, that a delay of 2 days does not mean we haven't noticed you at all. The manual has the following to say for committers: > For anything else, please post to and leave > time for a review, without committing anything (*note Submitting > Patches::). If you didn’t receive any reply after two weeks, and if > you’re confident, it’s OK to commit. Am Freitag, den 01.01.2021, 19:51 -0500 schrieb Anadon: > From: Josh Marshall Ehh, somehow the commit message and everything is missing here. Is that intended or just misconfigured? > --- > gnu/packages/cpp.scm | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/gnu/packages/cpp.scm b/gnu/packages/cpp.scm > index 00e006928e..ff10a4247b 100644 > --- a/gnu/packages/cpp.scm > +++ b/gnu/packages/cpp.scm > @@ -807,3 +807,27 @@ code will be mixed in with the actual > programming logic. This implementation > provides a number of utilities to make coding with expected > cleaner.") > (home-page "https://tl.tartanllama.xyz/") > (license license:cc0))) > + > +(define-public magic-enum > + (package > + (name "magic-enum") > + (version "0.7.2") > + (home-page "https://github.com/Neargye/magic_enum") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url home-page) > + (commit (string-append "v" version)))) > + (sha256 > + (base32 > + "0fmkyh1srkz2bx68agfa30sankg1ig1f95xqp8sp9wj3p9qil > sv2")) > + (modules '((guix build utils))))) > + (build-system cmake-build-system) > + > + (inputs > + `(("gcc" ,gcc-10))) The home-page claims, that it works with GCC>=9. Have you encountered any issues with gcc-9 instead? > + (synopsis "Header-only C++17 library for reflection for > enums") I feel as though that could be worded better. > + (description "Static reflection for enums (to string, from > string, > +iteration) for modern C++, work with any enum type without any macro > or > +boilerplate code") Descriptions should be complete sentences and end with a period. > + (license license:expat))) Regards, Leo