unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#28398] Xfburn
@ 2017-09-09 14:15 ng0
  2017-09-15 11:41 ` ng0
  2017-09-30 15:14 ` Christopher Baines
  0 siblings, 2 replies; 17+ messages in thread
From: ng0 @ 2017-09-09 14:15 UTC (permalink / raw)
  To: 28398


[-- Attachment #1.1: Type: text/plain, Size: 332 bytes --]

This adds Xfburn + 2 libburnia packages it depends on.

What I could not test was actually burning a disk,
as I can't afford to buy new optical disks at the moment.

It builds.
-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://n0is.noblogs.org/my-keys
https://www.infotropique.org https://krosos.org

[-- Attachment #1.2: 0001-gnu-Add-libburn.patch --]
[-- Type: text/plain, Size: 2142 bytes --]

From 512f0217741a18eb66dd92cecab556118bcc8928 Mon Sep 17 00:00:00 2001
From: ng0 <ng0@infotropique.org>
Date: Sat, 9 Sep 2017 13:47:31 +0000
Subject: [PATCH 1/3] gnu: Add libburn.

* gnu/packages/cdrom.scm (libburn): New variable.
---
 gnu/packages/cdrom.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/cdrom.scm b/gnu/packages/cdrom.scm
index 704e8ad36..478685a24 100644
--- a/gnu/packages/cdrom.scm
+++ b/gnu/packages/cdrom.scm
@@ -8,6 +8,7 @@
 ;;; Copyright © 2016 Marius Bakke <mbakke@fastmail.com>
 ;;; Copyright © 2017 John Darrington <jmd@gnu.org>
 ;;; Copyright © 2017 Thomas Danckaert <post@thomasdanckaert.be>
+;;; Copyright © 2017 ng0 <ng0@infotropique.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -693,3 +694,30 @@ distributed with CD images and are used to describe how tracks are
 laid out on the image.")
     (home-page "https://www.gnu.org/software/ccd2cue/")
     (license gpl3+)))
+
+(define-public libburn
+  (package
+    (name "libburn")
+    (version "1.4.6")
+    (source (origin
+             (method url-fetch)
+             (uri (string-append "http://files.libburnia-project.org/releases/"
+                                 "libburn-" version ".tar.gz"))
+             (sha256
+              (base32
+               "0wbh49s3az3sfpai09z1zdgynq7wnwrk31v5589033274nmzldlx"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:configure-flags (list "--enable-libcdio")))
+    (inputs
+     `(("libcdio" ,libcdio)))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+    (home-page "https://dev.lovelyhq.com/libburnia/libburn")
+    (synopsis "library for reading, mastering and writing optical discs")
+    (description
+     "libburn is the library by which preformatted data get onto optical media.
+It uses either @file{/dev/sgN} (e.g. on kernel 2.4 with ide-scsi) or @file{/dev/srM}
+or @file{/dev/hdX} (e.g. on kernel 2.6).  libburn is the foundation of the
+libburnia-project cdrecord emulation.  Its code is independent of cdrecord.")
+    (license gpl2)))
-- 
2.14.1


[-- Attachment #1.3: 0002-gnu-Add-libisofs.patch --]
[-- Type: text/plain, Size: 1978 bytes --]

From 00eb5b67c78fe8e15d3e03ff4ff450d106fad690 Mon Sep 17 00:00:00 2001
From: ng0 <ng0@infotropique.org>
Date: Sat, 9 Sep 2017 13:59:39 +0000
Subject: [PATCH 2/3] gnu: Add libisofs.

* gnu/packages/cdrom.scm (libisofs): New variable.
---
 gnu/packages/cdrom.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/cdrom.scm b/gnu/packages/cdrom.scm
index 478685a24..5b387f107 100644
--- a/gnu/packages/cdrom.scm
+++ b/gnu/packages/cdrom.scm
@@ -721,3 +721,30 @@ It uses either @file{/dev/sgN} (e.g. on kernel 2.4 with ide-scsi) or @file{/dev/
 or @file{/dev/hdX} (e.g. on kernel 2.6).  libburn is the foundation of the
 libburnia-project cdrecord emulation.  Its code is independent of cdrecord.")
     (license gpl2)))
+
+(define-public libisofs
+  (package
+    (name "libisofs")
+    (version "1.4.6")
+    (source (origin
+             (method url-fetch)
+             (uri (string-append "http://files.libburnia-project.org/releases/"
+                                 "libisofs-" version ".tar.gz"))
+             (sha256
+              (base32
+               "02m5g6lbmmkh2xc5xzq5zaf3ma6v31gls66aj886b3cq9qw0paql"))))
+    (build-system gnu-build-system)
+    (inputs
+     `(("zlib" ,zlib)))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+    (home-page "https://dev.lovelyhq.com/libburnia/libisofs")
+    (synopsis "library for reading, mastering and writing optical discs")
+    (description
+     "libisofs is a library to create an ISO-9660 filesystem, supports extensions
+like RockRidge or Joliet, and introduces an own extension AAIP.  It is a full
+featured ISO-9660 editor which composes and changes the directory tree of an
+ISO image.  This tree and its newly imported data file contents get then
+written as independent single-session image or as add-on session for the image
+from where the tree was originally loaded.")
+    (license gpl2+)))
-- 
2.14.1


[-- Attachment #1.4: 0003-gnu-Add-xfburn.patch --]
[-- Type: text/plain, Size: 2589 bytes --]

From aeca4ac117bf66aae4656d311e39135f29d24fab Mon Sep 17 00:00:00 2001
From: ng0 <ng0@infotropique.org>
Date: Sat, 9 Sep 2017 14:11:36 +0000
Subject: [PATCH 3/3] gnu: Add xfburn.

* gnu/packages/xfce.scm (xfburn): New variable.
---
 gnu/packages/xfce.scm | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index b936dc45d..03d8c79b6 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -6,6 +6,7 @@
 ;;; Copyright © 2016 Kei Kebreau <kkebreau@posteo.net>
 ;;; Copyright © 2017 Ricardo Wurmus <rekado@elephly.net>
 ;;; Copyright © 2017 Petter <petter@mykolab.ch>
+;;; Copyright © 2017 ng0 <ng0@infotropique.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -32,6 +33,7 @@
   #:use-module (guix build-system trivial)
   #:use-module (gnu packages)
   #:use-module (gnu packages calendar)
+  #:use-module (gnu packages cdrom)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages glib)
   #:use-module (gnu packages gtk)
@@ -902,3 +904,37 @@ bubble in a standard way can implicitly make use of xfce4-notifyd to do so by
 sending standard messages over D-Bus using the
 @code{org.freedesktop.Notifications} interface.")
     (license gpl2)))
+
+(define-public xfburn
+  (package
+    (name "xfburn")
+    (version "0.5.4")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "http://archive.xfce.org/src/apps/xfburn/"
+                                  (version-major+minor version) "/"
+                                  name "-" version ".tar.bz2"))
+              (sha256
+               (base32
+                "1xn1kwxa3dl5r9bfj90a5322ynkwbn6k5v9b3a3pbr3a23zm604s"))))
+    (build-system gnu-build-system)
+    (native-inputs
+     `(("intltool" ,intltool)
+       ("pkg-config" ,pkg-config)))
+    (inputs
+     `(("exo" ,exo)
+       ("gstreamer" ,gstreamer)
+       ("gst-plugins-base" ,gst-plugins-base)
+       ("glib" ,glib)
+       ("gtk+" ,gtk+-2)
+       ("libburn" ,libburn)
+       ("libisofs" ,libisofs)
+       ("libxfce4ui" ,libxfce4ui)))
+    (home-page "https://goodies.xfce.org/projects/applications/xfburn")
+    (synopsis "GTK+ based CD and DVD burning application")
+    (description
+     "Xfburn is a simple CD/DVD burning tool based on libburnia
+libraries.  It can blank CD/DVD(-RW)s, burn and create iso images,
+audio CDs, as well as burn personal compositions of data to either
+CD or DVD.")
+    (license gpl2+)))
-- 
2.14.1


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [bug#28398] Xfburn
  2017-09-09 14:15 [bug#28398] Xfburn ng0
@ 2017-09-15 11:41 ` ng0
  2017-09-30 15:14 ` Christopher Baines
  1 sibling, 0 replies; 17+ messages in thread
From: ng0 @ 2017-09-15 11:41 UTC (permalink / raw)
  To: 28398

[-- Attachment #1: Type: text/plain, Size: 452 bytes --]

ng0 transcribed 8.5K bytes:
> This adds Xfburn + 2 libburnia packages it depends on.
> 
> What I could not test was actually burning a disk,
> as I can't afford to buy new optical disks at the moment.
> 
> It builds.

Update: I just found some disks, I could test functionality
this weekend.
-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://krosos.org/dist/keys/
https://www.infotropique.org https://www.krosos.org

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 17+ messages in thread

* [bug#28398] Xfburn
  2017-09-09 14:15 [bug#28398] Xfburn ng0
  2017-09-15 11:41 ` ng0
@ 2017-09-30 15:14 ` Christopher Baines
  2017-09-30 15:33   ` ng0
  1 sibling, 1 reply; 17+ messages in thread
From: Christopher Baines @ 2017-09-30 15:14 UTC (permalink / raw)
  To: ng0; +Cc: 28398

[-- Attachment #1: Type: text/plain, Size: 2763 bytes --]

On Sat, 9 Sep 2017 14:15:04 +0000
ng0 <ng0@infotropique.org> wrote:

> This adds Xfburn + 2 libburnia packages it depends on.
> 
> What I could not test was actually burning a disk,
> as I can't afford to buy new optical disks at the moment.
> 
> It builds.

It builds for me too :)

Looking at the libburn package.

> +    (synopsis "library for reading, mastering and writing optical
> discs")

guix lint says:

gnu/packages/cdrom.scm:717:14: libburn@1.4.6: synopsis should start
with an upper-case letter or digit

> +    (description
> +     "libburn is the library by which preformatted data get onto optical media.
> +It uses either @file{/dev/sgN} (e.g. on kernel 2.4 with ide-scsi) or @file{/dev/srM}
> +or @file{/dev/hdX} (e.g. on kernel 2.6).  libburn is the foundation of the
> +libburnia-project cdrecord emulation.  Its code is independent of cdrecord.")

I'm unsure about the first sentence, "libburn is the library" makes it
sounds like there is only one library (this one) that does this. Would
something like "libburn is a library to write preformatted data to
optical media" work?

Also, I don't get the cdrecord reference at the end.

Looking at the libisofs package.

> +    (synopsis "library for reading, mastering and writing optical discs")

guix lint says:

gnu/packages/cdrom.scm:742:14: libisofs@1.4.6: synopsis should start
with an upper-case letter or digit

Also, this is the same as the libburn package, which probably means
they need tweaking to be more useful.

> +    (description
> +     "libisofs is a library to create an ISO-9660 filesystem, supports extensions

I think this would read better split in to two sentences, as in "...
filesystem.  It supports"

> +like RockRidge or Joliet, and introduces an own extension AAIP.  It is a full

I think this would read better if you swap out "an" for "its".

> +featured ISO-9660 editor which composes and changes the directory tree of an
> +ISO image.  This tree and its newly imported data file contents get then

I think this would read better if you swap the order of "get" and
"then", as in "imported data file contents then get".

Looking finally at the xfburn package.

The description seems a bit odd to me, as things like blanking CDs, or
compositions are not terms I've heard commonly, but I think this is ok.

I had some broken icons when I tried running this, and got some
corresponding warnings, but this could be because I'm using Gnome and
not XFCE.

(xfburn:15797): Gtk-WARNING **: Error loading theme icon
'stock_xfburn-audio-cd' for stock: Icon 'stock_xfburn-audio-cd' not
present in theme


Thanks for the patches, and let me know if the proofreading the
descriptions is helpful?	

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 963 bytes --]

^ permalink raw reply	[flat|nested] 17+ messages in thread

* [bug#28398] Xfburn
  2017-09-30 15:14 ` Christopher Baines
@ 2017-09-30 15:33   ` ng0
  2017-09-30 17:33     ` Christopher Baines
  0 siblings, 1 reply; 17+ messages in thread
From: ng0 @ 2017-09-30 15:33 UTC (permalink / raw)
  To: Christopher Baines; +Cc: 28398

[-- Attachment #1: Type: text/plain, Size: 3615 bytes --]

Christopher Baines transcribed 3.8K bytes:
> On Sat, 9 Sep 2017 14:15:04 +0000
> ng0 <ng0@infotropique.org> wrote:
> 
> > This adds Xfburn + 2 libburnia packages it depends on.
> > 
> > What I could not test was actually burning a disk,
> > as I can't afford to buy new optical disks at the moment.
> > 
> > It builds.
> 
> It builds for me too :)
> 
> Looking at the libburn package.
> 
> > +    (synopsis "library for reading, mastering and writing optical
> > discs")
> 
> guix lint says:
> 
> gnu/packages/cdrom.scm:717:14: libburn@1.4.6: synopsis should start
> with an upper-case letter or digit

Ok.

> > +    (description
> > +     "libburn is the library by which preformatted data get onto optical media.
> > +It uses either @file{/dev/sgN} (e.g. on kernel 2.4 with ide-scsi) or @file{/dev/srM}
> > +or @file{/dev/hdX} (e.g. on kernel 2.6).  libburn is the foundation of the
> > +libburnia-project cdrecord emulation.  Its code is independent of cdrecord.")
> 
> I'm unsure about the first sentence, "libburn is the library" makes it
> sounds like there is only one library (this one) that does this. Would
> something like "libburn is a library to write preformatted data to
> optical media" work?
> 
> Also, I don't get the cdrecord reference at the end.

Tbh I took this 1:1 from upstream. They don't really provide a good insight into
what's what as far as I remember.

> Looking at the libisofs package.
> 
> > +    (synopsis "library for reading, mastering and writing optical discs")
> 
> guix lint says:
> 
> gnu/packages/cdrom.scm:742:14: libisofs@1.4.6: synopsis should start
> with an upper-case letter or digit
> 
> Also, this is the same as the libburn package, which probably means
> they need tweaking to be more useful.
> 
> > +    (description
> > +     "libisofs is a library to create an ISO-9660 filesystem, supports extensions
> 
> I think this would read better split in to two sentences, as in "...
> filesystem.  It supports"
> 
> > +like RockRidge or Joliet, and introduces an own extension AAIP.  It is a full
> 
> I think this would read better if you swap out "an" for "its".
> 
> > +featured ISO-9660 editor which composes and changes the directory tree of an
> > +ISO image.  This tree and its newly imported data file contents get then
> 
> I think this would read better if you swap the order of "get" and
> "then", as in "imported data file contents then get".
> 
> Looking finally at the xfburn package.
> 
> The description seems a bit odd to me, as things like blanking CDs, or
> compositions are not terms I've heard commonly, but I think this is ok.
> 
> I had some broken icons when I tried running this, and got some
> corresponding warnings, but this could be because I'm using Gnome and
> not XFCE.
> 
> (xfburn:15797): Gtk-WARNING **: Error loading theme icon
> 'stock_xfburn-audio-cd' for stock: Icon 'stock_xfburn-audio-cd' not
> present in theme

Not a blocking issue (the icons) but Xfburn is not limited to Xfce,
so we should figure out which icon-set is needed.

> 
> Thanks for the patches, and let me know if the proofreading the
> descriptions is helpful?	

Well I still don't know more about burning disk application interiors.
Can you come up with better descriptions?
It is hard for me to take https://dev.lovelyhq.com/libburnia/web/wikis/home
and the descriptions linked in there and to decide what is useful.
-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://krosos.org/dist/keys/
https://www.infotropique.org https://krosos.org

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 17+ messages in thread

* [bug#28398] Xfburn
  2017-09-30 15:33   ` ng0
@ 2017-09-30 17:33     ` Christopher Baines
  2017-10-01  8:34       ` Thomas Schmitt
  0 siblings, 1 reply; 17+ messages in thread
From: Christopher Baines @ 2017-09-30 17:33 UTC (permalink / raw)
  To: ng0; +Cc: 28398

[-- Attachment #1: Type: text/plain, Size: 4181 bytes --]

On Sat, 30 Sep 2017 15:33:05 +0000
ng0 <ng0@infotropique.org> wrote:

> Christopher Baines transcribed 3.8K bytes:
> > On Sat, 9 Sep 2017 14:15:04 +0000
> > ng0 <ng0@infotropique.org> wrote:
> >   
> > Looking at the libburn package.
> >   
> > > +    (synopsis "library for reading, mastering and writing optical
> > > discs")

I think this description better fits libburnia, rather than the
specific libburn library.

Maybe something like this would be more specific:
  "The libburn library is used to write preformatted data to optical
  media"

> > > +    (description
> > > +     "libburn is the library by which preformatted data get onto
> > > optical media. +It uses either @file{/dev/sgN} (e.g. on kernel
> > > 2.4 with ide-scsi) or @file{/dev/srM} +or @file{/dev/hdX} (e.g.
> > > on kernel 2.6).  libburn is the foundation of the
> > > +libburnia-project cdrecord emulation.  Its code is independent
> > > of cdrecord.")  
> > 
> > I'm unsure about the first sentence, "libburn is the library" makes
> > it sounds like there is only one library (this one) that does this.
> > Would something like "libburn is a library to write preformatted
> > data to optical media" work?
> > 
> > Also, I don't get the cdrecord reference at the end.  
> 
> Tbh I took this 1:1 from upstream. They don't really provide a good
> insight into what's what as far as I remember.

For the description, how about:

libburn is a C library for writing to optical media, and has support
for multiple different types of media (e.g. CD, DVD and BR).

Included is the @command{cdrskin} command to burn data to CD or DVD.
@command{cdrskin} emulates the behaviour of the @{cdrecord} command,
but using the libburn library.

> > Looking at the libisofs package.
> >   
> > > +    (synopsis "library for reading, mastering and writing
> > > optical discs")  
> > 
> > guix lint says:
> > 
> > gnu/packages/cdrom.scm:742:14: libisofs@1.4.6: synopsis should start
> > with an upper-case letter or digit
> > 
> > Also, this is the same as the libburn package, which probably means
> > they need tweaking to be more useful.

For the libisofs synopsis, how about:

Library for creating ISO 9660 filesystem images

> > > +    (description
> > > +     "libisofs is a library to create an ISO-9660 filesystem,
> > > supports extensions  
> > 
> > I think this would read better split in to two sentences, as in "...
> > filesystem.  It supports"
> >   
> > > +like RockRidge or Joliet, and introduces an own extension AAIP.
> > > It is a full  
> > 
> > I think this would read better if you swap out "an" for "its".
> >   
> > > +featured ISO-9660 editor which composes and changes the
> > > directory tree of an +ISO image.  This tree and its newly
> > > imported data file contents get then  
> > 
> > I think this would read better if you swap the order of "get" and
> > "then", as in "imported data file contents then get".
> > 
> > Looking finally at the xfburn package.
> > 
> > The description seems a bit odd to me, as things like blanking CDs,
> > or compositions are not terms I've heard commonly, but I think this
> > is ok.
> > 
> > I had some broken icons when I tried running this, and got some
> > corresponding warnings, but this could be because I'm using Gnome
> > and not XFCE.
> > 
> > (xfburn:15797): Gtk-WARNING **: Error loading theme icon
> > 'stock_xfburn-audio-cd' for stock: Icon 'stock_xfburn-audio-cd' not
> > present in theme  
> 
> Not a blocking issue (the icons) but Xfburn is not limited to Xfce,
> so we should figure out which icon-set is needed.

I agree.

> > Thanks for the patches, and let me know if the proofreading the
> > descriptions is helpful?	  
> 
> Well I still don't know more about burning disk application interiors.
> Can you come up with better descriptions?
> It is hard for me to take
> https://dev.lovelyhq.com/libburnia/web/wikis/home and the
> descriptions linked in there and to decide what is useful.

Most of the comments I made were about the use of English. I've now
written some suggestions above where I commented on the content.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 963 bytes --]

^ permalink raw reply	[flat|nested] 17+ messages in thread

* [bug#28398] Xfburn
  2017-09-30 17:33     ` Christopher Baines
@ 2017-10-01  8:34       ` Thomas Schmitt
  2017-10-01 10:20         ` Thomas Schmitt
  0 siblings, 1 reply; 17+ messages in thread
From: Thomas Schmitt @ 2017-10-01  8:34 UTC (permalink / raw)
  To: 28398

Hi,

i'm the current developer of libburn and libisof.
Please Cc me with replies.

Be invited to re-use the descriptions of the Debian packages:

 Package: libburn4
 Description: library to provide CD/DVD writing functions
  libburn is a library for reading, mastering and writing optical discs.
  Supported media are: CD-R, CD-RW, DVD-RAM, DVD+RW, DVD+R, DVD+R/DL,
  DVD-RW, DVD-R, DVD-R/DL, BD-R, BD-RE.

 Package: libisofs6
 Description: library to create ISO 9660 images
  libisofs creates ISO 9660 (aka ECMA-119) filesystem images which can either
  be written to POSIX file objects or handed over to libburn for being written
  directly to optical media.
  It can read metadata of ISO 9660 filesystems, manipulate them, and use them
  to produce new complete filesystem images or add-on images to be appended
  to the read filesystem image.
  Supported extensions to ISO 9660 are Rock Ridge, Joliet, AAIP, zisofs.

Well, the synopsis of libburn could need a "/BD" added to "CD/DVD".

The current cdrskin description of Debian is too technical and too historical.
I will change it to:

 Package: cdrskin
 Description: command line CD/DVD/BD writing tool
  cdrskin strives to be a second source for the services traditionally
  provided by cdrecord. It writes data sessions to CD, DVD, or BD media.
  To CD media it may also write audio sessions.
  Multi-session is possible on all media types except DVD-R DL and
  fastly blanked DVD-RW.
  .
  This is a burner-only application. If you want a burner and ISO 9660 image
  manipulation application, please install the xorriso package.


ng0 wrote:
> Tbh I took this 1:1 from upstream. They don't really provide a good
> insight into what's what as far as I remember.

Hrm, yes, the wiki pages are too verbous for the purpose of a package
description.


> It is hard for me to take https://dev.lovelyhq.com/libburnia/web/wikis/home
> and the descriptions linked in there and to decide what is useful.

Just ask your friendly upstream. :))


Christopher Baines wrote:
> I don't get the cdrecord reference at the end.

It's historic. 10 years ago, the world was full of cdrecord forks.
The author of cdrecord accused the forkers of stealing his work.
cdrskin is not a fork but rather an emulation. I stole only the
option names and their help text lines.


Have a nice day :)

Thomas

^ permalink raw reply	[flat|nested] 17+ messages in thread

* [bug#28398] Xfburn
  2017-10-01  8:34       ` Thomas Schmitt
@ 2017-10-01 10:20         ` Thomas Schmitt
  2017-11-29  9:14           ` ng0
  0 siblings, 1 reply; 17+ messages in thread
From: Thomas Schmitt @ 2017-10-01 10:20 UTC (permalink / raw)
  To: 28398

Hi,

ng0 wrote:
> > (synopsis "library for reading, mastering and writing optical discs)

Christopher Baines wrote:
> I think this description better fits libburnia, rather than the
> specific libburn library.

Indeed "mastering" is inappropriate. libisofs masters images.
I will change the Debian description to

 Description: library to provide CD/DVD/BD writing functions
- libburn is a library for reading, mastering and writing optical discs.
+ libburn is a library for reading and writing optical discs.


Have a nice day :)

Thomas

^ permalink raw reply	[flat|nested] 17+ messages in thread

* [bug#28398] Xfburn
  2017-10-01 10:20         ` Thomas Schmitt
@ 2017-11-29  9:14           ` ng0
  2017-11-29 11:40             ` Thomas Schmitt
  0 siblings, 1 reply; 17+ messages in thread
From: ng0 @ 2017-11-29  9:14 UTC (permalink / raw)
  To: Thomas Schmitt; +Cc: 28398


[-- Attachment #1.1: Type: text/plain, Size: 959 bytes --]

Hi Thomas,

sorry for the delayed answer. I've applied your suggestions
and the ones Christopher had a while back in this new version
of the patches.

Thanks again for you input.

Thomas Schmitt transcribed 0.5K bytes:
> Hi,
> 
> ng0 wrote:
> > > (synopsis "library for reading, mastering and writing optical discs)
> 
> Christopher Baines wrote:
> > I think this description better fits libburnia, rather than the
> > specific libburn library.
> 
> Indeed "mastering" is inappropriate. libisofs masters images.
> I will change the Debian description to
> 
>  Description: library to provide CD/DVD/BD writing functions
> - libburn is a library for reading, mastering and writing optical discs.
> + libburn is a library for reading and writing optical discs.
> 
> 
> Have a nice day :)
> 
> Thomas
> 
> 

-- 
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://c.n0.is/ng0_pubkeys/tree/keys
  WWW: https://n0.is

[-- Attachment #1.2: 0001-gnu-Add-libburn.patch --]
[-- Type: text/plain, Size: 1988 bytes --]

From 233dbe8c7866b18f265a9cf2ecb31e5459be87d4 Mon Sep 17 00:00:00 2001
From: ng0 <ng0@infotropique.org>
Date: Sat, 9 Sep 2017 13:47:31 +0000
Subject: [PATCH 1/3] gnu: Add libburn.

* gnu/packages/cdrom.scm (libburn): New variable.
---
 gnu/packages/cdrom.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/cdrom.scm b/gnu/packages/cdrom.scm
index ddc035c1b..7e60acdb1 100644
--- a/gnu/packages/cdrom.scm
+++ b/gnu/packages/cdrom.scm
@@ -8,6 +8,7 @@
 ;;; Copyright © 2016 Marius Bakke <mbakke@fastmail.com>
 ;;; Copyright © 2017 John Darrington <jmd@gnu.org>
 ;;; Copyright © 2017 Thomas Danckaert <post@thomasdanckaert.be>
+;;; Copyright © 2017 ng0 <ng0@n0.is>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -693,3 +694,29 @@ distributed with CD images and are used to describe how tracks are
 laid out on the image.")
     (home-page "https://www.gnu.org/software/ccd2cue/")
     (license gpl3+)))
+
+(define-public libburn
+  (package
+    (name "libburn")
+    (version "1.4.6")
+    (source (origin
+             (method url-fetch)
+             (uri (string-append "http://files.libburnia-project.org/releases/"
+                                 "libburn-" version ".tar.gz"))
+             (sha256
+              (base32
+               "0wbh49s3az3sfpai09z1zdgynq7wnwrk31v5589033274nmzldlx"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:configure-flags (list "--enable-libcdio")))
+    (inputs
+     `(("libcdio" ,libcdio)))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+    (home-page "https://dev.lovelyhq.com/libburnia/libburn")
+    (synopsis "Library for reading and writing optical discs")
+    (description
+     "Libburn is a library for reading, mastering and writing optical discs.
+Supported media are: CD-R, CD-RW, DVD-RAM, DVD+RW, DVD+R, DVD+R/DL,
+DVD-RW, DVD-R, DVD-R/DL, BD-R, and BD-RE.")
+    (license gpl2)))
-- 
2.15.0


[-- Attachment #1.3: 0002-gnu-Add-libisofs.patch --]
[-- Type: text/plain, Size: 1876 bytes --]

From bad35c7013071f4e9ef17ff81e975b82302859a9 Mon Sep 17 00:00:00 2001
From: ng0 <ng0@infotropique.org>
Date: Sat, 9 Sep 2017 13:59:39 +0000
Subject: [PATCH 2/3] gnu: Add libisofs.

* gnu/packages/cdrom.scm (libisofs): New variable.
---
 gnu/packages/cdrom.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/cdrom.scm b/gnu/packages/cdrom.scm
index 7e60acdb1..86fa16e1c 100644
--- a/gnu/packages/cdrom.scm
+++ b/gnu/packages/cdrom.scm
@@ -720,3 +720,31 @@ laid out on the image.")
 Supported media are: CD-R, CD-RW, DVD-RAM, DVD+RW, DVD+R, DVD+R/DL,
 DVD-RW, DVD-R, DVD-R/DL, BD-R, and BD-RE.")
     (license gpl2)))
+
+(define-public libisofs
+  (package
+    (name "libisofs")
+    (version "1.4.6")
+    (source (origin
+             (method url-fetch)
+             (uri (string-append "http://files.libburnia-project.org/releases/"
+                                 "libisofs-" version ".tar.gz"))
+             (sha256
+              (base32
+               "02m5g6lbmmkh2xc5xzq5zaf3ma6v31gls66aj886b3cq9qw0paql"))))
+    (build-system gnu-build-system)
+    (inputs
+     `(("zlib" ,zlib)))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+    (home-page "https://dev.lovelyhq.com/libburnia/libisofs")
+    (synopsis "Library to create ISO 9660 images")
+    (description
+     "Libisofs creates ISO 9660 (also known as ECMA-119) filesystem images
+which can either be written to POSIX file objects or handed over to
+libburn for being written directly to optical media.
+It can read metadata of ISO 9660 filesystems, manipulate them, and use them
+to produce new complete filesystem images or add-on images to be appended
+to the read filesystem image.
+Supported extensions to ISO 9660 are Rock Ridge, Joliet, AAIP, zisofs.")
+    (license gpl2+)))
-- 
2.15.0


[-- Attachment #1.4: 0003-gnu-Add-xfburn.patch --]
[-- Type: text/plain, Size: 2578 bytes --]

From 4317f28d854b8f234d3272bd766c8d0b3cb8e9db Mon Sep 17 00:00:00 2001
From: ng0 <ng0@infotropique.org>
Date: Sat, 9 Sep 2017 14:11:36 +0000
Subject: [PATCH 3/3] gnu: Add xfburn.

* gnu/packages/xfce.scm (xfburn): New variable.
---
 gnu/packages/xfce.scm | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index 7668a1d38..964cb177d 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -6,6 +6,7 @@
 ;;; Copyright © 2016 Kei Kebreau <kkebreau@posteo.net>
 ;;; Copyright © 2017 Ricardo Wurmus <rekado@elephly.net>
 ;;; Copyright © 2017 Petter <petter@mykolab.ch>
+;;; Copyright © 2017 ng0 <ng0@n0.is>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -32,6 +33,7 @@
   #:use-module (guix build-system trivial)
   #:use-module (gnu packages)
   #:use-module (gnu packages calendar)
+  #:use-module (gnu packages cdrom)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages glib)
   #:use-module (gnu packages gtk)
@@ -902,3 +904,37 @@ bubble in a standard way can implicitly make use of xfce4-notifyd to do so by
 sending standard messages over D-Bus using the
 @code{org.freedesktop.Notifications} interface.")
     (license gpl2)))
+
+(define-public xfburn
+  (package
+    (name "xfburn")
+    (version "0.5.4")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "http://archive.xfce.org/src/apps/xfburn/"
+                                  (version-major+minor version) "/"
+                                  name "-" version ".tar.bz2"))
+              (sha256
+               (base32
+                "1xn1kwxa3dl5r9bfj90a5322ynkwbn6k5v9b3a3pbr3a23zm604s"))))
+    (build-system gnu-build-system)
+    (native-inputs
+     `(("intltool" ,intltool)
+       ("pkg-config" ,pkg-config)))
+    (inputs
+     `(("exo" ,exo)
+       ("gstreamer" ,gstreamer)
+       ("gst-plugins-base" ,gst-plugins-base)
+       ("glib" ,glib)
+       ("gtk+" ,gtk+-2)
+       ("libburn" ,libburn)
+       ("libisofs" ,libisofs)
+       ("libxfce4ui" ,libxfce4ui)))
+    (home-page "https://goodies.xfce.org/projects/applications/xfburn")
+    (synopsis "GTK+ based CD and DVD burning application")
+    (description
+     "Xfburn is a simple CD/DVD burning tool based on libburnia
+libraries.  It can blank CD/DVD(-RW)s, burn and create iso images,
+audio CDs, as well as burn personal compositions of data to either
+CD or DVD.")
+    (license gpl2+)))
-- 
2.15.0


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [bug#28398] Xfburn
  2017-11-29  9:14           ` ng0
@ 2017-11-29 11:40             ` Thomas Schmitt
  2017-11-29 14:37               ` ng0
  2017-12-01 14:13               ` Ludovic Courtès
  0 siblings, 2 replies; 17+ messages in thread
From: Thomas Schmitt @ 2017-11-29 11:40 UTC (permalink / raw)
  To: ng0; +Cc: 28398

Hi,

ng0 wrote:
> I've applied your suggestions
> and the ones Christopher had a while back in this new version
> of the patches.

The inappropriate word "mastering" is still in one of the two description
texts in the libburn patch

> +    (synopsis "Library for reading and writing optical discs")
> +    (description
> +     "Libburn is a library for reading, mastering and writing optical discs.


(It is also still in the description of the current Debian package. But
 that's only due to the long release cycle. The next Debian package will
 state what is committed by
   https://anonscm.debian.org/viewvc/pkg-libburnia/trunk/libburn/debian/control?r1=428&r2=430
)

------------------------------------------------------------------------

With Xfburn, consider to mention BD (Blu-ray) media additionally to CD and
DVD media. 

> +    (synopsis "GTK+ based CD and DVD burning application")
> +    (description
> +     "Xfburn is a simple CD/DVD burning tool based on libburnia
> +libraries.  It can blank CD/DVD(-RW)s, burn and create iso images,
> +audio CDs, as well as burn personal compositions of data to either
> +CD or DVD.")

I can confirm that "xfburn version 0.5.2 for Xfce 4.10" recognizes and
burns single layer BD-RE and BD-R media. Users of libburn report success
with multi-layer BD-RE and BD-R media.

------------------------------------------------------------------------

Did we already talk about these lines in the libburn patch ?

> +     `(#:configure-flags (list "--enable-libcdio")))
> +    (inputs
> +     `(("libcdio" ,libcdio)))

If they shall by default let libburn use the SCSI transport mechanism of
libcdio, then better don't do this.

Without wanting to badmouth libcdio, it turned out that its SCSI/MMC layer
is needy of modernization and that it does not provide usable SCSI transport
on operating systems which libburn cannot handle by its own system adapters.
libburn has SCSI-capable adapters for Linux The Kernel, FreeBSD, Solaris,
NetBSD, OpenBSD.

In Hurd/Mach The Kernel we have no SCSI transport facility from userland to
optical drives, i fear. There, libburn can only operate on data files and
read-write block devices. Useful mainly as foundation for xorriso to make
ISO 9660 filesystem images.

The shortcommings of libcdio towards libburn's sg-linux.c adapter are mainly
with receiving SCSI error conditions (aka Sense Data) from the drive and
forwarding them to libburn.

So my advise is not to configure libburn with --enable-libcdio and not to
declare libcdio a dependency of libburn.

------------------------------------------------------------------------

I also looked at the libisofs related patch:

> +    (inputs
> +     `(("zlib" ,zlib)))

If ./configure sees libacl and libattr on GNU/Linux, then libisofs will link
to it and enable recording of ACL and extended file attributes.

Looking for "acl" in Guix, i found
  https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/acl.scm?id=v0.13.0-5000-gd2bdee8a6#n33
which looks like what Debian packages as "libacl1" and is used by Debian's
libisofs package.

So consider to add for libisofs
      ("acl" ,acl)

----------------------------------------------------------------------------

GNU xorriso versus libisoburn's xorriso:

The only known application of libisofs' ACL capabilities is xorriso. It can
record ACLs as part of backups and restore them back to disk. Operating
systems are supposed to ignore the ACL info when mounting and reading
libisofs made filesystems.

Guix currently packages GNU xorriso, which brings own source copies of
libburn, libisofs, libisoburn, and libjte.

When libburn and libisofs are established as Guix packages and the decision
is made that Debian's Jigdo ISO download mechanism is not desired, one should
consider to package libisoburn and to install its dynamically linked xorriso
binary.

The source code and functionality of both xorrisos is the same, except that
Guix offers no libjte for Debian's Jigdo format. Both are maintained by me.
libisoburn is GPLv2+, but by using libreadline it will become GPLv3+.
GNU xorriso is always GPLv3+.

Reason for the existence of GNU xorriso is mainly that it can be compiled
and installed by a normal user without interfering with system-wide installed
libburn and libisofs. This provides freedom from distro decisions and delays.

Guix's xorriso package has at
  https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/cdrom.scm?id=v0.13.0-2323-g35131babc#n148
>     (inputs
>      `(("acl" ,acl)
>        ("readline" ,readline)
>        ("bzip2" ,bzip2)
>        ("zlib" ,zlib)
>        ("libcdio" ,libcdio)))

The use of "bzip2" seems wrong. libjte optionally uses libbz2 which i don't
find in Guix. "bzip2" does not promise the library but rather the standalone
binary.

The use of "libcdio" would have the disadvantage described above. But
it seems that it is not enabled at configure time of GNU xorriso.
So one should remove it from the xorriso input list, too. 

------------------------------------------------------------------------

Whew. I did not plan to write such a long mail.


Have a nice day :)

Thomas

^ permalink raw reply	[flat|nested] 17+ messages in thread

* [bug#28398] Xfburn
  2017-11-29 11:40             ` Thomas Schmitt
@ 2017-11-29 14:37               ` ng0
  2017-12-01 14:13               ` Ludovic Courtès
  1 sibling, 0 replies; 17+ messages in thread
From: ng0 @ 2017-11-29 14:37 UTC (permalink / raw)
  To: Thomas Schmitt; +Cc: 28398

[-- Attachment #1: Type: text/plain, Size: 5886 bytes --]

Hi,

Many thanks for the in-depth review and hints! I don't
have the time for immediate questions or patching, so
I'll followup later. I just wanted to express my thanks.

Thomas Schmitt transcribed 5.0K bytes:
> Hi,
> 
> ng0 wrote:
> > I've applied your suggestions
> > and the ones Christopher had a while back in this new version
> > of the patches.
> 
> The inappropriate word "mastering" is still in one of the two description
> texts in the libburn patch
> 
> > +    (synopsis "Library for reading and writing optical discs")
> > +    (description
> > +     "Libburn is a library for reading, mastering and writing optical discs.
> 
> 
> (It is also still in the description of the current Debian package. But
>  that's only due to the long release cycle. The next Debian package will
>  state what is committed by
>    https://anonscm.debian.org/viewvc/pkg-libburnia/trunk/libburn/debian/control?r1=428&r2=430
> )
> 
> ------------------------------------------------------------------------
> 
> With Xfburn, consider to mention BD (Blu-ray) media additionally to CD and
> DVD media. 
> 
> > +    (synopsis "GTK+ based CD and DVD burning application")
> > +    (description
> > +     "Xfburn is a simple CD/DVD burning tool based on libburnia
> > +libraries.  It can blank CD/DVD(-RW)s, burn and create iso images,
> > +audio CDs, as well as burn personal compositions of data to either
> > +CD or DVD.")
> 
> I can confirm that "xfburn version 0.5.2 for Xfce 4.10" recognizes and
> burns single layer BD-RE and BD-R media. Users of libburn report success
> with multi-layer BD-RE and BD-R media.
> 
> ------------------------------------------------------------------------
> 
> Did we already talk about these lines in the libburn patch ?
> 
> > +     `(#:configure-flags (list "--enable-libcdio")))
> > +    (inputs
> > +     `(("libcdio" ,libcdio)))
> 
> If they shall by default let libburn use the SCSI transport mechanism of
> libcdio, then better don't do this.
> 
> Without wanting to badmouth libcdio, it turned out that its SCSI/MMC layer
> is needy of modernization and that it does not provide usable SCSI transport
> on operating systems which libburn cannot handle by its own system adapters.
> libburn has SCSI-capable adapters for Linux The Kernel, FreeBSD, Solaris,
> NetBSD, OpenBSD.
> 
> In Hurd/Mach The Kernel we have no SCSI transport facility from userland to
> optical drives, i fear. There, libburn can only operate on data files and
> read-write block devices. Useful mainly as foundation for xorriso to make
> ISO 9660 filesystem images.
> 
> The shortcommings of libcdio towards libburn's sg-linux.c adapter are mainly
> with receiving SCSI error conditions (aka Sense Data) from the drive and
> forwarding them to libburn.
> 
> So my advise is not to configure libburn with --enable-libcdio and not to
> declare libcdio a dependency of libburn.
> 
> ------------------------------------------------------------------------
> 
> I also looked at the libisofs related patch:
> 
> > +    (inputs
> > +     `(("zlib" ,zlib)))
> 
> If ./configure sees libacl and libattr on GNU/Linux, then libisofs will link
> to it and enable recording of ACL and extended file attributes.
> 
> Looking for "acl" in Guix, i found
>   https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/acl.scm?id=v0.13.0-5000-gd2bdee8a6#n33
> which looks like what Debian packages as "libacl1" and is used by Debian's
> libisofs package.
> 
> So consider to add for libisofs
>       ("acl" ,acl)
> 
> ----------------------------------------------------------------------------
> 
> GNU xorriso versus libisoburn's xorriso:
> 
> The only known application of libisofs' ACL capabilities is xorriso. It can
> record ACLs as part of backups and restore them back to disk. Operating
> systems are supposed to ignore the ACL info when mounting and reading
> libisofs made filesystems.
> 
> Guix currently packages GNU xorriso, which brings own source copies of
> libburn, libisofs, libisoburn, and libjte.
> 
> When libburn and libisofs are established as Guix packages and the decision
> is made that Debian's Jigdo ISO download mechanism is not desired, one should
> consider to package libisoburn and to install its dynamically linked xorriso
> binary.
> 
> The source code and functionality of both xorrisos is the same, except that
> Guix offers no libjte for Debian's Jigdo format. Both are maintained by me.
> libisoburn is GPLv2+, but by using libreadline it will become GPLv3+.
> GNU xorriso is always GPLv3+.
> 
> Reason for the existence of GNU xorriso is mainly that it can be compiled
> and installed by a normal user without interfering with system-wide installed
> libburn and libisofs. This provides freedom from distro decisions and delays.
> 
> Guix's xorriso package has at
>   https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/cdrom.scm?id=v0.13.0-2323-g35131babc#n148
> >     (inputs
> >      `(("acl" ,acl)
> >        ("readline" ,readline)
> >        ("bzip2" ,bzip2)
> >        ("zlib" ,zlib)
> >        ("libcdio" ,libcdio)))
> 
> The use of "bzip2" seems wrong. libjte optionally uses libbz2 which i don't
> find in Guix. "bzip2" does not promise the library but rather the standalone
> binary.
> 
> The use of "libcdio" would have the disadvantage described above. But
> it seems that it is not enabled at configure time of GNU xorriso.
> So one should remove it from the xorriso input list, too. 
> 
> ------------------------------------------------------------------------
> 
> Whew. I did not plan to write such a long mail.
> 
> 
> Have a nice day :)
> 
> Thomas
> 
> 

-- 
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://c.n0.is/ng0_pubkeys/tree/keys
  WWW: https://n0.is

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 17+ messages in thread

* [bug#28398] Xfburn
  2017-11-29 11:40             ` Thomas Schmitt
  2017-11-29 14:37               ` ng0
@ 2017-12-01 14:13               ` Ludovic Courtès
  2017-12-01 16:06                 ` Thomas Schmitt
  1 sibling, 1 reply; 17+ messages in thread
From: Ludovic Courtès @ 2017-12-01 14:13 UTC (permalink / raw)
  To: Thomas Schmitt; +Cc: 28398

Hi Thomas,

"Thomas Schmitt" <scdbackup@gmx.net> skribis:

> ng0 wrote:
>> I've applied your suggestions
>> and the ones Christopher had a while back in this new version
>> of the patches.
>
> The inappropriate word "mastering" is still in one of the two description
> texts in the libburn patch
>
>> +    (synopsis "Library for reading and writing optical discs")
>> +    (description
>> +     "Libburn is a library for reading, mastering and writing optical discs.
>
>
> (It is also still in the description of the current Debian package. But
>  that's only due to the long release cycle. The next Debian package will
>  state what is committed by
>    https://anonscm.debian.org/viewvc/pkg-libburnia/trunk/libburn/debian/control?r1=428&r2=430
> )

For the record, for GNU packages we stick to the GNU description as
maintained in the Womb and ‘guix lint’ makes sure we do:

  http://cvs.savannah.gnu.org/viewvc/*checkout*/womb/gnumaint/pkgblurbs.txt

However in this case our Xorriso description seems to differ.  Are you
OK with the one in pkgblurbs.txt above?  If not, can you provide a
suggestion?

> GNU xorriso versus libisoburn's xorriso:
>
> The only known application of libisofs' ACL capabilities is xorriso. It can
> record ACLs as part of backups and restore them back to disk. Operating
> systems are supposed to ignore the ACL info when mounting and reading
> libisofs made filesystems.
>
> Guix currently packages GNU xorriso, which brings own source copies of
> libburn, libisofs, libisoburn, and libjte.
>
> When libburn and libisofs are established as Guix packages and the decision
> is made that Debian's Jigdo ISO download mechanism is not desired, one should
> consider to package libisoburn and to install its dynamically linked xorriso
> binary.

Indeed, we should do that.

> Reason for the existence of GNU xorriso is mainly that it can be compiled
> and installed by a normal user without interfering with system-wide installed
> libburn and libisofs. This provides freedom from distro decisions and delays.

As package maintainers our choice is to *not* use bundled software in
such cases, though.  Is it the only difference between the two xorrisos?

Thanks for your feedback, it’s useful guidance!

Ludo’.

^ permalink raw reply	[flat|nested] 17+ messages in thread

* [bug#28398] Xfburn
  2017-12-01 14:13               ` Ludovic Courtès
@ 2017-12-01 16:06                 ` Thomas Schmitt
  2017-12-04 14:06                   ` Ludovic Courtès
  0 siblings, 1 reply; 17+ messages in thread
From: Thomas Schmitt @ 2017-12-01 16:06 UTC (permalink / raw)
  To: ng0; +Cc: 28398

Hi,

Ludovic Courtès wrote:
> http://cvs.savannah.gnu.org/viewvc/*checkout*/womb/gnumaint/pkgblurbs.txt
> However in this case our Xorriso description seems to differ.
> Are you OK with the one in pkgblurbs.txt above?

I'm not sure whether the last sentence could be misleading:
  "xorriso can then be used to copy files directly into or out of ISO files."

"ISO files" should be "ISO filesystems", in any case.

"copy files directly into" might suggest usual read-write capabilities.
But as mentioned by "session-wise manipulation", the write capability is
not the usual one.

It works like this:
- The directory tree and metadata of an ISO filesystem get loaded into
  the object model of libisofs,
- libisofs applies manipulations to this model,
- finally a new directory tree based on the model gets written to the
  medium, together with any new data file content.
Old directory trees and the data file content of outdated files stays
unchanged. Only the superblock of the filesystem will get overwritten,
if the medium is overwritable. On non-overwritable media, the Linux kernel
will look for a superblock in the first track of the last recorded session.

To get an idea how sessions are arranged on a BD-R medium, see
  https://screenshots.debian.net/package/xorriso
On GNU/Linux, mount option -o sbsector= can mount any of the 10 sessions
to show the ~4 GB backup state of the day when the session was made.
Although the add-on sessions only introduced content of changed data files,
they still impose substantial overhead by each having a tree of 60,000+
file names. (But hey, it's already worth 40 GB of backup and will take
about 200 more daily sessions.)


> As package maintainers our choice is to *not* use bundled software in
> such cases, though.  Is it the only difference between the two xorrisos?

Feature- and bug-wise: yes.
There is the built-in copy of libjte in GNU xorriso, which one would have
to offer libisoburn at configure-, build-, and run-time, in order to get
the same capability of creating Debian .jigdo and .template files.
See also  https://www.debian.org/CD/jigdo-cd/

Name-wise there are problems with some from-source distros which have
a 1:1 relationship between source package and installed set of binaries.
They are unable to offer a package named "xorriso" but only its upstream
package "libisoburn".
(I could have changed this by splitting up the three upstream tarballs
 into six, some years ago. But i did not like the idea much and my then
 Debian Developer hated it thoroughly. Meanwhile it would cause work in
 too many distros.)
Afaik, the FreeBSD port of libisoburn is named "xorriso".
Archlinux has a "Provides:" header where its "libisoburn" package
advertises "xorriso, xorriso-tcltk".

Any difference results from automatic creation of GNU xorriso from the
library sources by
  https://dev.lovelyhq.com/libburnia/libisoburn/raw/master/xorriso/make_xorriso_standalone.sh
It makes changes about:
- Build system files: bootstrap, configure.ac, Makefile.am, version.h.in
- Documentation files: CONTRIBUTORS, README, COPYRIGHT, COPYING, AUTHORS
- Program id message and license statement control macro in xorriso/xorriso.h


Have a nice day :)

Thomas

^ permalink raw reply	[flat|nested] 17+ messages in thread

* [bug#28398] Xfburn
  2017-12-01 16:06                 ` Thomas Schmitt
@ 2017-12-04 14:06                   ` Ludovic Courtès
  2017-12-11  9:58                     ` ng0
  0 siblings, 1 reply; 17+ messages in thread
From: Ludovic Courtès @ 2017-12-04 14:06 UTC (permalink / raw)
  To: Thomas Schmitt; +Cc: 28398

"Thomas Schmitt" <scdbackup@gmx.net> skribis:

> Ludovic Courtès wrote:
>> http://cvs.savannah.gnu.org/viewvc/*checkout*/womb/gnumaint/pkgblurbs.txt
>> However in this case our Xorriso description seems to differ.
>> Are you OK with the one in pkgblurbs.txt above?
>
> I'm not sure whether the last sentence could be misleading:
>   "xorriso can then be used to copy files directly into or out of ISO files."
>
> "ISO files" should be "ISO filesystems", in any case.

Indeed, fixed.

[...]

>> As package maintainers our choice is to *not* use bundled software in
>> such cases, though.  Is it the only difference between the two xorrisos?
>
> Feature- and bug-wise: yes.
> There is the built-in copy of libjte in GNU xorriso, which one would have
> to offer libisoburn at configure-, build-, and run-time, in order to get
> the same capability of creating Debian .jigdo and .template files.
> See also  https://www.debian.org/CD/jigdo-cd/
>
> Name-wise there are problems with some from-source distros which have
> a 1:1 relationship between source package and installed set of binaries.
> They are unable to offer a package named "xorriso" but only its upstream
> package "libisoburn".
> (I could have changed this by splitting up the three upstream tarballs
>  into six, some years ago. But i did not like the idea much and my then
>  Debian Developer hated it thoroughly. Meanwhile it would cause work in
>  too many distros.)
> Afaik, the FreeBSD port of libisoburn is named "xorriso".
> Archlinux has a "Provides:" header where its "libisoburn" package
> advertises "xorriso, xorriso-tcltk".
>
> Any difference results from automatic creation of GNU xorriso from the
> library sources by
>   https://dev.lovelyhq.com/libburnia/libisoburn/raw/master/xorriso/make_xorriso_standalone.sh
> It makes changes about:
> - Build system files: bootstrap, configure.ac, Makefile.am, version.h.in
> - Documentation files: CONTRIBUTORS, README, COPYRIGHT, COPYING, AUTHORS
> - Program id message and license statement control macro in xorriso/xorriso.h

I see.

Thanks for explaining!

Ludo’.

^ permalink raw reply	[flat|nested] 17+ messages in thread

* [bug#28398] Xfburn
  2017-12-04 14:06                   ` Ludovic Courtès
@ 2017-12-11  9:58                     ` ng0
  2017-12-11 11:02                       ` Thomas Schmitt
  0 siblings, 1 reply; 17+ messages in thread
From: ng0 @ 2017-12-11  9:58 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 28398, Thomas Schmitt


[-- Attachment #1.1: Type: text/plain, Size: 3206 bytes --]

Alright, here's the next revision. I've included a new patch to
work in your comments on xorriso (dropping the 2 inputs).

The compiled Xfburn gives me 2 error messages so far:
1. No Drive found (thanks Cpt. Obvious, I have no optical drive here).
2. More concerning:
   Failed to initialize gstreamer transcoder: An error occurred setting gstreamer up for transcoding
   (falling back to basic implementation)

Keep in mind that I've tested this from within guile-wm, so
this might be different in XFCE or other environments. I'll
test this later today. I expect XFCE to work in MATE at the
very least, but XFCE-only would be good for starters.

The application itself starts.

Session output on terminal can not be copied right now, I'll
send it in later today if necessary.

Ludovic Courtès transcribed 2.1K bytes:
> "Thomas Schmitt" <scdbackup@gmx.net> skribis:
> 
> > Ludovic Courtès wrote:
> >> http://cvs.savannah.gnu.org/viewvc/*checkout*/womb/gnumaint/pkgblurbs.txt
> >> However in this case our Xorriso description seems to differ.
> >> Are you OK with the one in pkgblurbs.txt above?
> >
> > I'm not sure whether the last sentence could be misleading:
> >   "xorriso can then be used to copy files directly into or out of ISO files."
> >
> > "ISO files" should be "ISO filesystems", in any case.
> 
> Indeed, fixed.
> 
> [...]
> 
> >> As package maintainers our choice is to *not* use bundled software in
> >> such cases, though.  Is it the only difference between the two xorrisos?
> >
> > Feature- and bug-wise: yes.
> > There is the built-in copy of libjte in GNU xorriso, which one would have
> > to offer libisoburn at configure-, build-, and run-time, in order to get
> > the same capability of creating Debian .jigdo and .template files.
> > See also  https://www.debian.org/CD/jigdo-cd/
> >
> > Name-wise there are problems with some from-source distros which have
> > a 1:1 relationship between source package and installed set of binaries.
> > They are unable to offer a package named "xorriso" but only its upstream
> > package "libisoburn".
> > (I could have changed this by splitting up the three upstream tarballs
> >  into six, some years ago. But i did not like the idea much and my then
> >  Debian Developer hated it thoroughly. Meanwhile it would cause work in
> >  too many distros.)
> > Afaik, the FreeBSD port of libisoburn is named "xorriso".
> > Archlinux has a "Provides:" header where its "libisoburn" package
> > advertises "xorriso, xorriso-tcltk".
> >
> > Any difference results from automatic creation of GNU xorriso from the
> > library sources by
> >   https://dev.lovelyhq.com/libburnia/libisoburn/raw/master/xorriso/make_xorriso_standalone.sh
> > It makes changes about:
> > - Build system files: bootstrap, configure.ac, Makefile.am, version.h.in
> > - Documentation files: CONTRIBUTORS, README, COPYRIGHT, COPYING, AUTHORS
> > - Program id message and license statement control macro in xorriso/xorriso.h
> 
> I see.
> 
> Thanks for explaining!
> 
> Ludo’.
> 

-- 
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://c.n0.is/ng0_pubkeys/tree/keys
  WWW: https://n0.is

[-- Attachment #1.2: 0001-gnu-Add-libburn.patch --]
[-- Type: text/plain, Size: 1857 bytes --]

From f69ac571c040b0ac055edb6920723121f55f649d Mon Sep 17 00:00:00 2001
From: ng0 <ng0@infotropique.org>
Date: Sat, 9 Sep 2017 13:47:31 +0000
Subject: [PATCH 1/4] gnu: Add libburn.

* gnu/packages/cdrom.scm (libburn): New variable.
---
 gnu/packages/cdrom.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/cdrom.scm b/gnu/packages/cdrom.scm
index 523158d55..f85a76891 100644
--- a/gnu/packages/cdrom.scm
+++ b/gnu/packages/cdrom.scm
@@ -9,6 +9,7 @@
 ;;; Copyright © 2017 John Darrington <jmd@gnu.org>
 ;;; Copyright © 2017 Thomas Danckaert <post@thomasdanckaert.be>
 ;;; Copyright © 2017 Tobias Geerinckx-Rice <me@tobias.gr>
+;;; Copyright © 2017 ng0 <ng0@n0.is>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -694,3 +695,25 @@ distributed with CD images and are used to describe how tracks are
 laid out on the image.")
     (home-page "https://www.gnu.org/software/ccd2cue/")
     (license gpl3+)))
+
+(define-public libburn
+  (package
+    (name "libburn")
+    (version "1.4.6")
+    (source (origin
+             (method url-fetch)
+             (uri (string-append "http://files.libburnia-project.org/releases/"
+                                 "libburn-" version ".tar.gz"))
+             (sha256
+              (base32
+               "0wbh49s3az3sfpai09z1zdgynq7wnwrk31v5589033274nmzldlx"))))
+    (build-system gnu-build-system)
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+    (home-page "https://dev.lovelyhq.com/libburnia/libburn")
+    (synopsis "Library for reading and writing optical discs")
+    (description
+     "Libburn is a library for reading and writing optical discs.
+Supported media are: CD-R, CD-RW, DVD-RAM, DVD+RW, DVD+R, DVD+R/DL,
+DVD-RW, DVD-R, DVD-R/DL, BD-R, and BD-RE.")
+    (license gpl2)))
-- 
2.15.1


[-- Attachment #1.3: 0002-gnu-Add-libisofs.patch --]
[-- Type: text/plain, Size: 1899 bytes --]

From 81a8e708cd739907e2150bc8a79c4bd6cb86a829 Mon Sep 17 00:00:00 2001
From: ng0 <ng0@infotropique.org>
Date: Sat, 9 Sep 2017 13:59:39 +0000
Subject: [PATCH 2/4] gnu: Add libisofs.

* gnu/packages/cdrom.scm (libisofs): New variable.
---
 gnu/packages/cdrom.scm | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/gnu/packages/cdrom.scm b/gnu/packages/cdrom.scm
index f85a76891..c1adf174b 100644
--- a/gnu/packages/cdrom.scm
+++ b/gnu/packages/cdrom.scm
@@ -717,3 +717,32 @@ laid out on the image.")
 Supported media are: CD-R, CD-RW, DVD-RAM, DVD+RW, DVD+R, DVD+R/DL,
 DVD-RW, DVD-R, DVD-R/DL, BD-R, and BD-RE.")
     (license gpl2)))
+
+(define-public libisofs
+  (package
+    (name "libisofs")
+    (version "1.4.6")
+    (source (origin
+             (method url-fetch)
+             (uri (string-append "http://files.libburnia-project.org/releases/"
+                                 "libisofs-" version ".tar.gz"))
+             (sha256
+              (base32
+               "02m5g6lbmmkh2xc5xzq5zaf3ma6v31gls66aj886b3cq9qw0paql"))))
+    (build-system gnu-build-system)
+    (inputs
+     `(("zlib" ,zlib)
+       ("acl" ,acl)))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+    (home-page "https://dev.lovelyhq.com/libburnia/libisofs")
+    (synopsis "Library to create ISO 9660 images")
+    (description
+     "Libisofs creates ISO 9660 (also known as ECMA-119) filesystem images
+which can either be written to POSIX file objects or handed over to
+libburn for being written directly to optical media.
+It can read metadata of ISO 9660 filesystems, manipulate them, and use them
+to produce new complete filesystem images or add-on images to be appended
+to the read filesystem image.
+Supported extensions to ISO 9660 are Rock Ridge, Joliet, AAIP, zisofs.")
+    (license gpl2+)))
-- 
2.15.1


[-- Attachment #1.4: 0003-gnu-Add-xfburn.patch --]
[-- Type: text/plain, Size: 2608 bytes --]

From f2f8497ebcb1dabd0f3076b2782f00ac0ba04e05 Mon Sep 17 00:00:00 2001
From: ng0 <ng0@infotropique.org>
Date: Sat, 9 Sep 2017 14:11:36 +0000
Subject: [PATCH 3/4] gnu: Add xfburn.

* gnu/packages/xfce.scm (xfburn): New variable.
---
 gnu/packages/xfce.scm | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index 7668a1d38..4d7db8d19 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -6,6 +6,7 @@
 ;;; Copyright © 2016 Kei Kebreau <kkebreau@posteo.net>
 ;;; Copyright © 2017 Ricardo Wurmus <rekado@elephly.net>
 ;;; Copyright © 2017 Petter <petter@mykolab.ch>
+;;; Copyright © 2017 ng0 <ng0@n0.is>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -32,6 +33,7 @@
   #:use-module (guix build-system trivial)
   #:use-module (gnu packages)
   #:use-module (gnu packages calendar)
+  #:use-module (gnu packages cdrom)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages glib)
   #:use-module (gnu packages gtk)
@@ -902,3 +904,37 @@ bubble in a standard way can implicitly make use of xfce4-notifyd to do so by
 sending standard messages over D-Bus using the
 @code{org.freedesktop.Notifications} interface.")
     (license gpl2)))
+
+(define-public xfburn
+  (package
+    (name "xfburn")
+    (version "0.5.4")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "http://archive.xfce.org/src/apps/xfburn/"
+                                  (version-major+minor version) "/"
+                                  name "-" version ".tar.bz2"))
+              (sha256
+               (base32
+                "1xn1kwxa3dl5r9bfj90a5322ynkwbn6k5v9b3a3pbr3a23zm604s"))))
+    (build-system gnu-build-system)
+    (native-inputs
+     `(("intltool" ,intltool)
+       ("pkg-config" ,pkg-config)))
+    (inputs
+     `(("exo" ,exo)
+       ("gstreamer" ,gstreamer)
+       ("gst-plugins-base" ,gst-plugins-base)
+       ("glib" ,glib)
+       ("gtk+" ,gtk+-2)
+       ("libburn" ,libburn)
+       ("libisofs" ,libisofs)
+       ("libxfce4ui" ,libxfce4ui)))
+    (home-page "https://goodies.xfce.org/projects/applications/xfburn")
+    (synopsis "GTK+ based CD, DVD and Blu-ray burning application")
+    (description
+     "Xfburn is a simple CD, DVD, and Blu-ray burning tool based on
+the libburnia libraries.  It can blank CD/DVD/BD(-RW)s, burn and
+create iso images, audio CDs, as well as burn personal compositions
+of data to either CD/DVD/BD.")
+    (license gpl2+)))
-- 
2.15.1


[-- Attachment #1.5: 0004-gnu-xorriso-Remove-bzip2-and-libcdio-from-inputs.patch --]
[-- Type: text/plain, Size: 967 bytes --]

From ed830ac82a77f4b64968904afabac0898adad67f Mon Sep 17 00:00:00 2001
From: ng0 <ng0@n0.is>
Date: Mon, 11 Dec 2017 09:29:40 +0000
Subject: [PATCH 4/4] gnu: xorriso: Remove 'bzip2' and 'libcdio' from inputs.

Thomas Schmitt suggested in bug#28398 to apply these changes.

* gnu/packages/cdrom.scm (xorriso)[inputs]: Remove 'bzip2' and 'libcdio'.
---
 gnu/packages/cdrom.scm | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/gnu/packages/cdrom.scm b/gnu/packages/cdrom.scm
index c1adf174b..228af1651 100644
--- a/gnu/packages/cdrom.scm
+++ b/gnu/packages/cdrom.scm
@@ -161,9 +161,7 @@ libcdio.")
     (inputs
      `(("acl" ,acl)
        ("readline" ,readline)
-       ("bzip2" ,bzip2)
-       ("zlib" ,zlib)
-       ("libcdio" ,libcdio)))
+       ("zlib" ,zlib)))
     (home-page "https://www.gnu.org/software/xorriso/")
     (synopsis "Create, manipulate, burn ISO-9660 file systems")
     (description
-- 
2.15.1


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [bug#28398] Xfburn
  2017-12-11  9:58                     ` ng0
@ 2017-12-11 11:02                       ` Thomas Schmitt
  2017-12-29 16:39                         ` ng0
  0 siblings, 1 reply; 17+ messages in thread
From: Thomas Schmitt @ 2017-12-11 11:02 UTC (permalink / raw)
  To: ng0; +Cc: 28398

Hi,

the patches look good to me (which does not have to mean much),
About the Xfburn 

ng0 wrote:
> 1. No Drive found (thanks Cpt. Obvious, I have no optical drive here).

You may at least try creating an ISO image file instead of burning.
Choose "New Data Composition", click the "+ Add" button, choose some
file by single click (double click crashes my local Xfburn), click
the "Add" button at the lower left, click "Proceed to Burn" at the
lower left, check "Only create ISO" and choose a file name for the ISO
image file.

There is a software emulator for some combinations of optical drives
and media types:
  http://cdemu.sourceforge.net/about
It is quite a poor surrogate to a real DVD or BD drive, but at least
the current bug carer of K3B uses it with some success.


> 2. More concerning:
>    Failed to initialize gstreamer transcoder: An error occurred setting
> gstreamer up for transcoding
>   (falling back to basic implementation)

In
  https://forums.bunsenlabs.org/viewtopic.php?id=102
i see the advise to do
  sudo apt-get install --no-install-recommends gstreamer0.10-plugins-good gstreamer0.10-plugins-ugly
and a comment saying that installing of "qtstreamer-plugins,
gstreamer1.0-libav, libgstreamer-perl, ruby-clutter-gstreamer" did the
trick, too.

So it seems to be about finding the packages which contain the desired
software. Looking at the dependencies list of
  https://packages.debian.org/oldstable/gstreamer0.10-plugins-good
  https://packages.debian.org/oldstable/gstreamer0.10-plugins-ugly
i'd say that this might become a lengthy adventure, if not these lines
in 0003-gnu-Add-xfburn.patch already pull in most of it:
+       ("gstreamer" ,gstreamer)
+       ("gst-plugins-base" ,gst-plugins-base)

gstreamer should not be necessary for the tasks of "New Data Composition",
"Burn Image", and "Blank Disc".
I expect no need for it in the task of "Audio CD" if the input files are
already converted to .wav with the properties "uncompressed headerless PCM,
44100 Hz, 16 bit, stereo".


Have a nice day :)

Thomas

^ permalink raw reply	[flat|nested] 17+ messages in thread

* [bug#28398] Xfburn
  2017-12-11 11:02                       ` Thomas Schmitt
@ 2017-12-29 16:39                         ` ng0
  2018-02-01 23:04                           ` bug#28398: Xfburn Christopher Baines
  0 siblings, 1 reply; 17+ messages in thread
From: ng0 @ 2017-12-29 16:39 UTC (permalink / raw)
  To: Thomas Schmitt; +Cc: 28398


[-- Attachment #1.1: Type: text/plain, Size: 3060 bytes --]

Thomas Schmitt transcribed 2.0K bytes:
> Hi,
> 
> the patches look good to me (which does not have to mean much),
> About the Xfburn 
> 
> ng0 wrote:
> > 1. No Drive found (thanks Cpt. Obvious, I have no optical drive here).
> 
> You may at least try creating an ISO image file instead of burning.
> Choose "New Data Composition", click the "+ Add" button, choose some
> file by single click (double click crashes my local Xfburn), click
> the "Add" button at the lower left, click "Proceed to Burn" at the
> lower left, check "Only create ISO" and choose a file name for the ISO
> image file.
> 
> There is a software emulator for some combinations of optical drives
> and media types:
>   http://cdemu.sourceforge.net/about
> It is quite a poor surrogate to a real DVD or BD drive, but at least
> the current bug carer of K3B uses it with some success.

I didn't use cdemu - I would need to package that - but I mounted the data
collection type .iso I recorded into an ISO file. From what I can tell, it works.

I have issues with the icons, but that's just my personal WM/DM (which is pretty sminimal)
and can be addressed later on (this is trivial and you just need the right icon set).

I'll attach the latest patches.
Let's just merge this now and address the rest later, okay?
I have other issues I need to work on, and from where I stand this
is done - all the basic issues have been fixed.
I appreciate the help Thomas, thanks for what you have done. It's
extraordinary, we usually don't get it like this.

Thanks!
> 
> > 2. More concerning:
> >    Failed to initialize gstreamer transcoder: An error occurred setting
> > gstreamer up for transcoding
> >   (falling back to basic implementation)
> 
> In
>   https://forums.bunsenlabs.org/viewtopic.php?id=102
> i see the advise to do
>   sudo apt-get install --no-install-recommends gstreamer0.10-plugins-good gstreamer0.10-plugins-ugly
> and a comment saying that installing of "qtstreamer-plugins,
> gstreamer1.0-libav, libgstreamer-perl, ruby-clutter-gstreamer" did the
> trick, too.
> 
> So it seems to be about finding the packages which contain the desired
> software. Looking at the dependencies list of
>   https://packages.debian.org/oldstable/gstreamer0.10-plugins-good
>   https://packages.debian.org/oldstable/gstreamer0.10-plugins-ugly
> i'd say that this might become a lengthy adventure, if not these lines
> in 0003-gnu-Add-xfburn.patch already pull in most of it:
> +       ("gstreamer" ,gstreamer)
> +       ("gst-plugins-base" ,gst-plugins-base)
> 
> gstreamer should not be necessary for the tasks of "New Data Composition",
> "Burn Image", and "Blank Disc".
> I expect no need for it in the task of "Audio CD" if the input files are
> already converted to .wav with the properties "uncompressed headerless PCM,
> 44100 Hz, 16 bit, stereo".
> 
> 
> Have a nice day :)
> 
> Thomas
> 
> 

-- 
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://c.n0.is/ng0_pubkeys/tree/keys
  WWW: https://n0.is

[-- Attachment #1.2: 0001-gnu-Add-libburn.patch --]
[-- Type: text/plain, Size: 1857 bytes --]

From 2292f78c47219b50f0827b533331e1ab3648735a Mon Sep 17 00:00:00 2001
From: ng0 <ng0@infotropique.org>
Date: Sat, 9 Sep 2017 13:47:31 +0000
Subject: [PATCH 1/4] gnu: Add libburn.

* gnu/packages/cdrom.scm (libburn): New variable.
---
 gnu/packages/cdrom.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/cdrom.scm b/gnu/packages/cdrom.scm
index 523158d55..f85a76891 100644
--- a/gnu/packages/cdrom.scm
+++ b/gnu/packages/cdrom.scm
@@ -9,6 +9,7 @@
 ;;; Copyright © 2017 John Darrington <jmd@gnu.org>
 ;;; Copyright © 2017 Thomas Danckaert <post@thomasdanckaert.be>
 ;;; Copyright © 2017 Tobias Geerinckx-Rice <me@tobias.gr>
+;;; Copyright © 2017 ng0 <ng0@n0.is>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -694,3 +695,25 @@ distributed with CD images and are used to describe how tracks are
 laid out on the image.")
     (home-page "https://www.gnu.org/software/ccd2cue/")
     (license gpl3+)))
+
+(define-public libburn
+  (package
+    (name "libburn")
+    (version "1.4.6")
+    (source (origin
+             (method url-fetch)
+             (uri (string-append "http://files.libburnia-project.org/releases/"
+                                 "libburn-" version ".tar.gz"))
+             (sha256
+              (base32
+               "0wbh49s3az3sfpai09z1zdgynq7wnwrk31v5589033274nmzldlx"))))
+    (build-system gnu-build-system)
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+    (home-page "https://dev.lovelyhq.com/libburnia/libburn")
+    (synopsis "Library for reading and writing optical discs")
+    (description
+     "Libburn is a library for reading and writing optical discs.
+Supported media are: CD-R, CD-RW, DVD-RAM, DVD+RW, DVD+R, DVD+R/DL,
+DVD-RW, DVD-R, DVD-R/DL, BD-R, and BD-RE.")
+    (license gpl2)))
-- 
2.15.1


[-- Attachment #1.3: 0002-gnu-Add-libisofs.patch --]
[-- Type: text/plain, Size: 1899 bytes --]

From d1c0e9f52b76f5871087bb6f22a43b78dffb84cb Mon Sep 17 00:00:00 2001
From: ng0 <ng0@infotropique.org>
Date: Sat, 9 Sep 2017 13:59:39 +0000
Subject: [PATCH 2/4] gnu: Add libisofs.

* gnu/packages/cdrom.scm (libisofs): New variable.
---
 gnu/packages/cdrom.scm | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/gnu/packages/cdrom.scm b/gnu/packages/cdrom.scm
index f85a76891..c1adf174b 100644
--- a/gnu/packages/cdrom.scm
+++ b/gnu/packages/cdrom.scm
@@ -717,3 +717,32 @@ laid out on the image.")
 Supported media are: CD-R, CD-RW, DVD-RAM, DVD+RW, DVD+R, DVD+R/DL,
 DVD-RW, DVD-R, DVD-R/DL, BD-R, and BD-RE.")
     (license gpl2)))
+
+(define-public libisofs
+  (package
+    (name "libisofs")
+    (version "1.4.6")
+    (source (origin
+             (method url-fetch)
+             (uri (string-append "http://files.libburnia-project.org/releases/"
+                                 "libisofs-" version ".tar.gz"))
+             (sha256
+              (base32
+               "02m5g6lbmmkh2xc5xzq5zaf3ma6v31gls66aj886b3cq9qw0paql"))))
+    (build-system gnu-build-system)
+    (inputs
+     `(("zlib" ,zlib)
+       ("acl" ,acl)))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+    (home-page "https://dev.lovelyhq.com/libburnia/libisofs")
+    (synopsis "Library to create ISO 9660 images")
+    (description
+     "Libisofs creates ISO 9660 (also known as ECMA-119) filesystem images
+which can either be written to POSIX file objects or handed over to
+libburn for being written directly to optical media.
+It can read metadata of ISO 9660 filesystems, manipulate them, and use them
+to produce new complete filesystem images or add-on images to be appended
+to the read filesystem image.
+Supported extensions to ISO 9660 are Rock Ridge, Joliet, AAIP, zisofs.")
+    (license gpl2+)))
-- 
2.15.1


[-- Attachment #1.4: 0003-gnu-Add-xfburn.patch --]
[-- Type: text/plain, Size: 2706 bytes --]

From 359a219645aebdf3c16dd7086678f0856ad5ff6c Mon Sep 17 00:00:00 2001
From: ng0 <ng0@infotropique.org>
Date: Sat, 9 Sep 2017 14:11:36 +0000
Subject: [PATCH 3/4] gnu: Add xfburn.

* gnu/packages/xfce.scm (xfburn): New variable.
---
 gnu/packages/xfce.scm | 38 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index bbe6ab454..401409ab5 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -6,6 +6,7 @@
 ;;; Copyright © 2016 Kei Kebreau <kkebreau@posteo.net>
 ;;; Copyright © 2017 Ricardo Wurmus <rekado@elephly.net>
 ;;; Copyright © 2017 Petter <petter@mykolab.ch>
+;;; Copyright © 2017 ng0 <ng0@n0.is>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -32,6 +33,7 @@
   #:use-module (guix build-system trivial)
   #:use-module (gnu packages)
   #:use-module (gnu packages calendar)
+  #:use-module (gnu packages cdrom)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages glib)
   #:use-module (gnu packages gtk)
@@ -905,3 +907,39 @@ bubble in a standard way can implicitly make use of xfce4-notifyd to do so by
 sending standard messages over D-Bus using the
 @code{org.freedesktop.Notifications} interface.")
     (license gpl2)))
+
+(define-public xfburn
+  (package
+    (name "xfburn")
+    (version "0.5.4")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "http://archive.xfce.org/src/apps/xfburn/"
+                                  (version-major+minor version) "/"
+                                  name "-" version ".tar.bz2"))
+              (sha256
+               (base32
+                "1xn1kwxa3dl5r9bfj90a5322ynkwbn6k5v9b3a3pbr3a23zm604s"))))
+    (build-system gnu-build-system)
+    (native-inputs
+     `(("intltool" ,intltool)
+       ("pkg-config" ,pkg-config)))
+    (inputs
+     `(("exo" ,exo)
+       ("gstreamer" ,gstreamer)
+       ("gst-plugins-base" ,gst-plugins-base)
+       ("gst-plugins-good" ,gst-plugins-good)
+       ("gst-plugins-ugly" ,gst-plugins-ugly)
+       ("glib" ,glib)
+       ("gtk+" ,gtk+-2)
+       ("libburn" ,libburn)
+       ("libisofs" ,libisofs)
+       ("libxfce4ui" ,libxfce4ui)))
+    (home-page "https://goodies.xfce.org/projects/applications/xfburn")
+    (synopsis "GTK+ based CD, DVD and Blu-ray burning application")
+    (description
+     "Xfburn is a simple CD, DVD, and Blu-ray burning tool based on
+the libburnia libraries.  It can blank CD/DVD/BD(-RW)s, burn and
+create iso images, audio CDs, as well as burn personal compositions
+of data to either CD/DVD/BD.")
+    (license gpl2+)))
-- 
2.15.1


[-- Attachment #1.5: 0004-gnu-xorriso-Remove-bzip2-and-libcdio-from-inputs.patch --]
[-- Type: text/plain, Size: 967 bytes --]

From 1faecff1a27c8c82641ef146112f1b8a4d3898d5 Mon Sep 17 00:00:00 2001
From: ng0 <ng0@n0.is>
Date: Mon, 11 Dec 2017 09:29:40 +0000
Subject: [PATCH 4/4] gnu: xorriso: Remove 'bzip2' and 'libcdio' from inputs.

Thomas Schmitt suggested in bug#28398 to apply these changes.

* gnu/packages/cdrom.scm (xorriso)[inputs]: Remove 'bzip2' and 'libcdio'.
---
 gnu/packages/cdrom.scm | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/gnu/packages/cdrom.scm b/gnu/packages/cdrom.scm
index c1adf174b..228af1651 100644
--- a/gnu/packages/cdrom.scm
+++ b/gnu/packages/cdrom.scm
@@ -161,9 +161,7 @@ libcdio.")
     (inputs
      `(("acl" ,acl)
        ("readline" ,readline)
-       ("bzip2" ,bzip2)
-       ("zlib" ,zlib)
-       ("libcdio" ,libcdio)))
+       ("zlib" ,zlib)))
     (home-page "https://www.gnu.org/software/xorriso/")
     (synopsis "Create, manipulate, burn ISO-9660 file systems")
     (description
-- 
2.15.1


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply related	[flat|nested] 17+ messages in thread

* bug#28398: Xfburn
  2017-12-29 16:39                         ` ng0
@ 2018-02-01 23:04                           ` Christopher Baines
  0 siblings, 0 replies; 17+ messages in thread
From: Christopher Baines @ 2018-02-01 23:04 UTC (permalink / raw)
  To: ng0; +Cc: 28398-done, Thomas Schmitt

[-- Attachment #1: Type: text/plain, Size: 2062 bytes --]


ng0 <ng0@n0.is> writes:

> Thomas Schmitt transcribed 2.0K bytes:
>> Hi,
>> 
>> the patches look good to me (which does not have to mean much),
>> About the Xfburn 
>> 
>> ng0 wrote:
>> > 1. No Drive found (thanks Cpt. Obvious, I have no optical drive here).
>> 
>> You may at least try creating an ISO image file instead of burning.
>> Choose "New Data Composition", click the "+ Add" button, choose some
>> file by single click (double click crashes my local Xfburn), click
>> the "Add" button at the lower left, click "Proceed to Burn" at the
>> lower left, check "Only create ISO" and choose a file name for the ISO
>> image file.
>> 
>> There is a software emulator for some combinations of optical drives
>> and media types:
>>   http://cdemu.sourceforge.net/about
>> It is quite a poor surrogate to a real DVD or BD drive, but at least
>> the current bug carer of K3B uses it with some success.
>
> I didn't use cdemu - I would need to package that - but I mounted the data
> collection type .iso I recorded into an ISO file. From what I can tell, it works.
>
> I have issues with the icons, but that's just my personal WM/DM (which is pretty sminimal)
> and can be addressed later on (this is trivial and you just need the right icon set).
>
> I'll attach the latest patches.
> Let's just merge this now and address the rest later, okay?
> I have other issues I need to work on, and from where I stand this
> is done - all the basic issues have been fixed.
> I appreciate the help Thomas, thanks for what you have done. It's
> extraordinary, we usually don't get it like this.

Thanks for following up on this ng0. I've finally got around to looking
at Xfburn again and I've now pushed these 4 patches.

I ammended the commit message for the last one to add that the removed
inputs are not referenced by the output (before removing them), which
makes me more confident that something isn't breaking. As xorriso was
changed, I also ran the iso-image-installer test, and that passed.

Thanks again,

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]

^ permalink raw reply	[flat|nested] 17+ messages in thread

end of thread, other threads:[~2018-02-01 23:12 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-09 14:15 [bug#28398] Xfburn ng0
2017-09-15 11:41 ` ng0
2017-09-30 15:14 ` Christopher Baines
2017-09-30 15:33   ` ng0
2017-09-30 17:33     ` Christopher Baines
2017-10-01  8:34       ` Thomas Schmitt
2017-10-01 10:20         ` Thomas Schmitt
2017-11-29  9:14           ` ng0
2017-11-29 11:40             ` Thomas Schmitt
2017-11-29 14:37               ` ng0
2017-12-01 14:13               ` Ludovic Courtès
2017-12-01 16:06                 ` Thomas Schmitt
2017-12-04 14:06                   ` Ludovic Courtès
2017-12-11  9:58                     ` ng0
2017-12-11 11:02                       ` Thomas Schmitt
2017-12-29 16:39                         ` ng0
2018-02-01 23:04                           ` bug#28398: Xfburn Christopher Baines

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).