From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33839) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dyJTu-0007r3-UI for guix-patches@gnu.org; Sat, 30 Sep 2017 11:15:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dyJTq-0002c9-GX for guix-patches@gnu.org; Sat, 30 Sep 2017 11:15:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:60869) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dyJTq-0002bv-DW for guix-patches@gnu.org; Sat, 30 Sep 2017 11:15:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dyJTq-00069L-2E for guix-patches@gnu.org; Sat, 30 Sep 2017 11:15:02 -0400 Subject: [bug#28398] Xfburn Resent-Message-ID: Date: Sat, 30 Sep 2017 16:14:23 +0100 From: Christopher Baines Message-ID: <20170930161423.5a8f5a8d@cbaines.net> In-Reply-To: <20170909141504.5nhlbp5ocrygqwhw@abyayala> References: <20170909141504.5nhlbp5ocrygqwhw@abyayala> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/BcJQsmTPWag7OE/yVW3SqC="; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: ng0 Cc: 28398@debbugs.gnu.org --Sig_/BcJQsmTPWag7OE/yVW3SqC= Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sat, 9 Sep 2017 14:15:04 +0000 ng0 wrote: > This adds Xfburn + 2 libburnia packages it depends on. >=20 > What I could not test was actually burning a disk, > as I can't afford to buy new optical disks at the moment. >=20 > It builds. It builds for me too :) Looking at the libburn package. > + (synopsis "library for reading, mastering and writing optical > discs") guix lint says: gnu/packages/cdrom.scm:717:14: libburn@1.4.6: synopsis should start with an upper-case letter or digit > + (description > + "libburn is the library by which preformatted data get onto optical= media. > +It uses either @file{/dev/sgN} (e.g. on kernel 2.4 with ide-scsi) or @fi= le{/dev/srM} > +or @file{/dev/hdX} (e.g. on kernel 2.6). libburn is the foundation of t= he > +libburnia-project cdrecord emulation. Its code is independent of cdreco= rd.") I'm unsure about the first sentence, "libburn is the library" makes it sounds like there is only one library (this one) that does this. Would something like "libburn is a library to write preformatted data to optical media" work? Also, I don't get the cdrecord reference at the end. Looking at the libisofs package. > + (synopsis "library for reading, mastering and writing optical discs") guix lint says: gnu/packages/cdrom.scm:742:14: libisofs@1.4.6: synopsis should start with an upper-case letter or digit Also, this is the same as the libburn package, which probably means they need tweaking to be more useful. > + (description > + "libisofs is a library to create an ISO-9660 filesystem, supports e= xtensions I think this would read better split in to two sentences, as in "... filesystem. It supports" > +like RockRidge or Joliet, and introduces an own extension AAIP. It is a= full I think this would read better if you swap out "an" for "its". > +featured ISO-9660 editor which composes and changes the directory tree o= f an > +ISO image. This tree and its newly imported data file contents get then I think this would read better if you swap the order of "get" and "then", as in "imported data file contents then get". Looking finally at the xfburn package. The description seems a bit odd to me, as things like blanking CDs, or compositions are not terms I've heard commonly, but I think this is ok. I had some broken icons when I tried running this, and got some corresponding warnings, but this could be because I'm using Gnome and not XFCE. (xfburn:15797): Gtk-WARNING **: Error loading theme icon 'stock_xfburn-audio-cd' for stock: Icon 'stock_xfburn-audio-cd' not present in theme Thanks for the patches, and let me know if the proofreading the descriptions is helpful?=09 --Sig_/BcJQsmTPWag7OE/yVW3SqC= Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlnPtM9fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XefGg/+KMG8/48qSI6K5OcYZmze/SgSZ6n2y0U6Rnpv5uTxI6wIRQV8vRzN+g8f aplCGuaJaveX8+TKUKA2Y8vMwKnAjaJTforTWlxPfEp/2Hmug4uj6ACmH3f22Vv3 6fslf0/hkHHnNMQG8XL8pAp4CLhG/fVRkMpHBnMmidIm6k1b369/ZR9X5pCxylIE L9EASc5wbMJoB4vuxuuDyyZTFzjal2lJMuI7NlKhz9BfIXJBMPjctc88zeuearaz Wdj8dPDEeoj0Nvo6ReMnJ3wem63yKIz8m7gksYmUNCH24NYbMcDfyuiiCJkIavIO BEF9Unydsbzvd9yBC0YsdcDlGjojdJVS+HEkQpgZMGq3DsQGfSHNW4giNMnJpnJ3 B9WmKcglmxbSGU9fXJ0R/yQCU4+HbR+yGv2xmWZNOKxt4qTvk1rqXt/C0S65m/hM 7MeQAiIndXHb9G6wpFgibhuZDHA8pUMNmXEg7LFeVekoxSO7GbvPNDt9LcSCVUs1 oAG+Atxd1HlOp6/OKxuJQqsZfM+yr9z4/aUExgVVjHkUISw7sfGztg+quqKmWKY2 rNyFadAz3igD6ER8RH1CFwKaYLf8mgoM2h3LC4rzTy8aJ9w/3096I78RGlC2XDVX Sslx4LEZxPq8oy3nCZDlvuwBxq7LsPpwqloGs0DVd6XzNnfLLx0= =/OK3 -----END PGP SIGNATURE----- --Sig_/BcJQsmTPWag7OE/yVW3SqC=--