From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39745) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dyLeR-0002yn-4i for guix-patches@gnu.org; Sat, 30 Sep 2017 13:34:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dyLeN-0007iU-11 for guix-patches@gnu.org; Sat, 30 Sep 2017 13:34:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:60946) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dyLeM-0007i7-U5 for guix-patches@gnu.org; Sat, 30 Sep 2017 13:34:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dyLeM-0001E1-Dc for guix-patches@gnu.org; Sat, 30 Sep 2017 13:34:02 -0400 Subject: [bug#28398] Xfburn Resent-Message-ID: Date: Sat, 30 Sep 2017 18:33:35 +0100 From: Christopher Baines Message-ID: <20170930183335.0622f656@cbaines.net> In-Reply-To: <20170930153305.zxnazcebzcfodmez@abyayala> References: <20170909141504.5nhlbp5ocrygqwhw@abyayala> <20170930161423.5a8f5a8d@cbaines.net> <20170930153305.zxnazcebzcfodmez@abyayala> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/tftNRHnCs61O/txPSJupj6="; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: ng0 Cc: 28398@debbugs.gnu.org --Sig_/tftNRHnCs61O/txPSJupj6= Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sat, 30 Sep 2017 15:33:05 +0000 ng0 wrote: > Christopher Baines transcribed 3.8K bytes: > > On Sat, 9 Sep 2017 14:15:04 +0000 > > ng0 wrote: > > =20 > > Looking at the libburn package. > > =20 > > > + (synopsis "library for reading, mastering and writing optical > > > discs") I think this description better fits libburnia, rather than the specific libburn library. Maybe something like this would be more specific: "The libburn library is used to write preformatted data to optical media" > > > + (description > > > + "libburn is the library by which preformatted data get onto > > > optical media. +It uses either @file{/dev/sgN} (e.g. on kernel > > > 2.4 with ide-scsi) or @file{/dev/srM} +or @file{/dev/hdX} (e.g. > > > on kernel 2.6). libburn is the foundation of the > > > +libburnia-project cdrecord emulation. Its code is independent > > > of cdrecord.") =20 > >=20 > > I'm unsure about the first sentence, "libburn is the library" makes > > it sounds like there is only one library (this one) that does this. > > Would something like "libburn is a library to write preformatted > > data to optical media" work? > >=20 > > Also, I don't get the cdrecord reference at the end. =20 >=20 > Tbh I took this 1:1 from upstream. They don't really provide a good > insight into what's what as far as I remember. For the description, how about: libburn is a C library for writing to optical media, and has support for multiple different types of media (e.g. CD, DVD and BR). Included is the @command{cdrskin} command to burn data to CD or DVD. @command{cdrskin} emulates the behaviour of the @{cdrecord} command, but using the libburn library. > > Looking at the libisofs package. > > =20 > > > + (synopsis "library for reading, mastering and writing > > > optical discs") =20 > >=20 > > guix lint says: > >=20 > > gnu/packages/cdrom.scm:742:14: libisofs@1.4.6: synopsis should start > > with an upper-case letter or digit > >=20 > > Also, this is the same as the libburn package, which probably means > > they need tweaking to be more useful. For the libisofs synopsis, how about: Library for creating ISO 9660 filesystem images > > > + (description > > > + "libisofs is a library to create an ISO-9660 filesystem, > > > supports extensions =20 > >=20 > > I think this would read better split in to two sentences, as in "... > > filesystem. It supports" > > =20 > > > +like RockRidge or Joliet, and introduces an own extension AAIP. > > > It is a full =20 > >=20 > > I think this would read better if you swap out "an" for "its". > > =20 > > > +featured ISO-9660 editor which composes and changes the > > > directory tree of an +ISO image. This tree and its newly > > > imported data file contents get then =20 > >=20 > > I think this would read better if you swap the order of "get" and > > "then", as in "imported data file contents then get". > >=20 > > Looking finally at the xfburn package. > >=20 > > The description seems a bit odd to me, as things like blanking CDs, > > or compositions are not terms I've heard commonly, but I think this > > is ok. > >=20 > > I had some broken icons when I tried running this, and got some > > corresponding warnings, but this could be because I'm using Gnome > > and not XFCE. > >=20 > > (xfburn:15797): Gtk-WARNING **: Error loading theme icon > > 'stock_xfburn-audio-cd' for stock: Icon 'stock_xfburn-audio-cd' not > > present in theme =20 >=20 > Not a blocking issue (the icons) but Xfburn is not limited to Xfce, > so we should figure out which icon-set is needed. I agree. > > Thanks for the patches, and let me know if the proofreading the > > descriptions is helpful? =20 >=20 > Well I still don't know more about burning disk application interiors. > Can you come up with better descriptions? > It is hard for me to take > https://dev.lovelyhq.com/libburnia/web/wikis/home and the > descriptions linked in there and to decide what is useful. Most of the comments I made were about the use of English. I've now written some suggestions above where I commented on the content. --Sig_/tftNRHnCs61O/txPSJupj6= Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlnP1W9fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XenEg/8CnuptZVpig7ySw9bY3qLal7JuzStv2jEseIgzZwKFQfY2aknXHZov/11 ESqya3WhVsE8rP7YDCTUNPIz2b3ohiKMq+QqDYJDH3cfCeBLHDBzL5qnfJuHCYLO LlsJyAadK/tEsqhYZ6h5FevYzJe67xVOebEvcMjcVjLdlwmfHW/LPpvT8BesyFZL 8RXvEvAZhxHO7jS4xgMenrjxMVJ9ExPfMvD/a0Qn33dOYRBLWipyKHOCKM18vV0D sdzU/699WptziGscllWVrEhKOupJsbNxwoKxQKne9IDZiX/UPct4ldMRELJfvL9c a8FmrZEdowR0PUOPDWgA+9ncOiKBl90BKiGkKqMBf9mtbScfgBo7MzuMkqgx6GTh QjxYlbOO76etG5fhunqhTWkwW8WDmsvoHtgM5fCyfW1YNjuQgG8fqrCY85/gyLtr 9PKIA1mAhdoGVeMKwXElEkztl4WN3LU6Dk6yeyOFz+IF2b03Nt2hj2x9CmWGwzmt mYlD9qWnjGov5HwxLFSfR+tp37lqI6Xz7tCLVvM2jQhAoAGdBrkMhaZzw2Ju4lH8 fYBhSasfdiFRTl70DyM+huX1lSLf3vtJ+toi9EmnHP9SEz3xjNXZK3sbeCCWqb9l 5+z9XS5hDwh+nyxEJrvHxyDgpJ1EOgD6GmtvftsjpPHRTr/nC6I= =fZ9u -----END PGP SIGNATURE----- --Sig_/tftNRHnCs61O/txPSJupj6=--