unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: ng0 <ng0@infotropique.org>
To: Christopher Baines <mail@cbaines.net>
Cc: 28398@debbugs.gnu.org
Subject: [bug#28398] Xfburn
Date: Sat, 30 Sep 2017 15:33:05 +0000	[thread overview]
Message-ID: <20170930153305.zxnazcebzcfodmez@abyayala> (raw)
In-Reply-To: <20170930161423.5a8f5a8d@cbaines.net>

[-- Attachment #1: Type: text/plain, Size: 3615 bytes --]

Christopher Baines transcribed 3.8K bytes:
> On Sat, 9 Sep 2017 14:15:04 +0000
> ng0 <ng0@infotropique.org> wrote:
> 
> > This adds Xfburn + 2 libburnia packages it depends on.
> > 
> > What I could not test was actually burning a disk,
> > as I can't afford to buy new optical disks at the moment.
> > 
> > It builds.
> 
> It builds for me too :)
> 
> Looking at the libburn package.
> 
> > +    (synopsis "library for reading, mastering and writing optical
> > discs")
> 
> guix lint says:
> 
> gnu/packages/cdrom.scm:717:14: libburn@1.4.6: synopsis should start
> with an upper-case letter or digit

Ok.

> > +    (description
> > +     "libburn is the library by which preformatted data get onto optical media.
> > +It uses either @file{/dev/sgN} (e.g. on kernel 2.4 with ide-scsi) or @file{/dev/srM}
> > +or @file{/dev/hdX} (e.g. on kernel 2.6).  libburn is the foundation of the
> > +libburnia-project cdrecord emulation.  Its code is independent of cdrecord.")
> 
> I'm unsure about the first sentence, "libburn is the library" makes it
> sounds like there is only one library (this one) that does this. Would
> something like "libburn is a library to write preformatted data to
> optical media" work?
> 
> Also, I don't get the cdrecord reference at the end.

Tbh I took this 1:1 from upstream. They don't really provide a good insight into
what's what as far as I remember.

> Looking at the libisofs package.
> 
> > +    (synopsis "library for reading, mastering and writing optical discs")
> 
> guix lint says:
> 
> gnu/packages/cdrom.scm:742:14: libisofs@1.4.6: synopsis should start
> with an upper-case letter or digit
> 
> Also, this is the same as the libburn package, which probably means
> they need tweaking to be more useful.
> 
> > +    (description
> > +     "libisofs is a library to create an ISO-9660 filesystem, supports extensions
> 
> I think this would read better split in to two sentences, as in "...
> filesystem.  It supports"
> 
> > +like RockRidge or Joliet, and introduces an own extension AAIP.  It is a full
> 
> I think this would read better if you swap out "an" for "its".
> 
> > +featured ISO-9660 editor which composes and changes the directory tree of an
> > +ISO image.  This tree and its newly imported data file contents get then
> 
> I think this would read better if you swap the order of "get" and
> "then", as in "imported data file contents then get".
> 
> Looking finally at the xfburn package.
> 
> The description seems a bit odd to me, as things like blanking CDs, or
> compositions are not terms I've heard commonly, but I think this is ok.
> 
> I had some broken icons when I tried running this, and got some
> corresponding warnings, but this could be because I'm using Gnome and
> not XFCE.
> 
> (xfburn:15797): Gtk-WARNING **: Error loading theme icon
> 'stock_xfburn-audio-cd' for stock: Icon 'stock_xfburn-audio-cd' not
> present in theme

Not a blocking issue (the icons) but Xfburn is not limited to Xfce,
so we should figure out which icon-set is needed.

> 
> Thanks for the patches, and let me know if the proofreading the
> descriptions is helpful?	

Well I still don't know more about burning disk application interiors.
Can you come up with better descriptions?
It is hard for me to take https://dev.lovelyhq.com/libburnia/web/wikis/home
and the descriptions linked in there and to decide what is useful.
-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://krosos.org/dist/keys/
https://www.infotropique.org https://krosos.org

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2017-09-30 15:34 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-09 14:15 [bug#28398] Xfburn ng0
2017-09-15 11:41 ` ng0
2017-09-30 15:14 ` Christopher Baines
2017-09-30 15:33   ` ng0 [this message]
2017-09-30 17:33     ` Christopher Baines
2017-10-01  8:34       ` Thomas Schmitt
2017-10-01 10:20         ` Thomas Schmitt
2017-11-29  9:14           ` ng0
2017-11-29 11:40             ` Thomas Schmitt
2017-11-29 14:37               ` ng0
2017-12-01 14:13               ` Ludovic Courtès
2017-12-01 16:06                 ` Thomas Schmitt
2017-12-04 14:06                   ` Ludovic Courtès
2017-12-11  9:58                     ` ng0
2017-12-11 11:02                       ` Thomas Schmitt
2017-12-29 16:39                         ` ng0
2018-02-01 23:04                           ` bug#28398: Xfburn Christopher Baines

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170930153305.zxnazcebzcfodmez@abyayala \
    --to=ng0@infotropique.org \
    --cc=28398@debbugs.gnu.org \
    --cc=mail@cbaines.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).