unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
* [PATCH] gnu: maxima: Update to 5.39.0.
@ 2016-12-17 21:09 Kei Kebreau
  2016-12-18 15:41 ` Marius Bakke
  0 siblings, 1 reply; 7+ messages in thread
From: Kei Kebreau @ 2016-12-17 21:09 UTC (permalink / raw)
  To: guix-devel


[-- Attachment #1.1: Type: text/plain, Size: 289 bytes --]

This was supposed to be a simple version bump for Maxima, but it has
come to my attention that Maxima hasn't built reproducibily for quite a
while now (since version 5.36.1 according to my tests, possibly
further). Is there any particular reason why? I can't seem to pinpoint
the cause.



[-- Attachment #1.2: 0001-gnu-maxima-Update-to-5.39.0.patch --]
[-- Type: text/plain, Size: 1175 bytes --]

From 0c43d0a7838d3b1133265dc4137451cc8986c02d Mon Sep 17 00:00:00 2001
From: Kei Kebreau <kei@openmailbox.org>
Date: Sat, 17 Dec 2016 16:03:46 -0500
Subject: [PATCH] gnu: maxima: Update to 5.39.0.

* gnu/packages/maths.scm (maxima): Update to 5.39.0.
---
 gnu/packages/maths.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
index ce7eecfa7..7ce00c8dc 100644
--- a/gnu/packages/maths.scm
+++ b/gnu/packages/maths.scm
@@ -1857,7 +1857,7 @@ to BMP, JPEG or PNG image formats.")
 (define-public maxima
   (package
     (name "maxima")
-    (version "5.38.1")
+    (version "5.39.0")
     (source
      (origin
        (method url-fetch)
@@ -1865,7 +1865,7 @@ to BMP, JPEG or PNG image formats.")
                            version "-source/" name "-" version ".tar.gz"))
        (sha256
         (base32
-         "1p6646rvq43hk09msyp0dk50cqpkh07mf4x0bc2fqisqmcv6b1hf"))
+         "1cvignn5y6qzrby6qb885yc8zdcdqdr1d50vcvc3gapw2f0gk3zm"))
        (patches (search-patches "maxima-defsystem-mkdir.patch"))))
     (build-system gnu-build-system)
     (inputs
-- 
2.11.0


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH] gnu: maxima: Update to 5.39.0.
  2016-12-17 21:09 [PATCH] gnu: maxima: Update to 5.39.0 Kei Kebreau
@ 2016-12-18 15:41 ` Marius Bakke
  2016-12-18 17:59   ` Kei Kebreau
  0 siblings, 1 reply; 7+ messages in thread
From: Marius Bakke @ 2016-12-18 15:41 UTC (permalink / raw)
  To: Kei Kebreau, guix-devel

[-- Attachment #1: Type: text/plain, Size: 905 bytes --]

Kei Kebreau <kei@openmailbox.org> writes:

> This was supposed to be a simple version bump for Maxima, but it has
> come to my attention that Maxima hasn't built reproducibily for quite a
> while now (since version 5.36.1 according to my tests, possibly
> further). Is there any particular reason why? I can't seem to pinpoint
> the cause.

The patch looks good. Are you sure it was reproducible before?

I've found 'diffoscope' to be useful when troubleshooting
reproducibility problems. E.g. by running it on two cancelled builds, or
by installing to different output paths with a superficial change to the
expression. It will show sections that differs which may aid locating
the offending code.

For C family programs, a "hail mary" grep for __DATE__ or __TIME__ can
be enough. Tobias suggested making those return a fixed value, which I
think could be worthwhile, at least for the build environment.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] gnu: maxima: Update to 5.39.0.
  2016-12-18 15:41 ` Marius Bakke
@ 2016-12-18 17:59   ` Kei Kebreau
  2016-12-18 18:34     ` Marius Bakke
  2016-12-18 18:35     ` Leo Famulari
  0 siblings, 2 replies; 7+ messages in thread
From: Kei Kebreau @ 2016-12-18 17:59 UTC (permalink / raw)
  To: Marius Bakke; +Cc: guix-devel

[-- Attachment #1: Type: text/plain, Size: 1278 bytes --]

Marius Bakke <mbakke@fastmail.com> writes:

> Kei Kebreau <kei@openmailbox.org> writes:
>
>> This was supposed to be a simple version bump for Maxima, but it has
>> come to my attention that Maxima hasn't built reproducibily for quite a
>> while now (since version 5.36.1 according to my tests, possibly
>> further). Is there any particular reason why? I can't seem to pinpoint
>> the cause.
>
> The patch looks good. Are you sure it was reproducible before?
>

That's the thing; I'm not sure! I'll being investigating, though.

> I've found 'diffoscope' to be useful when troubleshooting
> reproducibility problems. E.g. by running it on two cancelled builds, or
> by installing to different output paths with a superficial change to the
> expression. It will show sections that differs which may aid locating
> the offending code.
>

Yes. I see that diffoscope complains about missing 'xxd'. That may be
useful to package (unless we already have it and I'm just oblivious).

> For C family programs, a "hail mary" grep for __DATE__ or __TIME__ can
> be enough. Tobias suggested making those return a fixed value, which I
> think could be worthwhile, at least for the build environment.

Cool. I'll remember this tip.

Patch pushed as 4a652c78d425bfd76c2baba510ecd255b22b4714.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] gnu: maxima: Update to 5.39.0.
  2016-12-18 17:59   ` Kei Kebreau
@ 2016-12-18 18:34     ` Marius Bakke
  2016-12-18 19:10       ` Leo Famulari
  2016-12-18 18:35     ` Leo Famulari
  1 sibling, 1 reply; 7+ messages in thread
From: Marius Bakke @ 2016-12-18 18:34 UTC (permalink / raw)
  To: Kei Kebreau; +Cc: guix-devel

[-- Attachment #1: Type: text/plain, Size: 633 bytes --]

Kei Kebreau <kei@openmailbox.org> writes:

>> I've found 'diffoscope' to be useful when troubleshooting
>> reproducibility problems. E.g. by running it on two cancelled builds, or
>> by installing to different output paths with a superficial change to the
>> expression. It will show sections that differs which may aid locating
>> the offending code.
>>
>
> Yes. I see that diffoscope complains about missing 'xxd'. That may be
> useful to package (unless we already have it and I'm just oblivious).

'xxd' is distributed with the 'vim' package. Is the error fatal? Perhaps
we should patch diffoscope with the absolute path to xxd.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] gnu: maxima: Update to 5.39.0.
  2016-12-18 17:59   ` Kei Kebreau
  2016-12-18 18:34     ` Marius Bakke
@ 2016-12-18 18:35     ` Leo Famulari
  2016-12-19  4:50       ` Kei Kebreau
  1 sibling, 1 reply; 7+ messages in thread
From: Leo Famulari @ 2016-12-18 18:35 UTC (permalink / raw)
  To: Kei Kebreau; +Cc: guix-devel

[-- Attachment #1: Type: text/plain, Size: 338 bytes --]

On Sun, Dec 18, 2016 at 12:59:33PM -0500, Kei Kebreau wrote:
> Yes. I see that diffoscope complains about missing 'xxd'. That may be
> useful to package (unless we already have it and I'm just oblivious).

Does it break diffoscope or is it just a warning? Either way, we should
try to build diffoscope with all its optional dependencies.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] gnu: maxima: Update to 5.39.0.
  2016-12-18 18:34     ` Marius Bakke
@ 2016-12-18 19:10       ` Leo Famulari
  0 siblings, 0 replies; 7+ messages in thread
From: Leo Famulari @ 2016-12-18 19:10 UTC (permalink / raw)
  To: Marius Bakke; +Cc: guix-devel

[-- Attachment #1: Type: text/plain, Size: 913 bytes --]

On Sun, Dec 18, 2016 at 07:34:32PM +0100, Marius Bakke wrote:
> Kei Kebreau <kei@openmailbox.org> writes:
> 
> >> I've found 'diffoscope' to be useful when troubleshooting
> >> reproducibility problems. E.g. by running it on two cancelled builds, or
> >> by installing to different output paths with a superficial change to the
> >> expression. It will show sections that differs which may aid locating
> >> the offending code.
> >>
> >
> > Yes. I see that diffoscope complains about missing 'xxd'. That may be
> > useful to package (unless we already have it and I'm just oblivious).
> 
> 'xxd' is distributed with the 'vim' package. Is the error fatal? Perhaps
> we should patch diffoscope with the absolute path to xxd.

The warning message in the source code is:

"xxd not available in path. Falling back to Python hexlify."

So, I guess the built-in hexlify is a fine fall-back for now.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] gnu: maxima: Update to 5.39.0.
  2016-12-18 18:35     ` Leo Famulari
@ 2016-12-19  4:50       ` Kei Kebreau
  0 siblings, 0 replies; 7+ messages in thread
From: Kei Kebreau @ 2016-12-19  4:50 UTC (permalink / raw)
  To: Leo Famulari; +Cc: guix-devel

[-- Attachment #1: Type: text/plain, Size: 592 bytes --]

Leo Famulari <leo@famulari.name> writes:

> On Sun, Dec 18, 2016 at 12:59:33PM -0500, Kei Kebreau wrote:
>> Yes. I see that diffoscope complains about missing 'xxd'. That may be
>> useful to package (unless we already have it and I'm just oblivious).
>
> Does it break diffoscope or is it just a warning? Either way, we should
> try to build diffoscope with all its optional dependencies.

I see that you've already answered your question. To both of you, I
expect that using xxd provides some benefit. For what it's worth, in
Debian xxd/vim-common is recommended when installing diffoscope.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2016-12-19  4:50 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-17 21:09 [PATCH] gnu: maxima: Update to 5.39.0 Kei Kebreau
2016-12-18 15:41 ` Marius Bakke
2016-12-18 17:59   ` Kei Kebreau
2016-12-18 18:34     ` Marius Bakke
2016-12-18 19:10       ` Leo Famulari
2016-12-18 18:35     ` Leo Famulari
2016-12-19  4:50       ` Kei Kebreau

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).