From: Eric Bavier <ericbavier@centurylink.net>
To: Petter <petter@mykolab.ch>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add cool-retro-term.
Date: Thu, 4 May 2017 22:03:24 -0500 [thread overview]
Message-ID: <20170504220324.46b64183@centurylink.net> (raw)
In-Reply-To: <20170503143753.0b40c54b@mykolab.ch>
[-- Attachment #1: Type: text/plain, Size: 4808 bytes --]
Hello Petter,
Pushed as f9ff014bf623071b9343265e8a5aa994a10ec9d4 !
I ended up whitelisting a few more of the fonts, after verifying their
licenses, and made some more specific notes on the license of each
font.
I had to add $out/qml to the wrapper QML2_IMPORT_PATH in order for crt
to start up. I figured that was alright, since that path was present
in your initial patch.
I added the patches to dist_patch_DATA in gnu/local.mk and listed them
in the commit log too.
It even builds with "--rounds=2" :)
Thanks again,
`~Eric
On Wed, 3 May 2017 14:37:53 +0200
Petter <petter@mykolab.ch> wrote:
> On Tue, 2 May 2017 08:51:06 -0500
> Eric Bavier <ericbavier@centurylink.net> wrote:
>
> > Hi Petter,
> >
> > Thanks again for your patience with this review.
>
> Hi Eric,
>
> I'm in no rush :)
>
> > "gpl2" in the license field should be "gpl2+" according to
> > qmltermwidget license headers. Could you also include a comment noting
> > the component split? Nothing fancy, just "for qmltermwidget" or so next
> > to gpl2+ and "for cool-retro-term" next to gpl3+.
>
> Done. I did it like this:
> (license (list
> license:gpl2+ ; qmltermwidget
> license:gpl3+ ; cool-retro-term
> ;; Fonts
> license:silofl1.1
> license:x11)))))
>
> > > > > > and the fonts/1977-apple2, fonts/1977-commodore-pet, probably also
> > > > > > needs to be stripped as non-free; from 'FreeLicense.txt':
> > > > > >
> > > > > > "1. The User may not sell copies of the Software for a fee."
> > > > > >
> > > > > > The fonts/1979-atari-400-800 font seems to be non-free license, which
> > > > > > is not mentioned in the 'ReadMe.rtf' but only on the WayBack Machine
> > > > > > at
> > > > > > https://web-beta.archive.org/web/20080907111008/http://www2.bitstream.net/~marksim/atarimac/fonts.html :
> > > > > >
> > > > > > "These fonts are freeware and may not be offered for sale seperately
> > > > > > or as part of a collection."
> > > > > >
> > > > > > The fonts/1982-commodore64 font is licensed under non-free terms; see
> > > > > > fonts/1982-commodore64/license.txt
> > > > > >
> > > > > > The only mention of a license for fonts/1985-ibm-pc-vga is at
> > > > > > http://www.dafont.com/font-comment.php?file=perfect_dos_vga_437 where
> > > > > > the author says "The license is this: this font is free to use in
> > > > > > whatever you want.", but that probably "doesn't count".
> > > > > >
> > > > > > I could not find license info for a few of the other fonts.
> > > > > >
> > > > > > OTOH I recall a discussion on IRC recently about fonts embedded in
> > > > > > packages being treated as non-functional data, and thus OK from a FSDG
> > > > > > perspective. But I would want verification on that.
> > > > >
> > > > > Let's see if someone can shine some light on this.
> > > > >
> > > >
> > > > Leo pointed me at https://bugs.gnu.org/26588 which references
> > > > https://www.gnu.org/distros/free-system-distribution-guidelines.html#non-functional-data .
> > > > I think many of these fonts would need to be stripped out or
> > > > substituted because their license prohibits commercial/non-commercial
> > > > redistribution.
> > >
> > > Recipe is now removing the following from disk and GUI:
> > > '("1977-apple2"
> > > "1977-commodore-pet"
> > > "1979-atari-400-800"
> > > "1982-commodore64"
> > > "1985-ibm-pc-vga")
> >
> > The code you've added to delete these fonts and adjust the source
> > accordingly would be better in an origin 'snippet' so that `guix build
> > -S cool-retro-term` does not include the fonts.
>
> Done.
>
> > >
> > > Should more be removed?
> >
> > modern-monaco. It's a font from Apple which is specifically *not*
> > freely distributable, but the ttf file is still floating around the
> > internet, giving many projects the impression that it is.
> >
> > >
> > > What do we do about the fonts without licensing info?
> >
> > I agree with Chris that we need to remove them.
>
> Right, I've made the mental switch now to whitelist rather than blacklist.
> The ones that are included now are modern-hermit, modern-pro-font-win-tweaked
> and modern-proggy-tiny. The rest are out until proven Free.
>
> Let me know if there are other fonts /we can include/ ;)
>
>
> Also added a `crt` as a symlink to cool-retro-term.
>
>
> Thanks Eric and Chris for being so thorough and helpful! Let me know if there
> are more issues.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2017-05-05 3:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-23 11:55 [PATCH] gnu: Add cool-retro-term Petter
2017-04-23 19:18 ` Chris Marusich
2017-04-23 21:12 ` Petter
2017-04-23 23:31 ` Chris Marusich
2017-04-24 12:30 ` Petter
2017-04-26 3:36 ` Eric Bavier
2017-04-26 18:09 ` Petter
2017-04-28 1:47 ` Eric Bavier
2017-04-28 12:10 ` Petter
2017-04-30 20:59 ` Chris Marusich
2017-05-03 11:38 ` Petter
2017-05-02 13:51 ` Eric Bavier
2017-05-03 12:37 ` Petter
2017-05-05 3:03 ` Eric Bavier [this message]
2017-05-05 22:58 ` Petter
2017-05-08 9:39 ` Efraim Flashner
2017-04-30 20:47 ` Chris Marusich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170504220324.46b64183@centurylink.net \
--to=ericbavier@centurylink.net \
--cc=guix-devel@gnu.org \
--cc=petter@mykolab.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).