From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Bavier Subject: Re: [PATCH] gnu: Add cool-retro-term. Date: Thu, 4 May 2017 22:03:24 -0500 Message-ID: <20170504220324.46b64183@centurylink.net> References: <20170423135526.5ed9d143@mykolab.ch> <87inlvhr0y.fsf@gmail.com> <20170423231207.4adb15e7@mykolab.ch> <87vapuwvj0.fsf@gmail.com> <20170424143026.53563696@mykolab.ch> <20170425223627.47d5a3fc@centurylink.net> <20170426200933.45340e03@mykolab.ch> <20170427204754.10212a01@centurylink.net> <20170428141037.6a4038f6@mykolab.ch> <20170502085106.434f29ff@centurylink.net> <20170503143753.0b40c54b@mykolab.ch> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/f38HS5VE0Ol6I7Cr7Oc6+An"; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:55374) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d6TWo-0002iQ-5Y for guix-devel@gnu.org; Thu, 04 May 2017 23:03:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d6TWk-0007aQ-4z for guix-devel@gnu.org; Thu, 04 May 2017 23:03:34 -0400 Received: from mail.centurylink.net ([205.219.233.9]:26689 helo=smtp.centurylink.net) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d6TWj-0007YS-MV for guix-devel@gnu.org; Thu, 04 May 2017 23:03:30 -0400 In-Reply-To: <20170503143753.0b40c54b@mykolab.ch> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Petter Cc: guix-devel@gnu.org --Sig_/f38HS5VE0Ol6I7Cr7Oc6+An Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hello Petter, Pushed as f9ff014bf623071b9343265e8a5aa994a10ec9d4 ! I ended up whitelisting a few more of the fonts, after verifying their licenses, and made some more specific notes on the license of each font. I had to add $out/qml to the wrapper QML2_IMPORT_PATH in order for crt to start up. I figured that was alright, since that path was present in your initial patch. I added the patches to dist_patch_DATA in gnu/local.mk and listed them in the commit log too. It even builds with "--rounds=3D2" :) Thanks again, `~Eric On Wed, 3 May 2017 14:37:53 +0200 Petter wrote: > On Tue, 2 May 2017 08:51:06 -0500 > Eric Bavier wrote: >=20 > > Hi Petter, > >=20 > > Thanks again for your patience with this review. =20 >=20 > Hi Eric, >=20 > I'm in no rush :) >=20 > > "gpl2" in the license field should be "gpl2+" according to > > qmltermwidget license headers. Could you also include a comment noting > > the component split? Nothing fancy, just "for qmltermwidget" or so next > > to gpl2+ and "for cool-retro-term" next to gpl3+. =20 >=20 > Done. I did it like this: > (license (list=20 > license:gpl2+ ; qmltermwidget > license:gpl3+ ; cool-retro-term > ;; Fonts > license:silofl1.1 > license:x11))))) >=20 > > > > > > and the fonts/1977-apple2, fonts/1977-commodore-pet, probably a= lso > > > > > > needs to be stripped as non-free; from 'FreeLicense.txt': > > > > > >=20 > > > > > > "1. The User may not sell copies of the Software for a fee." > > > > > >=20 > > > > > > The fonts/1979-atari-400-800 font seems to be non-free license,= which > > > > > > is not mentioned in the 'ReadMe.rtf' but only on the WayBack Ma= chine > > > > > > at > > > > > > https://web-beta.archive.org/web/20080907111008/http://www2.bit= stream.net/~marksim/atarimac/fonts.html : > > > > > >=20 > > > > > > "These fonts are freeware and may not be offered for sale sep= erately > > > > > > or as part of a collection." > > > > > >=20 > > > > > > The fonts/1982-commodore64 font is licensed under non-free term= s; see > > > > > > fonts/1982-commodore64/license.txt > > > > > >=20 > > > > > > The only mention of a license for fonts/1985-ibm-pc-vga is at > > > > > > http://www.dafont.com/font-comment.php?file=3Dperfect_dos_vga_4= 37 where > > > > > > the author says "The license is this: this font is free to use = in > > > > > > whatever you want.", but that probably "doesn't count". > > > > > >=20 > > > > > > I could not find license info for a few of the other fonts. > > > > > >=20 > > > > > > OTOH I recall a discussion on IRC recently about fonts embedded= in > > > > > > packages being treated as non-functional data, and thus OK from= a FSDG > > > > > > perspective. But I would want verification on that. =20 > > > > >=20 > > > > > Let's see if someone can shine some light on this. > > > > > =20 > > > >=20 > > > > Leo pointed me at https://bugs.gnu.org/26588 which references > > > > https://www.gnu.org/distros/free-system-distribution-guidelines.htm= l#non-functional-data . > > > > I think many of these fonts would need to be stripped out or > > > > substituted because their license prohibits commercial/non-commerci= al > > > > redistribution. =20 > > >=20 > > > Recipe is now removing the following from disk and GUI: > > > '("1977-apple2" > > > "1977-commodore-pet" > > > "1979-atari-400-800" > > > "1982-commodore64" > > > "1985-ibm-pc-vga") =20 > >=20 > > The code you've added to delete these fonts and adjust the source > > accordingly would be better in an origin 'snippet' so that `guix build > > -S cool-retro-term` does not include the fonts. =20 >=20 > Done. >=20 > > >=20 > > > Should more be removed? =20 > >=20 > > modern-monaco. It's a font from Apple which is specifically *not* > > freely distributable, but the ttf file is still floating around the > > internet, giving many projects the impression that it is. > > =20 > > >=20 > > > What do we do about the fonts without licensing info? =20 > >=20 > > I agree with Chris that we need to remove them. =20 >=20 > Right, I've made the mental switch now to whitelist rather than blacklist. > The ones that are included now are modern-hermit, modern-pro-font-win-twe= aked > and modern-proggy-tiny. The rest are out until proven Free. >=20 > Let me know if there are other fonts /we can include/ ;) >=20 >=20 > Also added a `crt` as a symlink to cool-retro-term. >=20 >=20 > Thanks Eric and Chris for being so thorough and helpful! Let me know if t= here > are more issues. --Sig_/f38HS5VE0Ol6I7Cr7Oc6+An Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEP6ffQNOS1+XjkicBHrvSBHgfliwFAlkL63wACgkQHrvSBHgf liwrBAgAzj1MxybBgJrNOCMaMbHN+HBRxsM52fZP5vM/gmUoXyBB6p/3CO3oY/w5 YVUdMMy46PgN1OsC2utm3YNs+NedGAKdk39eAGiHFxIBgnRlkE1sFr8ApHtNT3Iu cfPxi6vA8uaF97aSU3RYEyLXtY7kcZe74nmtA4BIBq9N9px9u2uvtueb44EZw0mE I9UmcUfIyEm6F5TrET1C8r5ocyFsaX5YY61H1TmZgqxbyOP3HEgRuVRDZnEPsOTg vz24FgkO31e5sf7ft1dqsIjwUPgaRxcHqJKv98ArHfY7Wg57MVibhhatxhc7t58t NPKmnhECW+mZknVX54Vk2a2JHq9Drg== =7tiD -----END PGP SIGNATURE----- --Sig_/f38HS5VE0Ol6I7Cr7Oc6+An--