From: Chris Marusich <cmmarusich@gmail.com>
To: Petter <petter@mykolab.ch>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add cool-retro-term.
Date: Sun, 23 Apr 2017 12:18:05 -0700 [thread overview]
Message-ID: <87inlvhr0y.fsf@gmail.com> (raw)
In-Reply-To: <20170423135526.5ed9d143@mykolab.ch> (petter@mykolab.ch's message of "Sun, 23 Apr 2017 13:55:26 +0200")
[-- Attachment #1: Type: text/plain, Size: 1995 bytes --]
Petter <petter@mykolab.ch> writes:
> Hi Guix,
>
> The past is finally here! Had a go at packaging a terminal emulator
> which mimics old cathode displays :)
Wow!! This is really fun. Thanks for packaging it!
> + (modify-phases %standard-phases
> + (replace 'configure
> + (lambda* (#:key outputs #:allow-other-keys)
> + (let ((out (assoc-ref outputs "out")))
> + (substitute* '("qmltermwidget/qmltermwidget.pro")
> + (("INSTALL_DIR = \\$\\$\\[QT_INSTALL_QML\\]")
> + (string-append "INSTALL_DIR = " out "/qml")))
> + (substitute* '("app/app.pro")
> + (("target.path \\+= /usr")
> + (string-append "target.path += " out))
> + (("icon32.path = /usr/share")
> + (string-append "icon32.path = " out))
> + (("icon64.path = /usr/share")
> + (string-append "icon64.path = " out))
> + (("icon128.path = /usr/share")
> + (string-append "icon128.path = " out))
> + (("icon256.path = /usr/share")
> + (string-append "icon256.path = " out)))
> + (zero? (system* "qmake")))))
Should these icons be put somewhere else, like in the $out/share path?
If it works, it works, though. (info '(standards) Directory Variables'):
> + (synopsis "terminal emulator which mimics the look and feel of the old
> +cathode tube screens")
> + (description
> + "Cool-retro-term is a terminal emulator which mimics the look and feel of
> +the old cathode tube screens. It has been designed to be eye-candy,
> +customizable, and reasonably lightweight.")
Just minor feedback: Maybe use the phrases "CRT" and "cathode ray tube"
to make this easier to discover?
--
Chris
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2017-04-23 19:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-23 11:55 [PATCH] gnu: Add cool-retro-term Petter
2017-04-23 19:18 ` Chris Marusich [this message]
2017-04-23 21:12 ` Petter
2017-04-23 23:31 ` Chris Marusich
2017-04-24 12:30 ` Petter
2017-04-26 3:36 ` Eric Bavier
2017-04-26 18:09 ` Petter
2017-04-28 1:47 ` Eric Bavier
2017-04-28 12:10 ` Petter
2017-04-30 20:59 ` Chris Marusich
2017-05-03 11:38 ` Petter
2017-05-02 13:51 ` Eric Bavier
2017-05-03 12:37 ` Petter
2017-05-05 3:03 ` Eric Bavier
2017-05-05 22:58 ` Petter
2017-05-08 9:39 ` Efraim Flashner
2017-04-30 20:47 ` Chris Marusich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87inlvhr0y.fsf@gmail.com \
--to=cmmarusich@gmail.com \
--cc=guix-devel@gnu.org \
--cc=petter@mykolab.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).