From: Chris Marusich <cmmarusich@gmail.com>
To: Petter <petter@mykolab.ch>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add cool-retro-term.
Date: Sun, 23 Apr 2017 16:31:47 -0700 [thread overview]
Message-ID: <87vapuwvj0.fsf@gmail.com> (raw)
In-Reply-To: <20170423231207.4adb15e7@mykolab.ch> (petter@mykolab.ch's message of "Sun, 23 Apr 2017 23:12:07 +0200")
[-- Attachment #1: Type: text/plain, Size: 1464 bytes --]
Hi Petter,
> + (synopsis "Terminal emulator which mimics the look and feel of the
> old +cathode ray tube screens")
> + (description
> + "Cool-retro-term (CRT) is a terminal emulator which mimics the
> look and +feel of the old cathode ray tube (CRT) screens. It has been
> designed to be +eye-candy, customizable, and reasonably lightweight.")
Oh! I didn't even realize that the name was a play on words. Cute.
By the way, the output of 'guix lint' points out the following:
--8<---------------cut here---------------start------------->8---
[0] marusich@garuda:~/guix
$ ./pre-inst-env guix lint cool-retro-term
gnu/packages/terminals.scm:493:5: cool-retro-term@1.0.0-1.e4871
9f: sentences in description should be followed by two spaces;
possible infraction at 117
checking cool-retro-term@1.0.0-1.e48719f [inputs-should-be-nati
checking cool-retro-term@1.0.0-1.e48719f [inputs-should-not-be-
gnu/packages/terminals.scm:490:14: cool-retro-term@1.0.0-1.e487
19f: synopsis should be less than 80 characters long
[0] marusich@garuda:~/guix
$
--8<---------------cut here---------------end--------------->8---
Think you could submit one more patch to tidy up those? Anyway, I can't
commit your patch (I don't have commit access), but somebody else
probably can.
Love this contribution, by the way. I'm sending an email from within
CRT right now...! :-)
--
Chris
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2017-04-23 23:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-23 11:55 [PATCH] gnu: Add cool-retro-term Petter
2017-04-23 19:18 ` Chris Marusich
2017-04-23 21:12 ` Petter
2017-04-23 23:31 ` Chris Marusich [this message]
2017-04-24 12:30 ` Petter
2017-04-26 3:36 ` Eric Bavier
2017-04-26 18:09 ` Petter
2017-04-28 1:47 ` Eric Bavier
2017-04-28 12:10 ` Petter
2017-04-30 20:59 ` Chris Marusich
2017-05-03 11:38 ` Petter
2017-05-02 13:51 ` Eric Bavier
2017-05-03 12:37 ` Petter
2017-05-05 3:03 ` Eric Bavier
2017-05-05 22:58 ` Petter
2017-05-08 9:39 ` Efraim Flashner
2017-04-30 20:47 ` Chris Marusich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vapuwvj0.fsf@gmail.com \
--to=cmmarusich@gmail.com \
--cc=guix-devel@gnu.org \
--cc=petter@mykolab.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).