From: Petter <petter@mykolab.ch>
To: Eric Bavier <ericbavier@centurylink.net>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add cool-retro-term.
Date: Sat, 6 May 2017 00:58:57 +0200 [thread overview]
Message-ID: <20170506005857.578fdfda@mykolab.ch> (raw)
In-Reply-To: <20170504220324.46b64183@centurylink.net>
[-- Attachment #1: Type: text/plain, Size: 2357 bytes --]
Hi Eric,
On Thu, 4 May 2017 22:03:24 -0500
Eric Bavier <ericbavier@centurylink.net> wrote:
> Hello Petter,
>
> Pushed as f9ff014bf623071b9343265e8a5aa994a10ec9d4 !
Cool! :)
> I ended up whitelisting a few more of the fonts, after verifying their
> licenses, and made some more specific notes on the license of each
> font.
Nice! I appreciate you taking care of this. My interest and knowledge of
licensing is pretty low, so I find this quite daunting at the moment. I'm sure
this will be easier for me when I gain more knowledge.
I see you updated both the snippet and the patch for the settings menu. Good!
Maybe we should start, or perhaps encourage the FSF, to maintain a list of Free
fonts. Guess this isn't the last time we need to determine a font's license.
Just a thought.
> I had to add $out/qml to the wrapper QML2_IMPORT_PATH in order for crt
> to start up. I figured that was alright, since that path was present
> in your initial patch.
Hm. Yeah, it certainly looks alright; in fact it looks "too alright". I don't
really understand now how this even can work for me without it. This is after
all where the qml for the embedded library is, which I assume is quite
important for the program :)
Aha! I had to investigate and now I get it. I've been using cool-retro-term
since the first time I was able to start it. At this point I built it with
(inputs qml). The wrapper at this point added only cool-retro-term/qml to
QML2_IMPORT_PATH (what you've added again). And QML2_IMPORT_PATH has been set
to this in my terminal environment ever since, and have further been included by
the wrapper script when I've run later builds:
export QML2_IMPORT_PATH=
"...988icm-qtquickcontrols-5.7.1/qml${QML2_IMPORT_PATH:+:}$QML2_IMPORT_PATH"
Now, when I went from full qml to qml components, I checked if this was still
required (wasn't thinking). It built and started fine without it so I removed
it.
Good thing you tried it!
> I added the patches to dist_patch_DATA in gnu/local.mk and listed them
> in the commit log too.
Thanks! I'm not familiar with gnu/local.mk. Looks like a build script.
I see you also changed (assoc-ref %build-inputs ..) to use "inputs". Noted!
> It even builds with "--rounds=2" :)
Yay! :)
> Thanks again,
> `~Eric
Thanks yourself! :)
Petter
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-05-05 22:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-23 11:55 [PATCH] gnu: Add cool-retro-term Petter
2017-04-23 19:18 ` Chris Marusich
2017-04-23 21:12 ` Petter
2017-04-23 23:31 ` Chris Marusich
2017-04-24 12:30 ` Petter
2017-04-26 3:36 ` Eric Bavier
2017-04-26 18:09 ` Petter
2017-04-28 1:47 ` Eric Bavier
2017-04-28 12:10 ` Petter
2017-04-30 20:59 ` Chris Marusich
2017-05-03 11:38 ` Petter
2017-05-02 13:51 ` Eric Bavier
2017-05-03 12:37 ` Petter
2017-05-05 3:03 ` Eric Bavier
2017-05-05 22:58 ` Petter [this message]
2017-05-08 9:39 ` Efraim Flashner
2017-04-30 20:47 ` Chris Marusich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170506005857.578fdfda@mykolab.ch \
--to=petter@mykolab.ch \
--cc=ericbavier@centurylink.net \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).