From: Petter <petter@mykolab.ch>
To: Chris Marusich <cmmarusich@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add cool-retro-term.
Date: Sun, 23 Apr 2017 23:12:07 +0200 [thread overview]
Message-ID: <20170423231207.4adb15e7@mykolab.ch> (raw)
In-Reply-To: <87inlvhr0y.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 6806 bytes --]
On Sun, 23 Apr 2017 12:18:05 -0700
Chris Marusich <cmmarusich@gmail.com> wrote:
> Petter <petter@mykolab.ch> writes:
>
> > Hi Guix,
> >
> > The past is finally here! Had a go at packaging a terminal emulator
> > which mimics old cathode displays :)
>
> Wow!! This is really fun. Thanks for packaging it!
:)
> > + (modify-phases %standard-phases
> > + (replace 'configure
> > + (lambda* (#:key outputs #:allow-other-keys)
> > + (let ((out (assoc-ref outputs "out")))
> > + (substitute*
> > '("qmltermwidget/qmltermwidget.pro")
> > + (("INSTALL_DIR =
> > \\$\\$\\[QT_INSTALL_QML\\]")
> > + (string-append "INSTALL_DIR = " out
> > "/qml")))
> > + (substitute* '("app/app.pro")
> > + (("target.path \\+= /usr")
> > + (string-append "target.path += " out))
> > + (("icon32.path = /usr/share")
> > + (string-append "icon32.path = " out))
> > + (("icon64.path = /usr/share")
> > + (string-append "icon64.path = " out))
> > + (("icon128.path = /usr/share")
> > + (string-append "icon128.path = " out))
> > + (("icon256.path = /usr/share")
> > + (string-append "icon256.path = " out)))
> > + (zero? (system* "qmake")))))
>
> Should these icons be put somewhere else, like in the $out/share path?
> If it works, it works, though. (info '(standards) Directory
> Variables'):
Indeed, I've fixed it.
> > + (synopsis "terminal emulator which mimics the look and feel of
> > the old +cathode tube screens")
> > + (description
> > + "Cool-retro-term is a terminal emulator which mimics the look
> > and feel of +the old cathode tube screens. It has been designed to
> > be eye-candy, +customizable, and reasonably lightweight.")
>
> Just minor feedback: Maybe use the phrases "CRT" and "cathode ray
> tube" to make this easier to discover?
>
Sure! Added your suggestions in the updated patch.
Thanks for the feedback!
Best,
Petter
From 453f6c6c2017c8598b29690b245f76d691d09870 Mon Sep 17 00:00:00 2001
From: Petter <petter@mykolab.ch>
Date: Sun, 23 Apr 2017 13:46:41 +0200
Subject: [PATCH] gnu: Add cool-retro-term.
* gnu/packages/terminals.scm (cool-retro-term): New variable.
---
gnu/packages/terminals.scm | 62
++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 62
insertions(+)
diff --git a/gnu/packages/terminals.scm b/gnu/packages/terminals.scm
index 979278a53..69ca46c98 100644
--- a/gnu/packages/terminals.scm
+++ b/gnu/packages/terminals.scm
@@ -7,6 +7,7 @@
;;; Copyright © 2016, 2017 José Miguel Sánchez García
<jmi2k@openmailbox.org> ;;; Copyright © 2017 Tobias Geerinckx-Rice
<me@tobias.gr> ;;; Copyright © 2017 Ricardo Wurmus <rekado@elephly.net>
+;;; Copyright © 2017 Petter <petter@mykolab.ch>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -49,6 +50,7 @@
#:use-module (gnu packages xdisorg)
#:use-module (gnu packages xml)
#:use-module (gnu packages docbook)
+ #:use-module (gnu packages qt)
#:use-module (srfi srfi-26))
(define-public tilda
@@ -433,3 +435,63 @@ its embedding program should provide it to draw on
its behalf. It avoids calling @code{malloc} during normal running
state, allowing it to be used in embedded kernel situations.")
(license license:expat)))
+
+(define-public cool-retro-term
+ (let ((commit "e48719fa44e5307df71dbd0fad234f8a6a53f863")
+ (revision "1"))
+ (package
+ (name "cool-retro-term")
+ (version (string-append "1.0.0-" revision "." (string-take commit
7)))
+ (source (origin
+ (method git-fetch)
+ (modules '((guix build utils)))
+ (file-name (string-append name "-" version "-checkout"))
+ (uri (git-reference
+ (url (string-append
"https://github.com/Swordfish90/" name))
+ (commit commit)
+ (recursive? #t)))
+ (sha256
+ (base32
"1sgqbirninkvgwchr35zgn5vzqvsmrf3cp7lqady1xgrawb8lsz3"))))
+ (build-system gnu-build-system)
+ (inputs
+ `(("qt" ,qt)))
+ (arguments
+ `(#:phases
+ (modify-phases %standard-phases
+ (replace 'configure
+ (lambda* (#:key outputs #:allow-other-keys)
+ (let ((out (assoc-ref outputs "out")))
+ (substitute* '("qmltermwidget/qmltermwidget.pro")
+ (("INSTALL_DIR = \\$\\$\\[QT_INSTALL_QML\\]")
+ (string-append "INSTALL_DIR = " out "/qml")))
+ (substitute* '("app/app.pro")
+ (("target.path \\+= /usr")
+ (string-append "target.path += " out))
+ (("icon32.path = /usr/share")
+ (string-append "icon32.path = " out "/share"))
+ (("icon64.path = /usr/share")
+ (string-append "icon64.path = " out "/share"))
+ (("icon128.path = /usr/share")
+ (string-append "icon128.path = " out
"/share"))
+ (("icon256.path = /usr/share")
+ (string-append "icon256.path = " out
"/share")))
+ (zero? (system* "qmake")))))
+ (add-before 'install 'fix-Makefiles
+ (lambda* (#:key outputs #:allow-other-keys)
+ (let ((out (assoc-ref outputs "out")))
+ (substitute* '("Makefile")
+ (("\\$\\(INSTALL_ROOT\\)/usr") out)))))
+ (add-after 'install 'wrap-executable
+ (lambda* (#:key outputs #:allow-other-keys)
+ (let* ((out (assoc-ref outputs "out")))
+ (wrap-program (string-append out
"/bin/cool-retro-term")
+ `("QML2_IMPORT_PATH" ":" prefix
+ (,(string-append out "/qml"))))))))))
+ (synopsis "Terminal emulator which mimics the look and feel of the
old +cathode ray tube screens")
+ (description
+ "Cool-retro-term (CRT) is a terminal emulator which mimics the
look and +feel of the old cathode ray tube (CRT) screens. It has been
designed to be +eye-candy, customizable, and reasonably lightweight.")
+ (home-page "https://github.com/Swordfish90/cool-retro-term")
+ (license (list license:gpl2 license:gpl3)))))
--
2.12.2
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-cool-retro-term.patch --]
[-- Type: text/x-patch, Size: 4494 bytes --]
From 453f6c6c2017c8598b29690b245f76d691d09870 Mon Sep 17 00:00:00 2001
From: Petter <petter@mykolab.ch>
Date: Sun, 23 Apr 2017 13:46:41 +0200
Subject: [PATCH] gnu: Add cool-retro-term.
* gnu/packages/terminals.scm (cool-retro-term): New variable.
---
gnu/packages/terminals.scm | 62 ++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 62 insertions(+)
diff --git a/gnu/packages/terminals.scm b/gnu/packages/terminals.scm
index 979278a53..69ca46c98 100644
--- a/gnu/packages/terminals.scm
+++ b/gnu/packages/terminals.scm
@@ -7,6 +7,7 @@
;;; Copyright © 2016, 2017 José Miguel Sánchez García <jmi2k@openmailbox.org>
;;; Copyright © 2017 Tobias Geerinckx-Rice <me@tobias.gr>
;;; Copyright © 2017 Ricardo Wurmus <rekado@elephly.net>
+;;; Copyright © 2017 Petter <petter@mykolab.ch>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -49,6 +50,7 @@
#:use-module (gnu packages xdisorg)
#:use-module (gnu packages xml)
#:use-module (gnu packages docbook)
+ #:use-module (gnu packages qt)
#:use-module (srfi srfi-26))
(define-public tilda
@@ -433,3 +435,63 @@ its embedding program should provide it to draw on its behalf. It avoids
calling @code{malloc} during normal running state, allowing it to be used in
embedded kernel situations.")
(license license:expat)))
+
+(define-public cool-retro-term
+ (let ((commit "e48719fa44e5307df71dbd0fad234f8a6a53f863")
+ (revision "1"))
+ (package
+ (name "cool-retro-term")
+ (version (string-append "1.0.0-" revision "." (string-take commit 7)))
+ (source (origin
+ (method git-fetch)
+ (modules '((guix build utils)))
+ (file-name (string-append name "-" version "-checkout"))
+ (uri (git-reference
+ (url (string-append "https://github.com/Swordfish90/" name))
+ (commit commit)
+ (recursive? #t)))
+ (sha256
+ (base32 "1sgqbirninkvgwchr35zgn5vzqvsmrf3cp7lqady1xgrawb8lsz3"))))
+ (build-system gnu-build-system)
+ (inputs
+ `(("qt" ,qt)))
+ (arguments
+ `(#:phases
+ (modify-phases %standard-phases
+ (replace 'configure
+ (lambda* (#:key outputs #:allow-other-keys)
+ (let ((out (assoc-ref outputs "out")))
+ (substitute* '("qmltermwidget/qmltermwidget.pro")
+ (("INSTALL_DIR = \\$\\$\\[QT_INSTALL_QML\\]")
+ (string-append "INSTALL_DIR = " out "/qml")))
+ (substitute* '("app/app.pro")
+ (("target.path \\+= /usr")
+ (string-append "target.path += " out))
+ (("icon32.path = /usr/share")
+ (string-append "icon32.path = " out "/share"))
+ (("icon64.path = /usr/share")
+ (string-append "icon64.path = " out "/share"))
+ (("icon128.path = /usr/share")
+ (string-append "icon128.path = " out "/share"))
+ (("icon256.path = /usr/share")
+ (string-append "icon256.path = " out "/share")))
+ (zero? (system* "qmake")))))
+ (add-before 'install 'fix-Makefiles
+ (lambda* (#:key outputs #:allow-other-keys)
+ (let ((out (assoc-ref outputs "out")))
+ (substitute* '("Makefile")
+ (("\\$\\(INSTALL_ROOT\\)/usr") out)))))
+ (add-after 'install 'wrap-executable
+ (lambda* (#:key outputs #:allow-other-keys)
+ (let* ((out (assoc-ref outputs "out")))
+ (wrap-program (string-append out "/bin/cool-retro-term")
+ `("QML2_IMPORT_PATH" ":" prefix
+ (,(string-append out "/qml"))))))))))
+ (synopsis "Terminal emulator which mimics the look and feel of the old
+cathode ray tube screens")
+ (description
+ "Cool-retro-term (CRT) is a terminal emulator which mimics the look and
+feel of the old cathode ray tube (CRT) screens. It has been designed to be
+eye-candy, customizable, and reasonably lightweight.")
+ (home-page "https://github.com/Swordfish90/cool-retro-term")
+ (license (list license:gpl2 license:gpl3)))))
--
2.12.2
next prev parent reply other threads:[~2017-04-23 21:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-23 11:55 [PATCH] gnu: Add cool-retro-term Petter
2017-04-23 19:18 ` Chris Marusich
2017-04-23 21:12 ` Petter [this message]
2017-04-23 23:31 ` Chris Marusich
2017-04-24 12:30 ` Petter
2017-04-26 3:36 ` Eric Bavier
2017-04-26 18:09 ` Petter
2017-04-28 1:47 ` Eric Bavier
2017-04-28 12:10 ` Petter
2017-04-30 20:59 ` Chris Marusich
2017-05-03 11:38 ` Petter
2017-05-02 13:51 ` Eric Bavier
2017-05-03 12:37 ` Petter
2017-05-05 3:03 ` Eric Bavier
2017-05-05 22:58 ` Petter
2017-05-08 9:39 ` Efraim Flashner
2017-04-30 20:47 ` Chris Marusich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170423231207.4adb15e7@mykolab.ch \
--to=petter@mykolab.ch \
--cc=cmmarusich@gmail.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).