Hello Petter,

Pushed as f9ff014bf623071b9343265e8a5aa994a10ec9d4 !

I ended up whitelisting a few more of the fonts, after verifying their
licenses, and made some more specific notes on the license of each
font.

I had to add $out/qml to the wrapper QML2_IMPORT_PATH in order for crt
to start up.  I figured that was alright, since that path was present
in your initial patch.

I added the patches to dist_patch_DATA in gnu/local.mk and listed them
in the commit log too.

It even builds with "--rounds=2" :)

Thanks again,
`~Eric

On Wed, 3 May 2017 14:37:53 +0200
Petter <petter@mykolab.ch> wrote:

> On Tue, 2 May 2017 08:51:06 -0500
> Eric Bavier <ericbavier@centurylink.net> wrote:
> 
> > Hi Petter,
> > 
> > Thanks again for your patience with this review.  
> 
> Hi Eric,
> 
> I'm in no rush :)
> 
> > "gpl2" in the license field should be "gpl2+" according to
> > qmltermwidget license headers.  Could you also include a comment noting
> > the component split?  Nothing fancy, just "for qmltermwidget" or so next
> > to gpl2+ and "for cool-retro-term" next to gpl3+.  
> 
> Done. I did it like this:
>       (license (list 
>                 license:gpl2+ ; qmltermwidget
>                 license:gpl3+ ; cool-retro-term
>                 ;; Fonts
>                 license:silofl1.1
>                 license:x11)))))
> 
> > > > > > and the fonts/1977-apple2, fonts/1977-commodore-pet, probably also
> > > > > > needs to be stripped as non-free; from 'FreeLicense.txt':
> > > > > > 
> > > > > >   "1. The User may not sell copies of the Software for a fee."
> > > > > > 
> > > > > > The fonts/1979-atari-400-800 font seems to be non-free license, which
> > > > > > is not mentioned in the 'ReadMe.rtf' but only on the WayBack Machine
> > > > > > at
> > > > > > https://web-beta.archive.org/web/20080907111008/http://www2.bitstream.net/~marksim/atarimac/fonts.html :
> > > > > > 
> > > > > >   "These fonts are freeware and may not be offered for sale seperately
> > > > > >   or as part of a collection."
> > > > > > 
> > > > > > The fonts/1982-commodore64 font is licensed under non-free terms; see
> > > > > > fonts/1982-commodore64/license.txt
> > > > > > 
> > > > > > The only mention of a license for fonts/1985-ibm-pc-vga is at
> > > > > > http://www.dafont.com/font-comment.php?file=perfect_dos_vga_437 where
> > > > > > the author says "The license is this: this font is free to use in
> > > > > > whatever you want.", but that probably "doesn't count".
> > > > > > 
> > > > > > I could not find license info for a few of the other fonts.
> > > > > > 
> > > > > > OTOH I recall a discussion on IRC recently about fonts embedded in
> > > > > > packages being treated as non-functional data, and thus OK from a FSDG
> > > > > > perspective.  But I would want verification on that.          
> > > > > 
> > > > > Let's see if someone can shine some light on this.
> > > > >         
> > > > 
> > > > Leo pointed me at https://bugs.gnu.org/26588 which references
> > > > https://www.gnu.org/distros/free-system-distribution-guidelines.html#non-functional-data .
> > > > I think many of these fonts would need to be stripped out or
> > > > substituted because their license prohibits commercial/non-commercial
> > > > redistribution.      
> > > 
> > > Recipe is now removing the following from disk and GUI:
> > >                                   '("1977-apple2"
> > >                                     "1977-commodore-pet"
> > >                                     "1979-atari-400-800"
> > >                                     "1982-commodore64"
> > >                                     "1985-ibm-pc-vga")    
> > 
> > The code you've added to delete these fonts and adjust the source
> > accordingly would be better in an origin 'snippet' so that `guix build
> > -S cool-retro-term` does not include the fonts.  
> 
> Done.
> 
> > > 
> > > Should more be removed?    
> > 
> > modern-monaco.  It's a font from Apple which is specifically *not*
> > freely distributable, but the ttf file is still floating around the
> > internet, giving many projects the impression that it is.
> >   
> > > 
> > > What do we do about the fonts without licensing info?    
> > 
> > I agree with Chris that we need to remove them.  
> 
> Right, I've made the mental switch now to whitelist rather than blacklist.
> The ones that are included now are modern-hermit, modern-pro-font-win-tweaked
> and modern-proggy-tiny. The rest are out until proven Free.
> 
> Let me know if there are other fonts /we can include/ ;)
> 
> 
> Also added a `crt` as a symlink to cool-retro-term.
> 
> 
> Thanks Eric and Chris for being so thorough and helpful! Let me know if there
> are more issues.