From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: Lars Ingebrigtsen <larsi@gnus.org>,
andrewjmoreton@gmail.com, Eli Zaretskii <eliz@gnu.org>,
emacs-devel@gnu.org
Subject: Re: encode-time vs decode-time
Date: Mon, 19 Aug 2019 17:12:00 -0400 [thread overview]
Message-ID: <jwv4l2czx0y.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <88b57699-fbdb-bd43-6627-f7491b834955@cs.ucla.edu> (Paul Eggert's message of "Sat, 17 Aug 2019 15:53:13 -0700")
>> So maybe we should stop documenting "decoded time" objects as being of
>> the form (SEC MINUTE HOUR DAY MONTH YEAR DOW DST UTCOFF SUBSEC), but
>> instead say that it's a `decoded-time` object on which you can use
>> the `decoded-time-*` accessors (and provide a corresponding pcase pattern
>> to replace the `(,sec ,minute ...) one).
>
> That sounds like a reasonable way to move forward.
>
> I'm not a pcase expert. How would one go about doing the pcase stuff? That
> is, how does one provide a pattern so that code like (pcase time
> ((decoded-time :year y :month m) (some-expr-involving y & m))) can extract
> the year and month components Y and M from the broken-down time TIME that
> was created via (make-decoded-time :year y :month m)? Is there an example of
> doing this sort of thing somewhere?
With the cl-defstruct we use for decoded-time, we can already do:
(pcase-let (((cl-struct decoded-time (second s) (minute m) hour day) time))
...)
so we could define
(pcase-defmacro decoded-time (&rest fields)
`(cl-struct decoded-time ,@fields))
OTOH it doesn't work in plain `pcase` currently because of a bug in the
`cl-struct` pcase pattern (it expands to code which does (cl-typep XX
'decoded-time) but the way `decoded-time` is defined makes it unusable
with `cl-typep`).
Stefan
next prev parent reply other threads:[~2019-08-19 21:12 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 9:48 Support for sub-second time in decoded time Lars Ingebrigtsen
2019-07-29 14:03 ` Stefan Monnier
2019-07-29 14:12 ` Lars Ingebrigtsen
2019-07-29 14:43 ` Stefan Monnier
2019-07-29 15:00 ` Lars Ingebrigtsen
2019-07-29 17:50 ` Stefan Monnier
2019-07-30 11:33 ` Lars Ingebrigtsen
2019-07-29 16:08 ` encode-time vs decode-time Stefan Monnier
2019-07-30 10:32 ` Lars Ingebrigtsen
2019-07-30 11:34 ` Andy Moreton
2019-07-30 11:37 ` Lars Ingebrigtsen
2019-07-30 17:54 ` Paul Eggert
2019-07-30 22:50 ` Paul Eggert
2019-07-31 19:03 ` Lars Ingebrigtsen
2019-07-31 19:31 ` Stefan Monnier
2019-08-06 1:48 ` Paul Eggert
2019-08-06 14:21 ` Eli Zaretskii
2019-08-06 15:59 ` Paul Eggert
2019-08-06 18:23 ` Eli Zaretskii
2019-08-07 1:02 ` Paul Eggert
2019-08-07 2:41 ` Stefan Monnier
2019-08-07 14:47 ` Eli Zaretskii
2019-08-11 23:39 ` Lars Ingebrigtsen
2019-08-17 6:47 ` Paul Eggert
2019-08-07 11:33 ` Lars Ingebrigtsen
2019-08-17 7:54 ` Paul Eggert
2019-08-17 8:16 ` Eli Zaretskii
2019-08-17 9:33 ` Paul Eggert
2019-08-17 20:46 ` Lars Ingebrigtsen
2019-08-17 20:56 ` Paul Eggert
2019-08-17 21:42 ` Stefan Monnier
2019-08-17 22:53 ` Paul Eggert
2019-08-19 21:12 ` Stefan Monnier [this message]
2019-08-21 10:55 ` Adam Porter
2019-08-21 20:20 ` Paul Eggert
2019-08-26 10:59 ` Adam Porter
2019-08-26 21:35 ` Paul Eggert
2019-08-07 14:44 ` Eli Zaretskii
2019-08-07 11:41 ` Lars Ingebrigtsen
2019-08-17 9:25 ` Paul Eggert
2019-08-17 20:51 ` Lars Ingebrigtsen
2019-07-29 14:23 ` Support for sub-second time in decoded time Eli Zaretskii
2019-07-29 14:59 ` Lars Ingebrigtsen
2019-07-29 16:46 ` Paul Eggert
2019-07-30 11:43 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv4l2czx0y.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=andrewjmoreton@gmail.com \
--cc=eggert@cs.ucla.edu \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).