From: Lars Ingebrigtsen <larsi@gnus.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: Andy Moreton <andrewjmoreton@gmail.com>, emacs-devel@gnu.org
Subject: Re: encode-time vs decode-time
Date: Wed, 07 Aug 2019 13:41:49 +0200 [thread overview]
Message-ID: <87o9119p8i.fsf@mouse.gnus.org> (raw)
In-Reply-To: <cf47bf4b-31cf-69f3-0e65-38f1b0ee168a@cs.ucla.edu> (Paul Eggert's message of "Mon, 5 Aug 2019 18:48:21 -0700")
Paul Eggert <eggert@cs.ucla.edu> writes:
> OK, after some cogitation I installed something along those lines into
> master. I called the new function 'time-convert' by analogy with the
> existing functions time-add etc. So now, as you suggested, encode-time
> has reverted to its old role of converting from decoded timestamps to
> Lisp timestamps and its API is now simpler.
Great! Thanks for doing this and adding the sub-second time to the
decoded time structure -- I'll be implementing the remaining bits of the
ISO 8601 standard in `iso8601-parse' (the ones that deal with fractional
seconds) so that we'll have a completely compliant parser.
> I didn't follow Stefan's suggestion of adding another function that
> acts like current-time except it returns the (TICKS . HZ) format,
> because current-time is already planned do exactly that after the next
> release (when we will default CURRENT_TIME_LIST to false) and it'll be
> simpler if we have one function rather than two that do the same
> thing.
However, I think this sounds overly ambitious. I think it's likely that
there's tons of out-of-tree code that assumes that `current-time' always
returns a list of time values, because it's been that way since
basically forever. It's been extended, but the first two elements have
always been a representation of seconds.
This is why I thought it would be good to introduce a new function, say
`get-current-time', that could have our new signature. We'd then
deprecate `current-time' (but probably never actually remove it since
there's so much code out there in the wild that uses it) and rewrite all
calls in-tree to use this new function.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2019-08-07 11:41 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 9:48 Support for sub-second time in decoded time Lars Ingebrigtsen
2019-07-29 14:03 ` Stefan Monnier
2019-07-29 14:12 ` Lars Ingebrigtsen
2019-07-29 14:43 ` Stefan Monnier
2019-07-29 15:00 ` Lars Ingebrigtsen
2019-07-29 17:50 ` Stefan Monnier
2019-07-30 11:33 ` Lars Ingebrigtsen
2019-07-29 16:08 ` encode-time vs decode-time Stefan Monnier
2019-07-30 10:32 ` Lars Ingebrigtsen
2019-07-30 11:34 ` Andy Moreton
2019-07-30 11:37 ` Lars Ingebrigtsen
2019-07-30 17:54 ` Paul Eggert
2019-07-30 22:50 ` Paul Eggert
2019-07-31 19:03 ` Lars Ingebrigtsen
2019-07-31 19:31 ` Stefan Monnier
2019-08-06 1:48 ` Paul Eggert
2019-08-06 14:21 ` Eli Zaretskii
2019-08-06 15:59 ` Paul Eggert
2019-08-06 18:23 ` Eli Zaretskii
2019-08-07 1:02 ` Paul Eggert
2019-08-07 2:41 ` Stefan Monnier
2019-08-07 14:47 ` Eli Zaretskii
2019-08-11 23:39 ` Lars Ingebrigtsen
2019-08-17 6:47 ` Paul Eggert
2019-08-07 11:33 ` Lars Ingebrigtsen
2019-08-17 7:54 ` Paul Eggert
2019-08-17 8:16 ` Eli Zaretskii
2019-08-17 9:33 ` Paul Eggert
2019-08-17 20:46 ` Lars Ingebrigtsen
2019-08-17 20:56 ` Paul Eggert
2019-08-17 21:42 ` Stefan Monnier
2019-08-17 22:53 ` Paul Eggert
2019-08-19 21:12 ` Stefan Monnier
2019-08-21 10:55 ` Adam Porter
2019-08-21 20:20 ` Paul Eggert
2019-08-26 10:59 ` Adam Porter
2019-08-26 21:35 ` Paul Eggert
2019-08-07 14:44 ` Eli Zaretskii
2019-08-07 11:41 ` Lars Ingebrigtsen [this message]
2019-08-17 9:25 ` Paul Eggert
2019-08-17 20:51 ` Lars Ingebrigtsen
2019-07-29 14:23 ` Support for sub-second time in decoded time Eli Zaretskii
2019-07-29 14:59 ` Lars Ingebrigtsen
2019-07-29 16:46 ` Paul Eggert
2019-07-30 11:43 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9119p8i.fsf@mouse.gnus.org \
--to=larsi@gnus.org \
--cc=andrewjmoreton@gmail.com \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).