* Re: master 788a658: Do not save empty passwords in auth-source-search [not found] ` <20210919175913.5E6D820ABE@vcs0.savannah.gnu.org> @ 2021-09-20 5:04 ` Lars Ingebrigtsen 2021-09-20 8:18 ` Michael Albinus 0 siblings, 1 reply; 6+ messages in thread From: Lars Ingebrigtsen @ 2021-09-20 5:04 UTC (permalink / raw) To: emacs-devel; +Cc: Michael Albinus Michael.Albinus@gmx.de (Michael Albinus) writes: > branch: master > commit 788a65862ed9b9bc0437a016cae7e3ba1282a1a7 > Author: Michael Albinus <michael.albinus@gmx.de> > Commit: Michael Albinus <michael.albinus@gmx.de> > > Do not save empty passwords in auth-source-search This apparently leads to: Test auth-source-test-netrc-create-secret condition: (ert-test-failed ((should (string-equal (plist-get auth-info :user) (user-login-name))) :form (string-equal nil "larsi") :value nil)) FAILED 18/23 auth-source-test-netrc-create-secret (0.009026 sec) passed 19/23 auth-source-test-netrc-parse-entry (0.000077 sec) passed 20/23 auth-source-test-netrc-parse-one (0.000046 sec) passed 21/23 auth-source-test-remembrances-of-things-past (0.000052 sec) passed 22/23 auth-source-test-searches (0.001280 sec) Saved new authentication information to session passed 23/23 auth-source-test-secrets-create-secret (0.055276 sec) Ran 23 tests, 22 results as expected, 1 unexpected (2021-09-20 07:02:39+0200, 0.211667 sec) 1 unexpected results: FAILED auth-source-test-netrc-create-secret (But I haven't verified that it's this commit that's the cause.) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: master 788a658: Do not save empty passwords in auth-source-search 2021-09-20 5:04 ` master 788a658: Do not save empty passwords in auth-source-search Lars Ingebrigtsen @ 2021-09-20 8:18 ` Michael Albinus 2021-09-20 13:12 ` Michael Albinus 0 siblings, 1 reply; 6+ messages in thread From: Michael Albinus @ 2021-09-20 8:18 UTC (permalink / raw) To: Lars Ingebrigtsen; +Cc: emacs-devel Lars Ingebrigtsen <larsi@gnus.org> writes: Hi Lars, >> branch: master >> commit 788a65862ed9b9bc0437a016cae7e3ba1282a1a7 >> Author: Michael Albinus <michael.albinus@gmx.de> >> Commit: Michael Albinus <michael.albinus@gmx.de> >> >> Do not save empty passwords in auth-source-search > > This apparently leads to: > > Test auth-source-test-netrc-create-secret condition: > (ert-test-failed > ((should > (string-equal > (plist-get auth-info :user) > (user-login-name))) > :form > (string-equal nil "larsi") > :value nil)) > FAILED 18/23 auth-source-test-netrc-create-secret (0.009026 sec) > passed 19/23 auth-source-test-netrc-parse-entry (0.000077 sec) > passed 20/23 auth-source-test-netrc-parse-one (0.000046 sec) > passed 21/23 auth-source-test-remembrances-of-things-past (0.000052 sec) > passed 22/23 auth-source-test-searches (0.001280 sec) > Saved new authentication information to session > passed 23/23 auth-source-test-secrets-create-secret (0.055276 sec) > > Ran 23 tests, 22 results as expected, 1 unexpected (2021-09-20 07:02:39+0200, 0.211667 sec) > > 1 unexpected results: > FAILED auth-source-test-netrc-create-secret > > (But I haven't verified that it's this commit that's the cause.) Likely yes, because that commit has added the test. Strange, as you would expect this runs for me w/o problems. Hmm, there is a wrong skip-unless, which prevents it to run on emba. I'll fix this, in order to see whether it runs there, as first analysis step. Best regards, Michael. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: master 788a658: Do not save empty passwords in auth-source-search 2021-09-20 8:18 ` Michael Albinus @ 2021-09-20 13:12 ` Michael Albinus 2021-09-21 3:29 ` Lars Ingebrigtsen 0 siblings, 1 reply; 6+ messages in thread From: Michael Albinus @ 2021-09-20 13:12 UTC (permalink / raw) To: Lars Ingebrigtsen; +Cc: emacs-devel Michael Albinus <michael.albinus@gmx.de> writes: Hi Lars, >> Test auth-source-test-netrc-create-secret condition: >> (ert-test-failed >> ((should >> (string-equal >> (plist-get auth-info :user) >> (user-login-name))) >> :form >> (string-equal nil "larsi") >> :value nil)) >> FAILED 18/23 auth-source-test-netrc-create-secret (0.009026 sec) >> >> (But I haven't verified that it's this commit that's the cause.) > > Likely yes, because that commit has added the test. > > Strange, as you would expect this runs for me w/o problems. Hmm, there is > a wrong skip-unless, which prevents it to run on emba. I'll fix this, in > order to see whether it runs there, as first analysis step. On emba and hydra, the test has passed as well. So there's a difference in your local environment? Do you have changes in auth-source.el, which are not pushed to the master branch? Best regards, Michael. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: master 788a658: Do not save empty passwords in auth-source-search 2021-09-20 13:12 ` Michael Albinus @ 2021-09-21 3:29 ` Lars Ingebrigtsen 2021-09-21 3:41 ` Lars Ingebrigtsen 0 siblings, 1 reply; 6+ messages in thread From: Lars Ingebrigtsen @ 2021-09-21 3:29 UTC (permalink / raw) To: Michael Albinus; +Cc: emacs-devel Michael Albinus <michael.albinus@gmx.de> writes: > On emba and hydra, the test has passed as well. So there's a difference > in your local environment? Do you have changes in auth-source.el, which > are not pushed to the master branch? The test lacked a :type 'netrc, so it ended up searching my Gnome secrets or something. I've now added the :type. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: master 788a658: Do not save empty passwords in auth-source-search 2021-09-21 3:29 ` Lars Ingebrigtsen @ 2021-09-21 3:41 ` Lars Ingebrigtsen 2021-09-21 4:00 ` Lars Ingebrigtsen 0 siblings, 1 reply; 6+ messages in thread From: Lars Ingebrigtsen @ 2021-09-21 3:41 UTC (permalink / raw) To: Michael Albinus; +Cc: emacs-devel Lars Ingebrigtsen <larsi@gnus.org> writes: > The test lacked a :type 'netrc, so it ended up searching my Gnome > secrets or something. I've now added the :type. Er, no, that's not it. The test only fails in about half the test runs, so I'm not sure what's going on. Still debugging. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: master 788a658: Do not save empty passwords in auth-source-search 2021-09-21 3:41 ` Lars Ingebrigtsen @ 2021-09-21 4:00 ` Lars Ingebrigtsen 0 siblings, 0 replies; 6+ messages in thread From: Lars Ingebrigtsen @ 2021-09-21 4:00 UTC (permalink / raw) To: Michael Albinus; +Cc: emacs-devel Lars Ingebrigtsen <larsi@gnus.org> writes: > Er, no, that's not it. The test only fails in about half the test runs, > so I'm not sure what's going on. Still debugging. More levels of caching getting in the way, but it's puzzling that it doesn't fail either 100% of the time or not... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-09-21 4:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20210919175911.21298.44611@vcs0.savannah.gnu.org>
[not found] ` <20210919175913.5E6D820ABE@vcs0.savannah.gnu.org>
2021-09-20 5:04 ` master 788a658: Do not save empty passwords in auth-source-search Lars Ingebrigtsen
2021-09-20 8:18 ` Michael Albinus
2021-09-20 13:12 ` Michael Albinus
2021-09-21 3:29 ` Lars Ingebrigtsen
2021-09-21 3:41 ` Lars Ingebrigtsen
2021-09-21 4:00 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).