From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: master 788a658: Do not save empty passwords in auth-source-search Date: Mon, 20 Sep 2021 15:12:03 +0200 Message-ID: <874kafe6ho.fsf@gmx.de> References: <20210919175911.21298.44611@vcs0.savannah.gnu.org> <20210919175913.5E6D820ABE@vcs0.savannah.gnu.org> <87o88nn8h0.fsf@gnus.org> <87lf3rek2q.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3649"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Sep 20 15:13:35 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mSJ70-0000nh-JV for ged-emacs-devel@m.gmane-mx.org; Mon, 20 Sep 2021 15:13:34 +0200 Original-Received: from localhost ([::1]:57786 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mSJ6z-0000RW-Jv for ged-emacs-devel@m.gmane-mx.org; Mon, 20 Sep 2021 09:13:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48696) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSJ5e-0007bj-BV for emacs-devel@gnu.org; Mon, 20 Sep 2021 09:12:11 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:48501) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSJ5a-00059O-IP for emacs-devel@gnu.org; Mon, 20 Sep 2021 09:12:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1632143524; bh=A4RACcLntNvJLcHHr0ns/QvWUa14YHICvbEPeqNyHIQ=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=iRe2NMrtswSJ4lKQSO/T2dLqN6iJzvdlVEP4ROWNndntMSH3kiVsaEC0M3/XXUHHj 9Y318cDP9XXVkJvicr4nrmL2IJTQ8OM457p94LzRS5KspT+TxWRJ66wgCo+Ktumv8h Fin02uXTo4HdwT62PmFNEnY6g3Yq2GTNLS/gRE3E= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([212.91.238.85]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MA7GM-1mZU5O0m5q-00Bf7n; Mon, 20 Sep 2021 15:12:04 +0200 In-Reply-To: <87lf3rek2q.fsf@gmx.de> (Michael Albinus's message of "Mon, 20 Sep 2021 10:18:37 +0200") X-Provags-ID: V03:K1:2LNFSVgeJqAhZbfO4puJWFeph/hfuEQc+e8p2V7P7jfFq2Vb60J UFzzD87i4XLJ6c9A943jUr832rKqoeWUqecmefodJnantTiIEA1de5yfphh5v9FWkzEmGHj MY/xopde4RDwb8HQpq2HqXoExFqTK856OfrlEhA8+W8qczkrp//rNNgjt97m1rivgpMq73l Je9MOiPuoV+VLKcfGkexA== X-UI-Out-Filterresults: notjunk:1;V03:K0:gy9DfKN859A=:XVxTs7XmqQIqJsEml6ETuw UkBhNdIUEF4VfuXiD2StYSgq0qafaNn1XyMJje4NDteOyAzIT1MPmm1QUxPS1GExWYscJ0nAV NhpUj2t5DKkjY59bcdsUVrQHQw2AJOhCneDi0FDCPHirNzQoFlLbZ9XnqYRxcttOsVATI4vjV JWy8ScYixAQXHkDZHyS4bA3SEB86iwfjd5MqqWgq+W+DOoMemNwmSFt5USJkZb8h8AqsGmbdj TEd4FOTHmcb00IKRac3LgvWfeYEGNAeHWzBaN9F+zgnhUGElKQbeNttj+j2uYwtSDv2zGnTRz oEDIUjik5BLhZMUD76JHpTuoc5xlujad9iHHQHZTcjEQ58iP4l68khHv1gaz/g8YpWwY+OCTM UQNZEk5/rX3g2ESa9sbzbn8uQstnzeI02ZUu1Ur5i6SKXJ7TW3F37MjR/XHsN394YsC4rwhuN VYTIYAKbevlvpOp1cM35vDEk6tOb1ttuZZNDGiAz3iHoRuUO/lUSR+SwdvTR9hqi3Jo1NlJrO V7lnjLkM/L0IDRIccDU8EJ6Gh/pbdD+6zbqXNzz0LrR+CT05+446GETGVib+JDdGDlliYPR8l r4wQ20H5t15AydaCVhhfueGxrwjN/Tl0ATbnWPD587v74DjjsFAmmWyywf6XUgbz1o3bTd5r/ mly9t/cbHo3c3AtAFLLoqqqb94dGjNVTzlnxDP4MBwfaGYotj+QPgwI6W63YRe0W9ywnPJ2Rk bwa/RNn+Gc3S+6+US2tVeoMlVNQsC19mJ7M6mCekNNCDaWDIEOm3zuhgmCfjB1/aChFruauP Received-SPF: pass client-ip=212.227.17.21; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:275128 Archived-At: Michael Albinus writes: Hi Lars, >> Test auth-source-test-netrc-create-secret condition: >> (ert-test-failed >> ((should >> (string-equal >> (plist-get auth-info :user) >> (user-login-name))) >> :form >> (string-equal nil "larsi") >> :value nil)) >> FAILED 18/23 auth-source-test-netrc-create-secret (0.009026 sec) >> >> (But I haven't verified that it's this commit that's the cause.) > > Likely yes, because that commit has added the test. > > Strange, as you would expect this runs for me w/o problems. Hmm, there is > a wrong skip-unless, which prevents it to run on emba. I'll fix this, in > order to see whether it runs there, as first analysis step. On emba and hydra, the test has passed as well. So there's a difference in your local environment? Do you have changes in auth-source.el, which are not pushed to the master branch? Best regards, Michael.