From: Michael Albinus <michael.albinus@gmx.de>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: emacs-devel@gnu.org
Subject: Re: master 788a658: Do not save empty passwords in auth-source-search
Date: Mon, 20 Sep 2021 15:12:03 +0200 [thread overview]
Message-ID: <874kafe6ho.fsf@gmx.de> (raw)
In-Reply-To: <87lf3rek2q.fsf@gmx.de> (Michael Albinus's message of "Mon, 20 Sep 2021 10:18:37 +0200")
Michael Albinus <michael.albinus@gmx.de> writes:
Hi Lars,
>> Test auth-source-test-netrc-create-secret condition:
>> (ert-test-failed
>> ((should
>> (string-equal
>> (plist-get auth-info :user)
>> (user-login-name)))
>> :form
>> (string-equal nil "larsi")
>> :value nil))
>> FAILED 18/23 auth-source-test-netrc-create-secret (0.009026 sec)
>>
>> (But I haven't verified that it's this commit that's the cause.)
>
> Likely yes, because that commit has added the test.
>
> Strange, as you would expect this runs for me w/o problems. Hmm, there is
> a wrong skip-unless, which prevents it to run on emba. I'll fix this, in
> order to see whether it runs there, as first analysis step.
On emba and hydra, the test has passed as well. So there's a difference
in your local environment? Do you have changes in auth-source.el, which
are not pushed to the master branch?
Best regards, Michael.
next prev parent reply other threads:[~2021-09-20 13:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210919175911.21298.44611@vcs0.savannah.gnu.org>
[not found] ` <20210919175913.5E6D820ABE@vcs0.savannah.gnu.org>
2021-09-20 5:04 ` master 788a658: Do not save empty passwords in auth-source-search Lars Ingebrigtsen
2021-09-20 8:18 ` Michael Albinus
2021-09-20 13:12 ` Michael Albinus [this message]
2021-09-21 3:29 ` Lars Ingebrigtsen
2021-09-21 3:41 ` Lars Ingebrigtsen
2021-09-21 4:00 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874kafe6ho.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).