From: Michael Albinus <michael.albinus@gmx.de>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: emacs-devel@gnu.org
Subject: Re: master 788a658: Do not save empty passwords in auth-source-search
Date: Mon, 20 Sep 2021 10:18:37 +0200 [thread overview]
Message-ID: <87lf3rek2q.fsf@gmx.de> (raw)
In-Reply-To: <87o88nn8h0.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 20 Sep 2021 07:04:27 +0200")
Lars Ingebrigtsen <larsi@gnus.org> writes:
Hi Lars,
>> branch: master
>> commit 788a65862ed9b9bc0437a016cae7e3ba1282a1a7
>> Author: Michael Albinus <michael.albinus@gmx.de>
>> Commit: Michael Albinus <michael.albinus@gmx.de>
>>
>> Do not save empty passwords in auth-source-search
>
> This apparently leads to:
>
> Test auth-source-test-netrc-create-secret condition:
> (ert-test-failed
> ((should
> (string-equal
> (plist-get auth-info :user)
> (user-login-name)))
> :form
> (string-equal nil "larsi")
> :value nil))
> FAILED 18/23 auth-source-test-netrc-create-secret (0.009026 sec)
> passed 19/23 auth-source-test-netrc-parse-entry (0.000077 sec)
> passed 20/23 auth-source-test-netrc-parse-one (0.000046 sec)
> passed 21/23 auth-source-test-remembrances-of-things-past (0.000052 sec)
> passed 22/23 auth-source-test-searches (0.001280 sec)
> Saved new authentication information to session
> passed 23/23 auth-source-test-secrets-create-secret (0.055276 sec)
>
> Ran 23 tests, 22 results as expected, 1 unexpected (2021-09-20 07:02:39+0200, 0.211667 sec)
>
> 1 unexpected results:
> FAILED auth-source-test-netrc-create-secret
>
> (But I haven't verified that it's this commit that's the cause.)
Likely yes, because that commit has added the test.
Strange, as you would expect this runs for me w/o problems. Hmm, there is
a wrong skip-unless, which prevents it to run on emba. I'll fix this, in
order to see whether it runs there, as first analysis step.
Best regards, Michael.
next prev parent reply other threads:[~2021-09-20 8:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210919175911.21298.44611@vcs0.savannah.gnu.org>
[not found] ` <20210919175913.5E6D820ABE@vcs0.savannah.gnu.org>
2021-09-20 5:04 ` master 788a658: Do not save empty passwords in auth-source-search Lars Ingebrigtsen
2021-09-20 8:18 ` Michael Albinus [this message]
2021-09-20 13:12 ` Michael Albinus
2021-09-21 3:29 ` Lars Ingebrigtsen
2021-09-21 3:41 ` Lars Ingebrigtsen
2021-09-21 4:00 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lf3rek2q.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).