From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: master 788a658: Do not save empty passwords in auth-source-search Date: Mon, 20 Sep 2021 10:18:37 +0200 Message-ID: <87lf3rek2q.fsf@gmx.de> References: <20210919175911.21298.44611@vcs0.savannah.gnu.org> <20210919175913.5E6D820ABE@vcs0.savannah.gnu.org> <87o88nn8h0.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30262"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Sep 20 10:23:07 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mSEZt-0007aE-KJ for ged-emacs-devel@m.gmane-mx.org; Mon, 20 Sep 2021 10:23:05 +0200 Original-Received: from localhost ([::1]:48046 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mSEZs-0002eb-EO for ged-emacs-devel@m.gmane-mx.org; Mon, 20 Sep 2021 04:23:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50628) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSEVh-00047Z-4R for emacs-devel@gnu.org; Mon, 20 Sep 2021 04:18:46 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:37493) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSEVe-0002bl-VK for emacs-devel@gnu.org; Mon, 20 Sep 2021 04:18:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1632125918; bh=UQgxFqC29ecGObyvT7VeUwT9D3M+C1h3k9SsFiTkem4=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=QobBFot8ad+Bq/6E0XVT59pk4FKyW//HoUJZNKf5LNv2Ez9GqZVECMPjJ8Zxo3jRN sdaa8YbZlc9gZAkOJlZ7j871hlOSVawVZMOvBStk2GScwY3PhcSnnHGocYHwVouCr5 96MAQ1vdL7IrfKu/GBgzFZJj8cQomhu9t8Duk23s= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([212.91.238.85]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MvsEx-1mlpG51Rcl-00suse; Mon, 20 Sep 2021 10:18:38 +0200 In-Reply-To: <87o88nn8h0.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 20 Sep 2021 07:04:27 +0200") X-Provags-ID: V03:K1:2+fGMFn1NOBYXkgbDr1Q2AwxzMG+to0hnBtiD4cV7RDBvVNKjRS fHqMazrDy8qb4lHXzcmaQVmNi29Nrxtmnqo6wuAtLEOUPxvN2LX3HWhp6GGRf4B+p/tY7aJ KqzdU2jsigQ1528sJYlF8n/Gca0NgEIgD3XtsIdT6zDi58cVH22XLFw6ZpHGhCcAN3lsKwr oKoRXEbavDNZWjOgCxhqg== X-UI-Out-Filterresults: notjunk:1;V03:K0:j5DgarlysnQ=:VRK9ER5YR61BJaUASgCB1I 4GM5l3S0bVyw8HSahBmL8lkmVCuSDeuDud2xa4vbUXvQqvg3kVzt8U7kKH2h2vvNojE90RhiV /fmgFaTPrwPZg1zn+OgCfn3ODyc+KJ7xHEmrcgoIlm69DsZ62+/bY4lumcyRC4RXIhju+FB04 s96g192AEdL1pyWY/oPJBMyiHy4IgT4dAl9uftHxpehnV2x1/zWHTp3Yat8gewuao4M5OXNMq opwNq97pVsZGOoXZ/psKgtqQxITkszQXeNZZpZFSJOXTI0V0yoff1cdmWn3TmqQPdwv0sPx6P E6Sq91KRDpQZyiYSv0qJ3h3LkxgPmOhE52Lz7uVh4EQj/5rgfsbzg8LvcGzDkilni+sLn2/hV yWp7dgCdYSH/JKjTAMXoqNeoT8Y3L/y+aq+pi6sQ+Vh7ZmUJhhXG4gMEO9zuME3KAAQiG7FsV fQAYLVRIX4lohXcpIvJOv5QaC3CJm09nmgg3RqdJMGlns/e+uFpxzdl/Q8oOMNnjhXHiTv2l2 G5+D2R+PhqlpoKTJCZpJqOkDOVEUD3kBRVz4Bi5DdH4kFE27UEUnZMhoMXle7IuRq/8RcorQH KDSNAvaETKZcY7G3Mlj+/uSJnHOworN7b+27h9eMalNwlhk+WhzRisbMy70jv1S2LAFMXLU74 tr7c3Ht9/OssK0/GhdXRJFmLvJZGSuw2/r1atoJP0qHhZpsO8n/fcBTR9yh+e4JKx4Zy5Er/n 0Y1LGZoN6ElNSGIcC3lmGXTTfFYdSfpxSsY/ktV9VEnU5SnjnOJZoK6hMybdMrx22H794dnM Received-SPF: pass client-ip=212.227.17.21; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:275114 Archived-At: Lars Ingebrigtsen writes: Hi Lars, >> branch: master >> commit 788a65862ed9b9bc0437a016cae7e3ba1282a1a7 >> Author: Michael Albinus >> Commit: Michael Albinus >> >> Do not save empty passwords in auth-source-search > > This apparently leads to: > > Test auth-source-test-netrc-create-secret condition: > (ert-test-failed > ((should > (string-equal > (plist-get auth-info :user) > (user-login-name))) > :form > (string-equal nil "larsi") > :value nil)) > FAILED 18/23 auth-source-test-netrc-create-secret (0.009026 sec) > passed 19/23 auth-source-test-netrc-parse-entry (0.000077 sec) > passed 20/23 auth-source-test-netrc-parse-one (0.000046 sec) > passed 21/23 auth-source-test-remembrances-of-things-past (0.000052 sec) > passed 22/23 auth-source-test-searches (0.001280 sec) > Saved new authentication information to session > passed 23/23 auth-source-test-secrets-create-secret (0.055276 sec) > > Ran 23 tests, 22 results as expected, 1 unexpected (2021-09-20 07:02:39+0200, 0.211667 sec) > > 1 unexpected results: > FAILED auth-source-test-netrc-create-secret > > (But I haven't verified that it's this commit that's the cause.) Likely yes, because that commit has added the test. Strange, as you would expect this runs for me w/o problems. Hmm, there is a wrong skip-unless, which prevents it to run on emba. I'll fix this, in order to see whether it runs there, as first analysis step. Best regards, Michael.