From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master 788a658: Do not save empty passwords in auth-source-search Date: Mon, 20 Sep 2021 07:04:27 +0200 Message-ID: <87o88nn8h0.fsf@gnus.org> References: <20210919175911.21298.44611@vcs0.savannah.gnu.org> <20210919175913.5E6D820ABE@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33422"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Michael Albinus To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Sep 20 07:05:41 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mSBUr-0008U8-BY for ged-emacs-devel@m.gmane-mx.org; Mon, 20 Sep 2021 07:05:41 +0200 Original-Received: from localhost ([::1]:59306 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mSBUp-0001Ru-GH for ged-emacs-devel@m.gmane-mx.org; Mon, 20 Sep 2021 01:05:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47200) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSBTr-0000m0-MN for emacs-devel@gnu.org; Mon, 20 Sep 2021 01:04:39 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:46732) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSBTq-0005gt-6C for emacs-devel@gnu.org; Mon, 20 Sep 2021 01:04:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=tEWC7DkYPMihLANU9N8PIky6IVU1tmt7dsZz7JsGKX8=; b=doGn9lPNmFxgooMdHBpbBg6Z7D Bscb3ZyUoZ+p/4qremc+5HaP2WNmBTdkaOqzy/OP32fSA1im+TiE664ps/J4yfmU1Fxx8R22SVyl8 RpJXfmWnR4YOloOTfyV7d4GH2wbbaPVsF4scVKwilQDs9++RTSt1YV/3+ePllg+az35U=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mSBTh-0005Hv-FJ; Mon, 20 Sep 2021 07:04:32 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAALVBMVEUuIwtVOyFpZlQG BgJIMgZWTRBnVx1xbyt5gzmJczGFek2fklG6spOsl0T///9GbpeoAAAAAWJLR0QOb70wTwAAAAd0 SU1FB+UJFAUDNFRk57UAAAGVSURBVDjL1dO9TsMwEAdwoxbmFgl2eAKkvgBIyQMg1V4QA0POCkwM sRv1AcLHxEDLqXSBibIhgWhNJD7WsCKhknfBLthJQWxd+E/R/XJ2Yp0JIXN1m0X3VK+Rxh+ZGazN BshPWCOEVD2dEpia5+KAkKl6AVU6yW+YBwAuwaT5A6RN4GuoWFgA4YB6vl8CLpMviOhUB5etgwNT x4hSv1mxvznPpUxaiGg6KLu+WF0pNhcyNiAgoO3R4MbtcSyT3qFS6kjdertTkNwfDTQM1ZDuZdmz Bb1vS/Y0XCkVlAFAQ4zHajhOo60HB0xQJvlZt6dG6vXO36nXvr+KyUA3hdDWi6VvbJ/UGhYmJ8i4 HEh83x4/PDmgTNdhWba7aX6eZQU0eRQusRBjzPOPAmjkC9E/3Qyxg6mRRwsB7Uo8qQNy1C1jC1V9 QF3ADoQI8TRQ1jEAKOK0DPqsk7j/DhCLEPt5L3v5Hrt14gd6nU4oIBz289yCGSyPVr9mZ2MZ+PWl A10lRYr7YQZR6/qkXGmUwb058zv47+ATvbpQrpuNH0IAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjEt MDktMjBUMDU6MDM6NTIrMDA6MDA4rBh1AAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIxLTA5LTIwVDA1 OjAzOjUyKzAwOjAwSfGgyQAAAABJRU5ErkJggg== X-Now-Playing: David Grubbs & Nikus Veliotis's _The Harmless Dust_: "The Harmless Dust, Pt. One" In-Reply-To: <20210919175913.5E6D820ABE@vcs0.savannah.gnu.org> (Michael Albinus's message of "Sun, 19 Sep 2021 13:59:12 -0400 (EDT)") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:275099 Archived-At: Michael.Albinus@gmx.de (Michael Albinus) writes: > branch: master > commit 788a65862ed9b9bc0437a016cae7e3ba1282a1a7 > Author: Michael Albinus > Commit: Michael Albinus > > Do not save empty passwords in auth-source-search This apparently leads to: Test auth-source-test-netrc-create-secret condition: (ert-test-failed ((should (string-equal (plist-get auth-info :user) (user-login-name))) :form (string-equal nil "larsi") :value nil)) FAILED 18/23 auth-source-test-netrc-create-secret (0.009026 sec) passed 19/23 auth-source-test-netrc-parse-entry (0.000077 sec) passed 20/23 auth-source-test-netrc-parse-one (0.000046 sec) passed 21/23 auth-source-test-remembrances-of-things-past (0.000052 sec) passed 22/23 auth-source-test-searches (0.001280 sec) Saved new authentication information to session passed 23/23 auth-source-test-secrets-create-secret (0.055276 sec) Ran 23 tests, 22 results as expected, 1 unexpected (2021-09-20 07:02:39+0200, 0.211667 sec) 1 unexpected results: FAILED auth-source-test-netrc-create-secret (But I haven't verified that it's this commit that's the cause.) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no