* Re: master da4f1fa550f: server-eval-at: Signal more specific condition on unreadable result [not found] ` <20230309000923.641B0C13A82@vcs2.savannah.gnu.org> @ 2023-03-09 10:02 ` Robert Pluim 2023-03-11 18:51 ` Sean Whitton 0 siblings, 1 reply; 3+ messages in thread From: Robert Pluim @ 2023-03-09 10:02 UTC (permalink / raw) To: emacs-devel; +Cc: Sean Whitton >>>>> On Wed, 8 Mar 2023 19:09:23 -0500 (EST), Sean Whitton <spwhitton@spwhitton.name> said: Sean> branch: master Sean> commit da4f1fa550f753e76c611b313d4f00987daed5ad Sean> Author: Sean Whitton <spwhitton@spwhitton.name> Sean> Commit: Sean Whitton <spwhitton@spwhitton.name> Sean> server-eval-at: Signal more specific condition on unreadable result Sean> * lisp/server.el (server-return-invalid-read-syntax): New error Sean> signal. Sean> (server-eval-at): Re-signal invalid-read-syntax as Sean> server-return-invalid-read-syntax (bug#61658). Iʼd suggest the following on top: diff --git a/lisp/server.el b/lisp/server.el index 89aedc72d52..1bbfdced5b0 100644 --- a/lisp/server.el +++ b/lisp/server.el @@ -1930,7 +1930,7 @@ server-unload-function nil) (define-error 'server-return-invalid-read-syntax - "Emacs server returned unreadable result of evaluation" + "Result of evaluation by Emacs server is unreadable" 'invalid-read-syntax) (defun server-eval-at (server form) @@ -1941,10 +1941,10 @@ server-eval-at This function signals `error' if it could not contact the server. -This function signals `server-return-invalid-read-syntax' if it -couldn't read the result of evaluation printed by the server. -This will occur whenever the result of evaluating FORM is something -not readably printable." +This function signals `server-return-invalid-read-syntax' if +`read' fails on the result returned by the server. +This will occur whenever the result of evaluating FORM is +something that cannot be printed readably." (let* ((server-dir (if server-use-tcp server-auth-dir server-socket-dir)) (server-file (expand-file-name server server-dir)) (coding-system-for-read 'binary) Robert -- ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: master da4f1fa550f: server-eval-at: Signal more specific condition on unreadable result 2023-03-09 10:02 ` master da4f1fa550f: server-eval-at: Signal more specific condition on unreadable result Robert Pluim @ 2023-03-11 18:51 ` Sean Whitton 2023-03-14 8:22 ` Robert Pluim 0 siblings, 1 reply; 3+ messages in thread From: Sean Whitton @ 2023-03-11 18:51 UTC (permalink / raw) To: Robert Pluim; +Cc: emacs-devel Hello, On Thu 09 Mar 2023 at 11:02AM +01, Robert Pluim wrote: > diff --git a/lisp/server.el b/lisp/server.el > index 89aedc72d52..1bbfdced5b0 100644 > --- a/lisp/server.el > +++ b/lisp/server.el > @@ -1930,7 +1930,7 @@ server-unload-function > nil) > > (define-error 'server-return-invalid-read-syntax > - "Emacs server returned unreadable result of evaluation" > + "Result of evaluation by Emacs server is unreadable" > 'invalid-read-syntax) I find this less good as a user-visible error message. > (defun server-eval-at (server form) > @@ -1941,10 +1941,10 @@ server-eval-at > > This function signals `error' if it could not contact the server. > > -This function signals `server-return-invalid-read-syntax' if it > -couldn't read the result of evaluation printed by the server. > -This will occur whenever the result of evaluating FORM is something > -not readably printable." > +This function signals `server-return-invalid-read-syntax' if > +`read' fails on the result returned by the server. > +This will occur whenever the result of evaluating FORM is > +something that cannot be printed readably." > (let* ((server-dir (if server-use-tcp server-auth-dir server-socket-dir)) > (server-file (expand-file-name server server-dir)) > (coding-system-for-read 'binary) Nice, this makes the wording seem less like a tautology, please install! -- Sean Whitton ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master da4f1fa550f: server-eval-at: Signal more specific condition on unreadable result 2023-03-11 18:51 ` Sean Whitton @ 2023-03-14 8:22 ` Robert Pluim 0 siblings, 0 replies; 3+ messages in thread From: Robert Pluim @ 2023-03-14 8:22 UTC (permalink / raw) To: Sean Whitton; +Cc: emacs-devel >>>>> On Sat, 11 Mar 2023 11:51:22 -0700, Sean Whitton <spwhitton@spwhitton.name> said: Sean> Hello, Sean> On Thu 09 Mar 2023 at 11:02AM +01, Robert Pluim wrote: >> diff --git a/lisp/server.el b/lisp/server.el >> index 89aedc72d52..1bbfdced5b0 100644 >> --- a/lisp/server.el >> +++ b/lisp/server.el >> @@ -1930,7 +1930,7 @@ server-unload-function >> nil) >> >> (define-error 'server-return-invalid-read-syntax >> - "Emacs server returned unreadable result of evaluation" >> + "Result of evaluation by Emacs server is unreadable" >> 'invalid-read-syntax) Sean> I find this less good as a user-visible error message. OK >> (defun server-eval-at (server form) >> @@ -1941,10 +1941,10 @@ server-eval-at >> >> This function signals `error' if it could not contact the server. >> >> -This function signals `server-return-invalid-read-syntax' if it >> -couldn't read the result of evaluation printed by the server. >> -This will occur whenever the result of evaluating FORM is something >> -not readably printable." >> +This function signals `server-return-invalid-read-syntax' if >> +`read' fails on the result returned by the server. >> +This will occur whenever the result of evaluating FORM is >> +something that cannot be printed readably." >> (let* ((server-dir (if server-use-tcp server-auth-dir server-socket-dir)) >> (server-file (expand-file-name server server-dir)) >> (coding-system-for-read 'binary) Sean> Nice, this makes the wording seem less like a tautology, please install! Done as b9a70865d2c Robert -- ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-14 8:22 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <167832056288.21107.13816783611653909117@vcs2.savannah.gnu.org> [not found] ` <20230309000923.641B0C13A82@vcs2.savannah.gnu.org> 2023-03-09 10:02 ` master da4f1fa550f: server-eval-at: Signal more specific condition on unreadable result Robert Pluim 2023-03-11 18:51 ` Sean Whitton 2023-03-14 8:22 ` Robert Pluim
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).