From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: master da4f1fa550f: server-eval-at: Signal more specific condition on unreadable result Date: Thu, 09 Mar 2023 11:02:20 +0100 Message-ID: <87ilfansyb.fsf@gmail.com> References: <167832056288.21107.13816783611653909117@vcs2.savannah.gnu.org> <20230309000923.641B0C13A82@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33928"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Sean Whitton To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Mar 09 11:03:22 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1paD7K-0008az-Ie for ged-emacs-devel@m.gmane-mx.org; Thu, 09 Mar 2023 11:03:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1paD6R-0002uI-C0; Thu, 09 Mar 2023 05:02:27 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1paD6P-0002u9-Cz for emacs-devel@gnu.org; Thu, 09 Mar 2023 05:02:25 -0500 Original-Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1paD6N-00060j-R6 for emacs-devel@gnu.org; Thu, 09 Mar 2023 05:02:25 -0500 Original-Received: by mail-wm1-x32b.google.com with SMTP id j3so745057wms.2 for ; Thu, 09 Mar 2023 02:02:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678356142; h=content-transfer-encoding:mime-version:message-id:date :gmane-reply-to-list:references:in-reply-to:subject:cc:to:from:from :to:cc:subject:date:message-id:reply-to; bh=9lt1rmPbmHavSqGSqJ3w+zoHEcH52219sO4OZGMNzDQ=; b=LMpaoq7htUxxLA7mfrbwXD4hoQMgkTENFTWDzPo5jDhIAunyXpC1wGXyKRzmwF+aZe Gs/Vx5VOOB/TAEl3k67vkEC9JuXullGR44A0TaTskLkPy3pZDcveZ5RwyJsC0Kehtuw+ QgD+hs0PgjkuSOZ8op7zgEPOvj+6BR9x7Atb7DWXgyQ/uZaUMmSPNRHFmpNlpowc8CkS BTAVnWGnhupu8C50SYcrRR//Q1KhYuwZEA2vj19wKZiBOMwhbkunFtB0MwbbVlkEDASU bs3CF/eaHJO2hc2MjF6fCsmvrsLI67RGt8Kk19bgFeFnbanZvOMKR6/ikKtYCNsv13OC YnHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678356142; h=content-transfer-encoding:mime-version:message-id:date :gmane-reply-to-list:references:in-reply-to:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9lt1rmPbmHavSqGSqJ3w+zoHEcH52219sO4OZGMNzDQ=; b=T/6Un6YXFJ+p9K8vJp/xK9wpafHjX7hYGfCy6aTAYUpFeZXekAFBptfB1vWYSg8SAl GX/8lTU56TrawmPevmmqbqgxWTXE0HCmnbv1H3rzspEbv47liJcngHRcHKLdz6pTBvas gk4CrgA2IuKbWgzjka4CQ4XLeb0m71eTJCqc2lh+qU32jWVqCMuwAdwj0M9W3OaZ7hCb 5Sb6uZAn/moXtOYAc5/GqkiOZdBirc3giZ2Calr501Bzkruy72+Bfwfxy3y13zP3E/aF Hns4VMYimSBbuEaGicFgEHuEPprIOehrpdzHTgCecBIcnrv+kPAcliUxSnI4nL9Cuhs6 Td2Q== X-Gm-Message-State: AO0yUKVJRdmbM2CLU2cd4Yqmm6lKJ+ecXFUJOuihAcEbxzFwqD6NSUtg SyV8BJ3Rlgmk2SsDVfsO541LzFsBudA= X-Google-Smtp-Source: AK7set8pz5ep0gZ5MgS3KZUAmf87Jz42VxmbO7VRS1yHnRLNVeR/GsmxpzKODc8O7JXodT5PuDIywA== X-Received: by 2002:a05:600c:190b:b0:3ea:e7f6:f8f9 with SMTP id j11-20020a05600c190b00b003eae7f6f8f9mr18860210wmq.19.1678356141993; Thu, 09 Mar 2023 02:02:21 -0800 (PST) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id t18-20020a05600c199200b003dc4fd6e624sm2172136wmq.19.2023.03.09.02.02.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Mar 2023 02:02:21 -0800 (PST) In-Reply-To: <20230309000923.641B0C13A82@vcs2.savannah.gnu.org> (Sean Whitton's message of "Wed, 8 Mar 2023 19:09:23 -0500 (EST)") Gmane-Reply-To-List: yes Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=rpluim@gmail.com; helo=mail-wm1-x32b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304178 Archived-At: >>>>> On Wed, 8 Mar 2023 19:09:23 -0500 (EST), Sean Whitton said: Sean> branch: master Sean> commit da4f1fa550f753e76c611b313d4f00987daed5ad Sean> Author: Sean Whitton Sean> Commit: Sean Whitton Sean> server-eval-at: Signal more specific condition on unreadable = result =20=20=20=20 Sean> * lisp/server.el (server-return-invalid-read-syntax): New err= or Sean> signal. Sean> (server-eval-at): Re-signal invalid-read-syntax as Sean> server-return-invalid-read-syntax (bug#61658). I=CA=BCd suggest the following on top: diff --git a/lisp/server.el b/lisp/server.el index 89aedc72d52..1bbfdced5b0 100644 --- a/lisp/server.el +++ b/lisp/server.el @@ -1930,7 +1930,7 @@ server-unload-function nil) =20 (define-error 'server-return-invalid-read-syntax - "Emacs server returned unreadable result of evaluation" + "Result of evaluation by Emacs server is unreadable" 'invalid-read-syntax) =20 (defun server-eval-at (server form) @@ -1941,10 +1941,10 @@ server-eval-at =20 This function signals `error' if it could not contact the server. =20 -This function signals `server-return-invalid-read-syntax' if it -couldn't read the result of evaluation printed by the server. -This will occur whenever the result of evaluating FORM is something -not readably printable." +This function signals `server-return-invalid-read-syntax' if +`read' fails on the result returned by the server. +This will occur whenever the result of evaluating FORM is +something that cannot be printed readably." (let* ((server-dir (if server-use-tcp server-auth-dir server-socket-dir)) (server-file (expand-file-name server server-dir)) (coding-system-for-read 'binary) Robert --=20